* [PATCH 1/4] drivers/infiniband/hw/qib/qib_iba6120.c: convert GFP_KERNEL to GFP_ATOMIC
@ 2012-01-09 9:40 Julia Lawall
2012-01-09 16:49 ` Mike Marciniszyn
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2012-01-09 9:40 UTC (permalink / raw)
To: Mike Marciniszyn
Cc: kernel-janitors, Roland Dreier, Sean Hefty, Hal Rosenstock,
linux-rdma, linux-kernel, Julia Lawall
From: Julia Lawall <julia.lawall@lip6.fr>
The function is called with locks held and thus should not use GFP_KERNEL.
The semantic patch that makes this report is available
in scripts/coccinelle/locks/call_kern.cocci.
More information about semantic patching is available at
http://coccinelle.lip6.fr/
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---
drivers/infiniband/hw/qib/qib_iba6120.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/qib/qib_iba6120.c b/drivers/infiniband/hw/qib/qib_iba6120.c
index 781a802..84ab49a 100644
--- a/drivers/infiniband/hw/qib/qib_iba6120.c
+++ b/drivers/infiniband/hw/qib/qib_iba6120.c
@@ -2103,7 +2103,7 @@ static void alloc_dummy_hdrq(struct qib_devdata *dd)
dd->cspec->dummy_hdrq = dma_alloc_coherent(&dd->pcidev->dev,
dd->rcd[0]->rcvhdrq_size,
&dd->cspec->dummy_hdrq_phys,
- GFP_KERNEL | __GFP_COMP);
+ GFP_ATOMIC | __GFP_COMP);
if (!dd->cspec->dummy_hdrq) {
qib_devinfo(dd->pcidev, "Couldn't allocate dummy hdrq\n");
/* fallback to just 0'ing */
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH 1/4] drivers/infiniband/hw/qib/qib_iba6120.c: convert GFP_KERNEL to GFP_ATOMIC
2012-01-09 9:40 [PATCH 1/4] drivers/infiniband/hw/qib/qib_iba6120.c: convert GFP_KERNEL to GFP_ATOMIC Julia Lawall
@ 2012-01-09 16:49 ` Mike Marciniszyn
2012-01-27 17:59 ` Roland Dreier
0 siblings, 1 reply; 3+ messages in thread
From: Mike Marciniszyn @ 2012-01-09 16:49 UTC (permalink / raw)
To: Julia Lawall, Dept_Infinipath
Cc: kernel-janitors, Roland Dreier, Sean Hefty, Hal Rosenstock,
linux-rdma, linux-kernel
> Subject: [PATCH 1/4] drivers/infiniband/hw/qib/qib_iba6120.c: convert
> GFP_KERNEL to GFP_ATOMIC
>
> From: Julia Lawall <julia.lawall@lip6.fr>
>
> The function is called with locks held and thus should not use
> GFP_KERNEL.
>
> The semantic patch that makes this report is available
> in scripts/coccinelle/locks/call_kern.cocci.
>
> More information about semantic patching is available at
> http://coccinelle.lip6.fr/
>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Thanks for the patch!
Acked-by: Mike Marciniszyn <mike.marciniszyn@qlogic.com>
This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/4] drivers/infiniband/hw/qib/qib_iba6120.c: convert GFP_KERNEL to GFP_ATOMIC
2012-01-09 16:49 ` Mike Marciniszyn
@ 2012-01-27 17:59 ` Roland Dreier
0 siblings, 0 replies; 3+ messages in thread
From: Roland Dreier @ 2012-01-27 17:59 UTC (permalink / raw)
To: Mike Marciniszyn
Cc: Julia Lawall, Dept_Infinipath, kernel-janitors, Sean Hefty,
Hal Rosenstock, linux-rdma, linux-kernel
Thanks, applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-27 18:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-09 9:40 [PATCH 1/4] drivers/infiniband/hw/qib/qib_iba6120.c: convert GFP_KERNEL to GFP_ATOMIC Julia Lawall
2012-01-09 16:49 ` Mike Marciniszyn
2012-01-27 17:59 ` Roland Dreier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).