* [PATCH] scripts:kconfig:mconf.c: let make not report error when not save configuration
@ 2012-01-12 3:31 Wang YanQing
2012-01-12 20:50 ` Davidlohr Bueso
0 siblings, 1 reply; 3+ messages in thread
From: Wang YanQing @ 2012-01-12 3:31 UTC (permalink / raw)
To: mmarek; +Cc: linux-kernel, linux-kbuild, lacombar, dave
I find every time when I choice the 'NO' button at the dialog
which let me choice whether to save the configuration before exit
menuconfig, it always report the blow:
" GEN /mnt/sda7/home/build/test/Makefile
HOSTCC scripts/kconfig/mconf.o
HOSTLD scripts/kconfig/mconf
scripts/kconfig/mconf Kconfig
Your configuration changes were NOT saved.
make[2]: *** [menuconfig] Error 1
make[1]: *** [menuconfig] Error 2
make: *** [sub-make] Error 2 "
This patch repair it.
Thanks!
Signed-off-by: Wang YanQing <udknight@gmail.com>
---
scripts/kconfig/mconf.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
index 19e200d..86cd1ea 100644
--- a/scripts/kconfig/mconf.c
+++ b/scripts/kconfig/mconf.c
@@ -830,6 +830,7 @@ static int handle_exit(void)
fprintf(stderr, _("\n\n"
"Your configuration changes were NOT saved."
"\n\n"));
+ res = 0;
}
return res;
--
1.7.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scripts:kconfig:mconf.c: let make not report error when not save configuration
2012-01-12 3:31 [PATCH] scripts:kconfig:mconf.c: let make not report error when not save configuration Wang YanQing
@ 2012-01-12 20:50 ` Davidlohr Bueso
2012-01-14 20:55 ` Michal Marek
0 siblings, 1 reply; 3+ messages in thread
From: Davidlohr Bueso @ 2012-01-12 20:50 UTC (permalink / raw)
To: Wang YanQing; +Cc: mmarek, linux-kernel, linux-kbuild, lacombar
On Thu, 2012-01-12 at 11:31 +0800, Wang YanQing wrote:
> I find every time when I choice the 'NO' button at the dialog
> which let me choice whether to save the configuration before exit
> menuconfig, it always report the blow:
>
> " GEN /mnt/sda7/home/build/test/Makefile
> HOSTCC scripts/kconfig/mconf.o
> HOSTLD scripts/kconfig/mconf
> scripts/kconfig/mconf Kconfig
>
> Your configuration changes were NOT saved.
>
> make[2]: *** [menuconfig] Error 1
> make[1]: *** [menuconfig] Error 2
> make: *** [sub-make] Error 2 "
>
> This patch repair it.
>
> Thanks!
>
> Signed-off-by: Wang YanQing <udknight@gmail.com>
Acked-by: Davidlohr Bueso <dave@gnu.org>
> ---
> scripts/kconfig/mconf.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
> index 19e200d..86cd1ea 100644
> --- a/scripts/kconfig/mconf.c
> +++ b/scripts/kconfig/mconf.c
> @@ -830,6 +830,7 @@ static int handle_exit(void)
> fprintf(stderr, _("\n\n"
> "Your configuration changes were NOT saved."
> "\n\n"));
> + res = 0;
> }
>
> return res;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scripts:kconfig:mconf.c: let make not report error when not save configuration
2012-01-12 20:50 ` Davidlohr Bueso
@ 2012-01-14 20:55 ` Michal Marek
0 siblings, 0 replies; 3+ messages in thread
From: Michal Marek @ 2012-01-14 20:55 UTC (permalink / raw)
To: dave; +Cc: Wang YanQing, linux-kernel, linux-kbuild, lacombar
On 12.1.2012 21:50, Davidlohr Bueso wrote:
> On Thu, 2012-01-12 at 11:31 +0800, Wang YanQing wrote:
>> I find every time when I choice the 'NO' button at the dialog
>> which let me choice whether to save the configuration before exit
>> menuconfig, it always report the blow:
>>
>> " GEN /mnt/sda7/home/build/test/Makefile
>> HOSTCC scripts/kconfig/mconf.o
>> HOSTLD scripts/kconfig/mconf
>> scripts/kconfig/mconf Kconfig
>>
>> Your configuration changes were NOT saved.
>>
>> make[2]: *** [menuconfig] Error 1
>> make[1]: *** [menuconfig] Error 2
>> make: *** [sub-make] Error 2 "
>>
>> This patch repair it.
>>
>> Thanks!
>>
>> Signed-off-by: Wang YanQing <udknight@gmail.com>
>
> Acked-by: Davidlohr Bueso <dave@gnu.org>
Applied to kbuild.git#kconfig.
Michal
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-14 20:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-12 3:31 [PATCH] scripts:kconfig:mconf.c: let make not report error when not save configuration Wang YanQing
2012-01-12 20:50 ` Davidlohr Bueso
2012-01-14 20:55 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).