* [PATCH] kbuild: do not check for ancient modutils tools
@ 2012-01-17 16:50 Lucas De Marchi
2012-01-18 4:33 ` Cong Wang
0 siblings, 1 reply; 5+ messages in thread
From: Lucas De Marchi @ 2012-01-17 16:50 UTC (permalink / raw)
To: linux-kernel; +Cc: Kay Sievers, Michal Marek, linux-modules, Lucas De Marchi
scripts/depmod.sh checks for the output of '-V' expecting that it has
module-init-tools in it. It's a hack to prevent users from using
modutils instead of module-init-tools, that only works with 2.4.x
kernels. This however prints an annoying warning for kmod tool, that is
currently replacing module-init-tools.
Rather than putting another check for kmod's version, just remove it
since users of 2.4.x kernel are unlikely to upgrade to 3.x, and if they
do, let depmod fail in that case because they should know what they are
doing.
Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi>
---
scripts/depmod.sh | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/scripts/depmod.sh b/scripts/depmod.sh
index a272356..2ae4817 100755
--- a/scripts/depmod.sh
+++ b/scripts/depmod.sh
@@ -9,12 +9,6 @@ fi
DEPMOD=$1
KERNELRELEASE=$2
-if ! "$DEPMOD" -V 2>/dev/null | grep -q module-init-tools; then
- echo "Warning: you may need to install module-init-tools" >&2
- echo "See http://www.codemonkey.org.uk/docs/post-halloween-2.6.txt" >&2
- sleep 1
-fi
-
if ! test -r System.map -a -x "$DEPMOD"; then
exit 0
fi
--
1.7.8.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] kbuild: do not check for ancient modutils tools
2012-01-17 16:50 [PATCH] kbuild: do not check for ancient modutils tools Lucas De Marchi
@ 2012-01-18 4:33 ` Cong Wang
2012-01-20 16:40 ` Kay Sievers
0 siblings, 1 reply; 5+ messages in thread
From: Cong Wang @ 2012-01-18 4:33 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: linux-kernel, Kay Sievers, Michal Marek, linux-modules
On Tue, 2012-01-17 at 14:50 -0200, Lucas De Marchi wrote:
> scripts/depmod.sh checks for the output of '-V' expecting that it has
> module-init-tools in it. It's a hack to prevent users from using
> modutils instead of module-init-tools, that only works with 2.4.x
> kernels. This however prints an annoying warning for kmod tool, that is
> currently replacing module-init-tools.
>
> Rather than putting another check for kmod's version, just remove it
> since users of 2.4.x kernel are unlikely to upgrade to 3.x, and if they
> do, let depmod fail in that case because they should know what they are
> doing.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Acked-by: WANG Cong <amwang@redhat.com>
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] kbuild: do not check for ancient modutils tools
2012-01-18 4:33 ` Cong Wang
@ 2012-01-20 16:40 ` Kay Sievers
2012-01-23 14:17 ` Michal Marek
0 siblings, 1 reply; 5+ messages in thread
From: Kay Sievers @ 2012-01-20 16:40 UTC (permalink / raw)
To: Cong Wang; +Cc: Lucas De Marchi, linux-kernel, Michal Marek, linux-modules
On Wed, Jan 18, 2012 at 05:33, Cong Wang <amwang@redhat.com> wrote:
> On Tue, 2012-01-17 at 14:50 -0200, Lucas De Marchi wrote:
>> scripts/depmod.sh checks for the output of '-V' expecting that it has
>> module-init-tools in it. It's a hack to prevent users from using
>> modutils instead of module-init-tools, that only works with 2.4.x
>> kernels. This however prints an annoying warning for kmod tool, that is
>> currently replacing module-init-tools.
>>
>> Rather than putting another check for kmod's version, just remove it
>> since users of 2.4.x kernel are unlikely to upgrade to 3.x, and if they
>> do, let depmod fail in that case because they should know what they are
>> doing.
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi>
>
> Acked-by: WANG Cong <amwang@redhat.com>
Michal, mind picking this up? The warning it produces with kmod is
really misleading, and the check seems unnecessary these days.
Acked-By: Kay Sievers <kay.sievers@vrfy.org>
Thanks,
Kay
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] kbuild: do not check for ancient modutils tools
2012-01-20 16:40 ` Kay Sievers
@ 2012-01-23 14:17 ` Michal Marek
2012-01-23 14:32 ` Lucas De Marchi
0 siblings, 1 reply; 5+ messages in thread
From: Michal Marek @ 2012-01-23 14:17 UTC (permalink / raw)
To: Kay Sievers; +Cc: Cong Wang, Lucas De Marchi, linux-kernel, linux-modules
On Fri, Jan 20, 2012 at 05:40:58PM +0100, Kay Sievers wrote:
> On Wed, Jan 18, 2012 at 05:33, Cong Wang <amwang@redhat.com> wrote:
> > On Tue, 2012-01-17 at 14:50 -0200, Lucas De Marchi wrote:
> >> scripts/depmod.sh checks for the output of '-V' expecting that it has
> >> module-init-tools in it. It's a hack to prevent users from using
> >> modutils instead of module-init-tools, that only works with 2.4.x
> >> kernels. This however prints an annoying warning for kmod tool, that is
> >> currently replacing module-init-tools.
You could call kmod "module-init-tools 3.13 (compatible; kmod 3)" ;)
Just kidding.
> >> Rather than putting another check for kmod's version, just remove it
> >> since users of 2.4.x kernel are unlikely to upgrade to 3.x, and if they
> >> do, let depmod fail in that case because they should know what they are
> >> doing.
> >>
> >> Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi>
> >
> > Acked-by: WANG Cong <amwang@redhat.com>
>
> Michal, mind picking this up? The warning it produces with kmod is
> really misleading, and the check seems unnecessary these days.
I applied it to kbuild.git#rc-fixes and will send it to Linus for 3.3.
Michal
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] kbuild: do not check for ancient modutils tools
2012-01-23 14:17 ` Michal Marek
@ 2012-01-23 14:32 ` Lucas De Marchi
0 siblings, 0 replies; 5+ messages in thread
From: Lucas De Marchi @ 2012-01-23 14:32 UTC (permalink / raw)
To: Michal Marek; +Cc: Kay Sievers, Cong Wang, linux-kernel, linux-modules
On Mon, Jan 23, 2012 at 12:17 PM, Michal Marek <mmarek@suse.cz> wrote:
> On Fri, Jan 20, 2012 at 05:40:58PM +0100, Kay Sievers wrote:
>> On Wed, Jan 18, 2012 at 05:33, Cong Wang <amwang@redhat.com> wrote:
>> > On Tue, 2012-01-17 at 14:50 -0200, Lucas De Marchi wrote:
>> >> scripts/depmod.sh checks for the output of '-V' expecting that it has
>> >> module-init-tools in it. It's a hack to prevent users from using
>> >> modutils instead of module-init-tools, that only works with 2.4.x
>> >> kernels. This however prints an annoying warning for kmod tool, that is
>> >> currently replacing module-init-tools.
>
> You could call kmod "module-init-tools 3.13 (compatible; kmod 3)" ;)
>
> Just kidding.
I even wrote a patch to fake kmod as module-init-tools 4.0. Not worth
applying though :-)
>
>> >> Rather than putting another check for kmod's version, just remove it
>> >> since users of 2.4.x kernel are unlikely to upgrade to 3.x, and if they
>> >> do, let depmod fail in that case because they should know what they are
>> >> doing.
>> >>
>> >> Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi>
>> >
>> > Acked-by: WANG Cong <amwang@redhat.com>
>>
>> Michal, mind picking this up? The warning it produces with kmod is
>> really misleading, and the check seems unnecessary these days.
>
> I applied it to kbuild.git#rc-fixes and will send it to Linus for 3.3.
Thanks
Lucas De Marchi
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-01-23 14:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-17 16:50 [PATCH] kbuild: do not check for ancient modutils tools Lucas De Marchi
2012-01-18 4:33 ` Cong Wang
2012-01-20 16:40 ` Kay Sievers
2012-01-23 14:17 ` Michal Marek
2012-01-23 14:32 ` Lucas De Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).