Re: [patch v4, kernel version 3.2.1] net/ipv4/ip_gre: Ethernet multipoint GRE over IP

[Eric Dumazet <eric.dumazet@gmail.com>]

Le mardi 24 janvier 2012 à 23:11 -0800, Jesse Gross a écrit :

> I think it's actually the opposite - Open vSwitch can be used to
> implement this type of thing as well as for many other use cases.  On
> the other hand, even when implementing a multipoint L2 solution it can
> be useful to have additional levels of control but you can't do that
> with this patch because it essentially statically glues together
> tunneling and bridging.

Unless you can provide a working solution in a very short time, this
patch is a pragmatic one.

Code is not perfect and could be improved (for example using a helper
function to keep ipgre_rcv() shorter and reduce indentation level)

Stefan, could you move this code out of ipgre_rcv() ?


+#ifdef CONFIG_NET_IPGRE_BRIDGE
+                       if (ipv4_is_multicast(tunnel->parms.iph.daddr)) {
+                               tethhdr = eth_hdr(skb);
+                               if (!is_multicast_ether_addr(
+                                       tethhdr->h_source)) {
+                                       head = &tunnel->hash[
+                                               ipgre_tap_bridge_hash(
+                                                       tethhdr->h_source)];
+                                       entry = ipgre_tap_bridge_find_rcu(head,
+                                               tethhdr->h_source);
+                                       if (likely(entry)) {
+                                               entry->raddr = orig_source;
+                                               entry->updated = jiffies;
+                                       } else {
+                                         spin_lock(&tunnel->hash_lock);
+                                         if (!ipgre_tap_bridge_find(head,
+                                               tethhdr->h_source))
+                                               ipgre_tap_bridge_create(
+                                                       head,
+                                                       orig_source,
+                                                       tethhdr->h_source);
+                                         spin_unlock(&tunnel->hash_lock);
+                                       }
+                               }
+                       }
+#endif