From: David Miller <davem@davemloft.net>
To: steweg@ynet.sk
Cc: shemminger@vyatta.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch v4, kernel version 3.2.1] net/ipv4/ip_gre: Ethernet multipoint GRE over IP
Date: Wed, 25 Jan 2012 16:49:39 -0500 (EST) [thread overview]
Message-ID: <20120125.164939.1360578908839469758.davem@davemloft.net> (raw)
In-Reply-To: <CAGsizzKAvAV771vSo0TGx_sU5qXgjOOqVRooK9vOf=XEi1NtXA@mail.gmail.com>
From: Štefan Gula <steweg@ynet.sk>
Date: Wed, 25 Jan 2012 22:01:08 +0100
> 2012/1/25 Stephen Hemminger <shemminger@vyatta.com>:
>> On Wed, 18 Jan 2012 00:33:14 +0100 (CET)
>> Stefan Gula <steweg@ynet.sk> wrote:
>>
>>> From: Stefan Gula <steweg@gmail.com>
>>>
>>> This patch is an extension for current Ethernet over GRE
>>> implementation, which allows user to create virtual bridge (multipoint
>>> VPN) and forward traffic based on Ethernet MAC address information in
>>> it. It simulates the Bridge behavior learning mechanism, but instead
>>> of learning port ID from which given MAC address comes, it learns IP
>>> address of peer which encapsulated given packet. Multicast, Broadcast
>>> and unknown-multicast traffic is send over network as multicast
>>> encapsulated GRE packet, so one Ethernet multipoint GRE tunnel can be
>>> represented as one single virtual switch on logical level and be also
>>> represented as one multicast IPv4 address on network level.
>>>
>>> Signed-off-by: Stefan Gula <steweg@gmail.com>
>>
>> Will this break normal usages of GRE?
>> Compile time options are not acceptable for a standard distribution if
>> it will break it for the other case. It is fine to add the additional data
>> structure elements, but the code in the receive path might get broken?
>>
>>
> No, if you don't decide to compile with given kernel option.. nothing
> happens and original GRE code is leaved intact.
Every distribution is going to want to turn the option on to provide
the feature to their users, so this line of reasoning is not
acceptable.
next prev parent reply other threads:[~2012-01-25 21:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <18947389.2811326843064500.JavaMail.root@5-MeO-DMT.ynet.sk>
2012-01-17 23:33 ` [patch v4, kernel version 3.2.1] net/ipv4/ip_gre: Ethernet multipoint GRE over IP Stefan Gula
2012-01-23 13:12 ` Štefan Gula
2012-01-23 14:13 ` Eric Dumazet
2012-01-23 18:43 ` David Miller
2012-01-23 22:23 ` Štefan Gula
2012-01-25 3:48 ` Joseph Glanville
2012-01-25 4:02 ` David Miller
2012-01-25 7:11 ` Jesse Gross
2012-01-25 7:38 ` Štefan Gula
2012-01-25 8:37 ` Eric Dumazet
2012-01-25 9:17 ` Štefan Gula
2012-01-25 15:25 ` Joseph Glanville
2012-01-25 21:55 ` David Miller
2012-01-25 22:57 ` Štefan Gula
2012-01-25 23:18 ` Dave Taht
2012-01-26 1:37 ` David Miller
2012-01-26 10:57 ` Štefan Gula
2012-01-26 18:30 ` David Miller
2012-01-26 22:24 ` Joseph Glanville
2012-01-27 5:59 ` Eric Dumazet
2012-01-27 10:54 ` Joseph Glanville
2012-01-27 21:55 ` Jesse Gross
2012-01-27 21:50 ` Jesse Gross
2012-01-25 5:53 ` Eric Dumazet
2012-01-25 16:57 ` Stephen Hemminger
2012-01-25 21:01 ` Štefan Gula
2012-01-25 21:49 ` David Miller [this message]
2012-01-25 22:30 ` Štefan Gula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120125.164939.1360578908839469758.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=steweg@ynet.sk \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).