From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Sjur Brændeland" <sjur.brandeland@stericsson.com>
Cc: levinsasha928@gmail.com, netdev@vger.kernel.org,
davem@davemloft.net, linux-kernel@vger.kernel.org,
davej@redhat.com, sjurbren@gmail.com
Subject: Re: [PATCH net] caif: Fix crash due to uninitialized net name-space.
Date: Thu, 26 Jan 2012 07:14:18 +0100 [thread overview]
Message-ID: <1327558458.2605.23.camel@edumazet-laptop> (raw)
In-Reply-To: <1327523631-3480-1-git-send-email-sjur.brandeland@stericsson.com>
Le mercredi 25 janvier 2012 à 21:33 +0100, Sjur Brændeland a écrit :
> net_generic() calls BUG_ON() if called with uninitialized
> network name-space. Add check if net is initialized before
> calling net_generic(). This fixes the following oops:
>
> [ 200.752016] kernel BUG at include/net/netns/generic.h:40!
> ...
> [ 200.752016] [<ffffffff825c3cea>] ? get_cfcnfg+0x3a/0x180
> [ 200.752016] [<ffffffff821cf0b0>] ? lockdep_rtnl_is_held+0x10/0x20
> [ 200.752016] [<ffffffff825c41be>] caif_device_notify+0x2e/0x530
> [ 200.752016] [<ffffffff810d61b7>] notifier_call_chain+0x67/0x110
> [ 200.752016] [<ffffffff810d67c1>] raw_notifier_call_chain+0x11/0x20
> [ 200.752016] [<ffffffff821bae82>] call_netdevice_notifiers+0x32/0x60
> [ 200.752016] [<ffffffff821c2b26>] register_netdevice+0x196/0x300
> [ 200.752016] [<ffffffff821c2ca9>] register_netdev+0x19/0x30
> [ 200.752016] [<ffffffff81c1c67a>] loopback_net_init+0x4a/0xa0
> [ 200.752016] [<ffffffff821b5e62>] ops_init+0x42/0x180
> [ 200.752016] [<ffffffff821b600b>] setup_net+0x6b/0x100
> [ 200.752016] [<ffffffff821b6466>] copy_net_ns+0x86/0x110
> [ 200.752016] [<ffffffff810d5789>] create_new_namespaces+0xd9/0x190
>
> Signed-off-by: Sjur Brændeland <sjur.brandeland@stericsson.com>
> Tested-by: Sasha Levin <levinsasha928@gmail.com>
>
> ---
>
> Hi Sasha and Dave,
>
> [Sasha]
> >Works for me.
> Thank you Sasha for reporting this bug and testing my patch,
> I appreciate it.
>
> [Dave]
> >Please post all networking patches CC:'d
> Sorry, I missed the obvious.
> I'm resending the same patch as yesterday, this time to:netdev
> and with "Tested-by: Sasha". Please apply to net.
>
> Thanks,
> Sjur
>
> net/caif/caif_dev.c | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/net/caif/caif_dev.c b/net/caif/caif_dev.c
> index 673728a..6110ade 100644
> --- a/net/caif/caif_dev.c
> +++ b/net/caif/caif_dev.c
> @@ -371,6 +371,14 @@ static int caif_device_notify(struct notifier_block *me, unsigned long what,
> struct cflayer *layer, *link_support;
> int head_room = 0;
> struct caif_device_entry_list *caifdevs;
> + int len;
> +
> + rcu_read_lock();
> + len = rcu_dereference(dev_net(dev)->gen)->len;
> + rcu_read_unlock();
> +
> + if (caif_net_id == 0 || caif_net_id > len)
> + return 0;
>
> cfg = get_cfcnfg(dev_net(dev));
> caifdevs = caif_device_list(dev_net(dev));
This looks wrong.
This should not be needed, something is broken elsewhere.
next prev parent reply other threads:[~2012-01-26 6:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 7:30 [PATCH] net: caif: Don't act on notification for non-caif devices Sasha Levin
2012-01-24 10:52 ` Sjur Brændeland
2012-01-24 14:49 ` Sasha Levin
2012-01-24 15:06 ` Sjur Brændeland
2012-01-24 15:23 ` Sasha Levin
2012-01-24 22:27 ` [PATCH net] caif: Fix crash due to uninitialized net name-space Sjur Brændeland
2012-01-24 22:44 ` David Miller
2012-01-25 16:13 ` Sasha Levin
2012-01-25 20:33 ` Sjur Brændeland
2012-01-26 6:14 ` Eric Dumazet [this message]
2012-01-26 10:41 ` [PATCH] netns: fix net_alloc_generic() Eric Dumazet
2012-01-26 10:44 ` Pavel Emelyanov
2012-01-26 10:51 ` Eric Dumazet
2012-01-26 22:57 ` Eric W. Biederman
2012-01-26 23:07 ` David Miller
2012-01-26 23:57 ` Eric W. Biederman
2012-01-27 0:02 ` [PATCH 1/2] netns: Fail conspicously if someone uses net_generic at an inappropriate time Eric W. Biederman
2012-01-27 0:04 ` [PATCH 2/2] net caif: Register properly as a pernet subsystem Eric W. Biederman
2012-01-27 13:24 ` Sasha Levin
2012-01-27 14:48 ` Sjur BRENDELAND
2012-01-28 2:07 ` David Miller
2012-01-28 2:07 ` [PATCH 1/2] netns: Fail conspicously if someone uses net_generic at an inappropriate time David Miller
2012-01-27 6:09 ` [PATCH] netns: fix net_alloc_generic() Eric Dumazet
2012-01-27 6:54 ` Eric W. Biederman
2012-01-27 7:07 ` Eric Dumazet
2012-01-26 14:40 ` Sasha Levin
2012-01-26 18:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327558458.2605.23.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sjur.brandeland@stericsson.com \
--cc=sjurbren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).