From: David Miller <davem@davemloft.net>
To: ebiederm@xmission.com
Cc: eric.dumazet@gmail.com, xemul@parallels.com,
sjur.brandeland@stericsson.com, levinsasha928@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davej@redhat.com, sjurbren@gmail.com
Subject: Re: [PATCH] netns: fix net_alloc_generic()
Date: Thu, 26 Jan 2012 18:07:54 -0500 (EST) [thread overview]
Message-ID: <20120126.180754.679593869814492219.davem@davemloft.net> (raw)
In-Reply-To: <m1zkdacbsx.fsf@fess.ebiederm.org>
From: ebiederm@xmission.com (Eric W. Biederman)
Date: Thu, 26 Jan 2012 14:57:02 -0800
> It is not a chicken and egg problem. It is a bug in caif.
> caif is claiming to be a network device when it is acting as a subsytem.
> That means it is being initialized too late.
>
> Untested but this should trivially fix the problem, and a bunch
> of others of the same ilk.
>
> It is not safe to shutdown subsystems until all of the devices
> are gone, otherwise there will be problems with packets in flight.
If you guys can agree that this is the better fix, and we can
get testing showing that it works, I'll revert Eric D.'s patch
and apply the final version of this one.
Thanks.
next prev parent reply other threads:[~2012-01-26 23:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 7:30 [PATCH] net: caif: Don't act on notification for non-caif devices Sasha Levin
2012-01-24 10:52 ` Sjur Brændeland
2012-01-24 14:49 ` Sasha Levin
2012-01-24 15:06 ` Sjur Brændeland
2012-01-24 15:23 ` Sasha Levin
2012-01-24 22:27 ` [PATCH net] caif: Fix crash due to uninitialized net name-space Sjur Brændeland
2012-01-24 22:44 ` David Miller
2012-01-25 16:13 ` Sasha Levin
2012-01-25 20:33 ` Sjur Brændeland
2012-01-26 6:14 ` Eric Dumazet
2012-01-26 10:41 ` [PATCH] netns: fix net_alloc_generic() Eric Dumazet
2012-01-26 10:44 ` Pavel Emelyanov
2012-01-26 10:51 ` Eric Dumazet
2012-01-26 22:57 ` Eric W. Biederman
2012-01-26 23:07 ` David Miller [this message]
2012-01-26 23:57 ` Eric W. Biederman
2012-01-27 0:02 ` [PATCH 1/2] netns: Fail conspicously if someone uses net_generic at an inappropriate time Eric W. Biederman
2012-01-27 0:04 ` [PATCH 2/2] net caif: Register properly as a pernet subsystem Eric W. Biederman
2012-01-27 13:24 ` Sasha Levin
2012-01-27 14:48 ` Sjur BRENDELAND
2012-01-28 2:07 ` David Miller
2012-01-28 2:07 ` [PATCH 1/2] netns: Fail conspicously if someone uses net_generic at an inappropriate time David Miller
2012-01-27 6:09 ` [PATCH] netns: fix net_alloc_generic() Eric Dumazet
2012-01-27 6:54 ` Eric W. Biederman
2012-01-27 7:07 ` Eric Dumazet
2012-01-26 14:40 ` Sasha Levin
2012-01-26 18:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120126.180754.679593869814492219.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=davej@redhat.com \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sjur.brandeland@stericsson.com \
--cc=sjurbren@gmail.com \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).