* [PATCH 1/1] wireless: in _rtl92c_phy_calculate_bit_shift remove comparing bitmask against 1
@ 2012-01-30 10:00 Devendra.Naga
2012-01-30 23:36 ` Larry Finger
0 siblings, 1 reply; 2+ messages in thread
From: Devendra.Naga @ 2012-01-30 10:00 UTC (permalink / raw)
To: Larry.Finger, chaoming_li, linville, paul.gortmaker, joe,
linux-wireless, netdev, linux-kernel
Cc: Devendra.Naga
From: "Devendra.Naga" <devendra.aaru@gmail.com>
in _rtl92c_phy_calculate_bit_shift everytime the right shifted bitmask
is AND with 1 and compared against 1. i.e.
if ((bitmask >> i) & 0x1 == 1)
break;
which in the if condition is anyway becomes a 1 or 0.
Signed-off-by: Devendra.Naga <devendra.aaru@gmail.com>
---
drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c
index 22e998d..a76b223 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c
@@ -177,7 +177,7 @@ u32 _rtl92c_phy_calculate_bit_shift(u32 bitmask)
u32 i;
for (i = 0; i <= 31; i++) {
- if (((bitmask >> i) & 0x1) == 1)
+ if ((bitmask >> i) & 0x1)
break;
}
return i;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] wireless: in _rtl92c_phy_calculate_bit_shift remove comparing bitmask against 1
2012-01-30 10:00 [PATCH 1/1] wireless: in _rtl92c_phy_calculate_bit_shift remove comparing bitmask against 1 Devendra.Naga
@ 2012-01-30 23:36 ` Larry Finger
0 siblings, 0 replies; 2+ messages in thread
From: Larry Finger @ 2012-01-30 23:36 UTC (permalink / raw)
To: Devendra.Naga
Cc: chaoming_li, linville, paul.gortmaker, joe, linux-wireless,
netdev, linux-kernel
On 01/30/2012 04:00 AM, Devendra.Naga wrote:
> From: "Devendra.Naga"<devendra.aaru@gmail.com>
>
> in _rtl92c_phy_calculate_bit_shift everytime the right shifted bitmask
> is AND with 1 and compared against 1. i.e.
> if ((bitmask>> i)& 0x1 == 1)
> break;
> which in the if condition is anyway becomes a 1 or 0.
>
> Signed-off-by: Devendra.Naga<devendra.aaru@gmail.com>
Once again, the patch is OK, but the subject is not good.
Larry
> ---
> drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c
> index 22e998d..a76b223 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c
> @@ -177,7 +177,7 @@ u32 _rtl92c_phy_calculate_bit_shift(u32 bitmask)
> u32 i;
>
> for (i = 0; i<= 31; i++) {
> - if (((bitmask>> i)& 0x1) == 1)
> + if ((bitmask>> i)& 0x1)
> break;
> }
> return i;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-30 23:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-30 10:00 [PATCH 1/1] wireless: in _rtl92c_phy_calculate_bit_shift remove comparing bitmask against 1 Devendra.Naga
2012-01-30 23:36 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).