* [PATCH] regmap: Remove incorrect unreachable comment in regcache_set_val()
@ 2012-01-31 3:48 Axel Lin
2012-01-31 11:25 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2012-01-31 3:48 UTC (permalink / raw)
To: linux-kernel; +Cc: Dimitris Papastamos, Mark Brown
regcache_set_val() returns false if cache[idx] != val.
Thus it actually is not unreachable.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/base/regmap/regcache.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c
index d103401..77ce5ff 100644
--- a/drivers/base/regmap/regcache.c
+++ b/drivers/base/regmap/regcache.c
@@ -389,7 +389,6 @@ bool regcache_set_val(void *base, unsigned int idx,
default:
BUG();
}
- /* unreachable */
return false;
}
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] regmap: Remove incorrect unreachable comment in regcache_set_val()
2012-01-31 3:48 [PATCH] regmap: Remove incorrect unreachable comment in regcache_set_val() Axel Lin
@ 2012-01-31 11:25 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-01-31 11:25 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Dimitris Papastamos
[-- Attachment #1: Type: text/plain, Size: 172 bytes --]
On Tue, Jan 31, 2012 at 11:48:18AM +0800, Axel Lin wrote:
> regcache_set_val() returns false if cache[idx] != val.
> Thus it actually is not unreachable.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-31 11:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-31 3:48 [PATCH] regmap: Remove incorrect unreachable comment in regcache_set_val() Axel Lin
2012-01-31 11:25 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).