* [PATCH] rtlwifi: remove return in _rtl_pci_switch_clk_req
@ 2012-01-31 6:28 Devendra.Naga
2012-01-31 15:52 ` Larry Finger
0 siblings, 1 reply; 2+ messages in thread
From: Devendra.Naga @ 2012-01-31 6:28 UTC (permalink / raw)
To: Larry.Finger, chaoming_li, linville, linux-wireless, netdev,
linux-kernel
Cc: Devendra.Naga
From: "Devendra.Naga" <devendra.aaru@gmail.com>
the return value from _rtl_pci_switch_clk_req is not used by any of its callers.
Signed-off-by: Devendra.Naga <devendra.aaru@gmail.com>
---
drivers/net/wireless/rtlwifi/pci.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
index 5cb2199..9a01909 100644
--- a/drivers/net/wireless/rtlwifi/pci.c
+++ b/drivers/net/wireless/rtlwifi/pci.c
@@ -198,7 +198,7 @@ static bool _rtl_pci_platform_switch_device_pci_aspm(
}
/*When we set 0x01 to enable clk request. Set 0x0 to disable clk req.*/
-static bool _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value)
+static void _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value)
{
struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
@@ -207,8 +207,6 @@ static bool _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value)
if (rtlhal->hw_type == HARDWARE_TYPE_RTL8192SE)
udelay(100);
-
- return true;
}
/*Disable RTL8192SE ASPM & Disable Pci Bridge ASPM*/
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtlwifi: remove return in _rtl_pci_switch_clk_req
2012-01-31 6:28 [PATCH] rtlwifi: remove return in _rtl_pci_switch_clk_req Devendra.Naga
@ 2012-01-31 15:52 ` Larry Finger
0 siblings, 0 replies; 2+ messages in thread
From: Larry Finger @ 2012-01-31 15:52 UTC (permalink / raw)
To: Devendra.Naga; +Cc: chaoming_li, linville, linux-wireless, netdev, linux-kernel
On 01/31/2012 12:28 AM, Devendra.Naga wrote:
> From: "Devendra.Naga"<devendra.aaru@gmail.com>
>
> the return value from _rtl_pci_switch_clk_req is not used by any of its callers.
>
> Signed-off-by: Devendra.Naga<devendra.aaru@gmail.com>
> ---
> drivers/net/wireless/rtlwifi/pci.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks,
Larry
>
> diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
> index 5cb2199..9a01909 100644
> --- a/drivers/net/wireless/rtlwifi/pci.c
> +++ b/drivers/net/wireless/rtlwifi/pci.c
> @@ -198,7 +198,7 @@ static bool _rtl_pci_platform_switch_device_pci_aspm(
> }
>
> /*When we set 0x01 to enable clk request. Set 0x0 to disable clk req.*/
> -static bool _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value)
> +static void _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value)
> {
> struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
> struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
> @@ -207,8 +207,6 @@ static bool _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value)
>
> if (rtlhal->hw_type == HARDWARE_TYPE_RTL8192SE)
> udelay(100);
> -
> - return true;
> }
>
> /*Disable RTL8192SE ASPM& Disable Pci Bridge ASPM*/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-31 15:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-31 6:28 [PATCH] rtlwifi: remove return in _rtl_pci_switch_clk_req Devendra.Naga
2012-01-31 15:52 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).