* [PATCH 1/2 RESEND] gpio: Add missing spin_lock_init in gpio-ml-ioh driver
@ 2012-02-01 2:50 Axel Lin
2012-02-01 2:51 ` [PATCH 2/2 RESEND] gpio: Add missing spin_lock_init in gpio-pch driver Axel Lin
2012-02-02 4:59 ` [PATCH 1/2 RESEND] gpio: Add missing spin_lock_init in gpio-ml-ioh driver Grant Likely
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2012-02-01 2:50 UTC (permalink / raw)
To: linux-kernel; +Cc: Tomoya MORINAGA, Feng Tang, Grant Likely, Linus Walleij
This bug was introduced by commit 54be5663
"gpio-ml-ioh: Support interrupt function" which adds a spinlock to struct
ioh_gpio but never init the spinlock.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/gpio/gpio-ml-ioh.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpio/gpio-ml-ioh.c b/drivers/gpio/gpio-ml-ioh.c
index 461958f..271fd49 100644
--- a/drivers/gpio/gpio-ml-ioh.c
+++ b/drivers/gpio/gpio-ml-ioh.c
@@ -448,6 +448,7 @@ static int __devinit ioh_gpio_probe(struct pci_dev *pdev,
chip->reg = chip->base;
chip->ch = i;
mutex_init(&chip->lock);
+ spin_lock_init(&chip->spinlock);
ioh_gpio_setup(chip, num_ports[i]);
ret = gpiochip_add(&chip->gpio);
if (ret) {
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2 RESEND] gpio: Add missing spin_lock_init in gpio-pch driver
2012-02-01 2:50 [PATCH 1/2 RESEND] gpio: Add missing spin_lock_init in gpio-ml-ioh driver Axel Lin
@ 2012-02-01 2:51 ` Axel Lin
2012-02-02 4:59 ` [PATCH 1/2 RESEND] gpio: Add missing spin_lock_init in gpio-ml-ioh driver Grant Likely
1 sibling, 0 replies; 3+ messages in thread
From: Axel Lin @ 2012-02-01 2:51 UTC (permalink / raw)
To: linux-kernel; +Cc: Tomoya MORINAGA, Feng Tang, Grant Likely, Linus Walleij
This bug was introduced by commit d568a681
"gpio-pch: add spinlock in suspend/resume processing"
which adds a spinlock to struct pch_gpio but never init the spinlock.
Reported-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/gpio/gpio-pch.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c
index f060329..e84eabf 100644
--- a/drivers/gpio/gpio-pch.c
+++ b/drivers/gpio/gpio-pch.c
@@ -392,6 +392,7 @@ static int __devinit pch_gpio_probe(struct pci_dev *pdev,
chip->reg = chip->base;
pci_set_drvdata(pdev, chip);
mutex_init(&chip->lock);
+ spin_lock_init(&chip->spinlock);
pch_gpio_setup(chip);
ret = gpiochip_add(&chip->gpio);
if (ret) {
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2 RESEND] gpio: Add missing spin_lock_init in gpio-ml-ioh driver
2012-02-01 2:50 [PATCH 1/2 RESEND] gpio: Add missing spin_lock_init in gpio-ml-ioh driver Axel Lin
2012-02-01 2:51 ` [PATCH 2/2 RESEND] gpio: Add missing spin_lock_init in gpio-pch driver Axel Lin
@ 2012-02-02 4:59 ` Grant Likely
1 sibling, 0 replies; 3+ messages in thread
From: Grant Likely @ 2012-02-02 4:59 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Tomoya MORINAGA, Feng Tang, Linus Walleij
On Wed, Feb 01, 2012 at 10:50:05AM +0800, Axel Lin wrote:
> This bug was introduced by commit 54be5663
> "gpio-ml-ioh: Support interrupt function" which adds a spinlock to struct
> ioh_gpio but never init the spinlock.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied both, thanks.
g.
> ---
> drivers/gpio/gpio-ml-ioh.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpio/gpio-ml-ioh.c b/drivers/gpio/gpio-ml-ioh.c
> index 461958f..271fd49 100644
> --- a/drivers/gpio/gpio-ml-ioh.c
> +++ b/drivers/gpio/gpio-ml-ioh.c
> @@ -448,6 +448,7 @@ static int __devinit ioh_gpio_probe(struct pci_dev *pdev,
> chip->reg = chip->base;
> chip->ch = i;
> mutex_init(&chip->lock);
> + spin_lock_init(&chip->spinlock);
> ioh_gpio_setup(chip, num_ports[i]);
> ret = gpiochip_add(&chip->gpio);
> if (ret) {
> --
> 1.7.5.4
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-02 4:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-01 2:50 [PATCH 1/2 RESEND] gpio: Add missing spin_lock_init in gpio-ml-ioh driver Axel Lin
2012-02-01 2:51 ` [PATCH 2/2 RESEND] gpio: Add missing spin_lock_init in gpio-pch driver Axel Lin
2012-02-02 4:59 ` [PATCH 1/2 RESEND] gpio: Add missing spin_lock_init in gpio-ml-ioh driver Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).