From: Steven Rostedt <rostedt@goodmis.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Jason Baron <jbaron@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 0/5 v2] [GIT PULL] x86/jump label: Paranoid checks and 2 or 5 byte nops
Date: Wed, 01 Feb 2012 00:08:45 -0500 [thread overview]
Message-ID: <1328072925.5882.57.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <20120131194813.GA12074@elte.hu>
On Tue, 2012-01-31 at 20:48 +0100, Ingo Molnar wrote:
> Attached. (you need to run it through make oldconfig and use the
> defaults.)
Hmm, I'm not able to reproduce it.
Could you apply this patch and run it again. I'm interested in what was
at the location when it tried to do the conversion.
Thanks!
-- Steve
diff --git a/arch/x86/kernel/jump_label.c b/arch/x86/kernel/jump_label.c
index 6173ca6..da12264 100644
--- a/arch/x86/kernel/jump_label.c
+++ b/arch/x86/kernel/jump_label.c
@@ -58,13 +58,17 @@ static void __jump_label_transform(struct jump_entry *entry,
size = JUMP_LABEL_NOP_SIZE;
code.jump = 0xe9;
code.offset = entry->target - (entry->code + size);
- } else
+ } else {
+ unsigned char *ins = ip;
/*
* The location is not a nop that we were expecting,
* something went wrong. Crash the box, as something could be
* corrupting the kernel.
*/
+ printk("Unknown op at %pS (%02x:%02x:%02x:%02x:%02x)\n",
+ ip, ins[0], ins[1], ins[2], ins[3], ins[4]);
BUG();
+ }
} else {
/*
* We are disabling this jump label. If it is not what
next prev parent reply other threads:[~2012-02-01 5:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-28 16:09 [PATCH 0/5 v2] [GIT PULL] x86/jump label: Paranoid checks and 2 or 5 byte nops Steven Rostedt
2012-01-28 16:09 ` [PATCH 1/5 v2] x86/jump-label: Use best default nops for inital jump label calls Steven Rostedt
2012-01-28 16:09 ` [PATCH 2/5 v2] x86/jump-label: Do not bother updating nops if they are correct Steven Rostedt
2012-01-28 16:09 ` [PATCH 3/5 v2] x86/jump-label: Add safety checks to jump label conversions Steven Rostedt
2012-01-28 16:09 ` [PATCH 4/5 v2] jump labels: Add infrastructure to update jump labels at compile time Steven Rostedt
2012-01-28 16:09 ` [PATCH 5/5 v2] x86/jump labels: Use etiher 5 byte or 2 byte jumps Steven Rostedt
2012-01-30 14:48 ` [PATCH 0/5 v2] [GIT PULL] x86/jump label: Paranoid checks and 2 or 5 byte nops Ingo Molnar
2012-01-30 15:07 ` Steven Rostedt
2012-01-31 19:48 ` Ingo Molnar
2012-02-01 5:08 ` Steven Rostedt [this message]
2012-02-01 8:05 ` Ingo Molnar
2012-02-01 13:20 ` Steven Rostedt
2012-02-01 15:21 ` Steven Rostedt
2012-02-02 13:51 ` Ingo Molnar
2012-02-02 14:10 ` H. Peter Anvin
2012-02-02 14:31 ` Steven Rostedt
2012-02-02 22:04 ` Steven Rostedt
2012-02-02 22:07 ` H. Peter Anvin
2012-02-02 22:53 ` Steven Rostedt
2012-02-03 7:36 ` Ingo Molnar
2012-02-03 13:31 ` Steven Rostedt
2012-02-05 11:47 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328072925.5882.57.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).