* [PATCH 1/2] ARM: dma-mapping: its array of pointer
@ 2012-02-17 13:09 Ajeet Yadav
2012-02-18 15:48 ` Tixy
0 siblings, 1 reply; 3+ messages in thread
From: Ajeet Yadav @ 2012-02-17 13:09 UTC (permalink / raw)
To: Russell King, Jon Medhurst, Nicolas Pitre, Catalin Marinas,
Sumit Bhattacharya, linux-arm-kernel, linux-kernel
Cc: Ajeet Yadav
To be consistant with declaration and usage of
consistent_pte it need to be an array of (pte *)
Signed-off-by: Ajeet Yadav <ajeet.yadav.77@gmail.com>
---
arch/arm/mm/dma-mapping.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
index 1aa664a..04bfa76 100644
--- a/arch/arm/mm/dma-mapping.c
+++ b/arch/arm/mm/dma-mapping.c
@@ -170,7 +170,7 @@ static int __init consistent_init(void)
unsigned long base = consistent_base;
unsigned long num_ptes = (CONSISTENT_END - base) >> PMD_SHIFT;
- consistent_pte = kmalloc(num_ptes * sizeof(pte_t), GFP_KERNEL);
+ consistent_pte = kmalloc(num_ptes * sizeof(pte_t *), GFP_KERNEL);
if (!consistent_pte) {
pr_err("%s: no memory\n", __func__);
return -ENOMEM;
--
1.7.8.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] ARM: dma-mapping: its array of pointer
2012-02-17 13:09 [PATCH 1/2] ARM: dma-mapping: its array of pointer Ajeet Yadav
@ 2012-02-18 15:48 ` Tixy
2012-02-22 3:36 ` Ajeet Yadav
0 siblings, 1 reply; 3+ messages in thread
From: Tixy @ 2012-02-18 15:48 UTC (permalink / raw)
To: Ajeet Yadav
Cc: Russell King, Nicolas Pitre, Catalin Marinas, Sumit Bhattacharya,
linux-arm-kernel, linux-kernel
On Fri, 2012-02-17 at 18:39 +0530, Ajeet Yadav wrote:
> To be consistant with declaration and usage of
^^^^^^^^^^
Spelling mistake, should be 'consistent'
> consistent_pte it need to be an array of (pte *)
^^^^
Grammar mistake, should be 'needs'.
>
> Signed-off-by: Ajeet Yadav <ajeet.yadav.77@gmail.com>
The title of this patch is a bit vague, perhaps something like:
"ARM: dma-mapping: Fix the type used for consistent_pte size
calculation"
The actual patch looks correct.
--
Tixy
> ---
> arch/arm/mm/dma-mapping.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
> index 1aa664a..04bfa76 100644
> --- a/arch/arm/mm/dma-mapping.c
> +++ b/arch/arm/mm/dma-mapping.c
> @@ -170,7 +170,7 @@ static int __init consistent_init(void)
> unsigned long base = consistent_base;
> unsigned long num_ptes = (CONSISTENT_END - base) >> PMD_SHIFT;
>
> - consistent_pte = kmalloc(num_ptes * sizeof(pte_t), GFP_KERNEL);
> + consistent_pte = kmalloc(num_ptes * sizeof(pte_t *), GFP_KERNEL);
> if (!consistent_pte) {
> pr_err("%s: no memory\n", __func__);
> return -ENOMEM;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] ARM: dma-mapping: its array of pointer
2012-02-18 15:48 ` Tixy
@ 2012-02-22 3:36 ` Ajeet Yadav
0 siblings, 0 replies; 3+ messages in thread
From: Ajeet Yadav @ 2012-02-22 3:36 UTC (permalink / raw)
To: Tixy
Cc: Russell King, Nicolas Pitre, Catalin Marinas, Sumit Bhattacharya,
linux-arm-kernel, linux-kernel
thanks, reposted with changes.
Ajeet
On Sat, Feb 18, 2012 at 9:18 PM, Tixy <tixy@yxit.co.uk> wrote:
> On Fri, 2012-02-17 at 18:39 +0530, Ajeet Yadav wrote:
>> To be consistant with declaration and usage of
> ^^^^^^^^^^
> Spelling mistake, should be 'consistent'
>
>> consistent_pte it need to be an array of (pte *)
> ^^^^
> Grammar mistake, should be 'needs'.
>
>>
>> Signed-off-by: Ajeet Yadav <ajeet.yadav.77@gmail.com>
>
> The title of this patch is a bit vague, perhaps something like:
> "ARM: dma-mapping: Fix the type used for consistent_pte size
> calculation"
>
> The actual patch looks correct.
>
> --
> Tixy
>
>> ---
>> arch/arm/mm/dma-mapping.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
>> index 1aa664a..04bfa76 100644
>> --- a/arch/arm/mm/dma-mapping.c
>> +++ b/arch/arm/mm/dma-mapping.c
>> @@ -170,7 +170,7 @@ static int __init consistent_init(void)
>> unsigned long base = consistent_base;
>> unsigned long num_ptes = (CONSISTENT_END - base) >> PMD_SHIFT;
>>
>> - consistent_pte = kmalloc(num_ptes * sizeof(pte_t), GFP_KERNEL);
>> + consistent_pte = kmalloc(num_ptes * sizeof(pte_t *), GFP_KERNEL);
>> if (!consistent_pte) {
>> pr_err("%s: no memory\n", __func__);
>> return -ENOMEM;
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-22 3:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-17 13:09 [PATCH 1/2] ARM: dma-mapping: its array of pointer Ajeet Yadav
2012-02-18 15:48 ` Tixy
2012-02-22 3:36 ` Ajeet Yadav
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).