* [PATCH resend] checkpatch.pl: be silent when -q and --ignore is given
@ 2012-02-27 17:45 Artem Bityutskiy
2012-02-29 11:02 ` Artem Bityutskiy
0 siblings, 1 reply; 4+ messages in thread
From: Artem Bityutskiy @ 2012-02-27 17:45 UTC (permalink / raw)
To: Andrew Morton; +Cc: Andy Whitcroft, Linux Kernel Maling List
From: Artem Bityutskiy <dedekind1@gmail.com>
This patch fixes checkpatch.pl when both -q and --ignore are given and
prevents it from printing a
NOTE: Ignored message types: blah
messages.
E.g., if I use -q --ignore PREFER_PACKED,PREFER_ALIGNED, i see:
NOTE: Ignored message types: PREFER_ALIGNED PREFER_PACKED
It makes no sense to print this when -q is given.
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
scripts/checkpatch.pl | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index a3b9782..6fad217 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3394,13 +3394,12 @@ sub process {
}
}
- if (keys %ignore_type) {
+ if ($quiet == 0 && keys %ignore_type) {
print "NOTE: Ignored message types:";
foreach my $ignore (sort keys %ignore_type) {
print " $ignore";
}
- print "\n";
- print "\n" if ($quiet == 0);
+ print "\n\n";
}
if ($clean == 1 && $quiet == 0) {
--
1.7.9
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH resend] checkpatch.pl: be silent when -q and --ignore is given
2012-02-27 17:45 [PATCH resend] checkpatch.pl: be silent when -q and --ignore is given Artem Bityutskiy
@ 2012-02-29 11:02 ` Artem Bityutskiy
2012-02-29 11:25 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Artem Bityutskiy @ 2012-02-29 11:02 UTC (permalink / raw)
To: Andrew Morton; +Cc: Andy Whitcroft, Linux Kernel Maling List
[-- Attachment #1: Type: text/plain, Size: 401 bytes --]
On Mon, 2012-02-27 at 19:45 +0200, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <dedekind1@gmail.com>
>
> This patch fixes checkpatch.pl when both -q and --ignore are given and
> prevents it from printing a
Andrew, am I right that checkpatch.pl patches go in via your tree?
Should I check linux-next to find out whether you have merged it or not?
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH resend] checkpatch.pl: be silent when -q and --ignore is given
2012-02-29 11:02 ` Artem Bityutskiy
@ 2012-02-29 11:25 ` Andrew Morton
2012-02-29 11:30 ` Artem Bityutskiy
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2012-02-29 11:25 UTC (permalink / raw)
To: dedekind1; +Cc: Andy Whitcroft, Linux Kernel Maling List
On Wed, 29 Feb 2012 13:02:06 +0200 Artem Bityutskiy <dedekind1@gmail.com> wrote:
> On Mon, 2012-02-27 at 19:45 +0200, Artem Bityutskiy wrote:
> > From: Artem Bityutskiy <dedekind1@gmail.com>
> >
> > This patch fixes checkpatch.pl when both -q and --ignore are given and
> > prevents it from printing a
>
> Andrew, am I right that checkpatch.pl patches go in via your tree?
yup.
> Should I check linux-next to find out whether you have merged it or not?
I applied it, but it seems that for some reason the applied-to-mm email
didn't get sent out for that one.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH resend] checkpatch.pl: be silent when -q and --ignore is given
2012-02-29 11:25 ` Andrew Morton
@ 2012-02-29 11:30 ` Artem Bityutskiy
0 siblings, 0 replies; 4+ messages in thread
From: Artem Bityutskiy @ 2012-02-29 11:30 UTC (permalink / raw)
To: Andrew Morton; +Cc: Andy Whitcroft, Linux Kernel Maling List
[-- Attachment #1: Type: text/plain, Size: 230 bytes --]
On Wed, 2012-02-29 at 03:25 -0800, Andrew Morton wrote:
> I applied it, but it seems that for some reason the applied-to-mm email
> didn't get sent out for that one.
OK, thanks a lot!
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-02-29 11:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-27 17:45 [PATCH resend] checkpatch.pl: be silent when -q and --ignore is given Artem Bityutskiy
2012-02-29 11:02 ` Artem Bityutskiy
2012-02-29 11:25 ` Andrew Morton
2012-02-29 11:30 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).