linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] [media] s5p-g2d: Make it possible to instantiate driver from DT
@ 2012-02-29 13:54 Karol Lewandowski
  2012-03-01  3:20 ` Thomas Abraham
  0 siblings, 1 reply; 3+ messages in thread
From: Karol Lewandowski @ 2012-02-29 13:54 UTC (permalink / raw)
  To: k.debski
  Cc: m.szyprowski, linux-kernel, devicetree-discuss,
	linux-samsung-soc, Karol Lewandowski, Kyungmin Park

This driver requires standard properties only (address and irq)
which are automatically marshalled into plain old resources by OF core.

Signed-off-by: Karol Lewandowski <k.lewandowsk@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 drivers/media/video/s5p-g2d/g2d.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/drivers/media/video/s5p-g2d/g2d.c b/drivers/media/video/s5p-g2d/g2d.c
index febaa67..e7c0020 100644
--- a/drivers/media/video/s5p-g2d/g2d.c
+++ b/drivers/media/video/s5p-g2d/g2d.c
@@ -20,6 +20,7 @@
 #include <linux/interrupt.h>
 
 #include <linux/platform_device.h>
+#include <linux/of.h>
 #include <media/v4l2-mem2mem.h>
 #include <media/v4l2-device.h>
 #include <media/v4l2-ioctl.h>
@@ -795,12 +796,20 @@ static int g2d_remove(struct platform_device *pdev)
 	return 0;
 }
 
+#ifdef CONFIG_OF
+static struct of_device_id g2d_dt_match[] = {
+	{ .compatible = "samsung,exynos4210-g2d" },
+	{},
+};
+#endif
+
 static struct platform_driver g2d_pdrv = {
 	.probe		= g2d_probe,
 	.remove		= g2d_remove,
 	.driver		= {
 		.name = G2D_NAME,
 		.owner = THIS_MODULE,
+		.of_match_table = of_match_ptr(g2d_dt_match),
 	},
 };
 
-- 
1.7.8.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] [media] s5p-g2d: Make it possible to instantiate driver from DT
  2012-02-29 13:54 [PATCH] [media] s5p-g2d: Make it possible to instantiate driver from DT Karol Lewandowski
@ 2012-03-01  3:20 ` Thomas Abraham
  2012-03-14 11:16   ` Karol Lewandowski
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Abraham @ 2012-03-01  3:20 UTC (permalink / raw)
  To: Karol Lewandowski
  Cc: k.debski, m.szyprowski, linux-kernel, devicetree-discuss,
	linux-samsung-soc, Kyungmin Park

On 29 February 2012 19:24, Karol Lewandowski <k.lewandowsk@samsung.com> wrote:
> This driver requires standard properties only (address and irq)
> which are automatically marshalled into plain old resources by OF core.
>
> Signed-off-by: Karol Lewandowski <k.lewandowsk@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  drivers/media/video/s5p-g2d/g2d.c |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/media/video/s5p-g2d/g2d.c b/drivers/media/video/s5p-g2d/g2d.c
> index febaa67..e7c0020 100644
> --- a/drivers/media/video/s5p-g2d/g2d.c
> +++ b/drivers/media/video/s5p-g2d/g2d.c
> @@ -20,6 +20,7 @@
>  #include <linux/interrupt.h>
>
>  #include <linux/platform_device.h>
> +#include <linux/of.h>
>  #include <media/v4l2-mem2mem.h>
>  #include <media/v4l2-device.h>
>  #include <media/v4l2-ioctl.h>
> @@ -795,12 +796,20 @@ static int g2d_remove(struct platform_device *pdev)
>        return 0;
>  }
>
> +#ifdef CONFIG_OF
> +static struct of_device_id g2d_dt_match[] = {
> +       { .compatible = "samsung,exynos4210-g2d" },

The comment about the base version in the previous patch applies here too.

> +       {},
> +};
> +#endif
> +
>  static struct platform_driver g2d_pdrv = {
>        .probe          = g2d_probe,
>        .remove         = g2d_remove,
>        .driver         = {
>                .name = G2D_NAME,
>                .owner = THIS_MODULE,
> +               .of_match_table = of_match_ptr(g2d_dt_match),
>        },
>  };
>
> --
> 1.7.8.3

Reviewed-by: Thomas Abraham <thomas.abraham@linaro.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] [media] s5p-g2d: Make it possible to instantiate driver from DT
  2012-03-01  3:20 ` Thomas Abraham
@ 2012-03-14 11:16   ` Karol Lewandowski
  0 siblings, 0 replies; 3+ messages in thread
From: Karol Lewandowski @ 2012-03-14 11:16 UTC (permalink / raw)
  To: k.debski
  Cc: m.szyprowski, linux-kernel, devicetree-discuss, thomas.abraham,
	Karol Lewandowski, Kyungmin Park

This driver requires standard properties like (address and irq)
which are automatically marshalled for drivers by OF core.

Signed-off-by: Karol Lewandowski <k.lewandowsk@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 drivers/media/video/s5p-g2d/g2d.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/drivers/media/video/s5p-g2d/g2d.c b/drivers/media/video/s5p-g2d/g2d.c
index febaa67..6a8db51 100644
--- a/drivers/media/video/s5p-g2d/g2d.c
+++ b/drivers/media/video/s5p-g2d/g2d.c
@@ -20,6 +20,7 @@
 #include <linux/interrupt.h>
 
 #include <linux/platform_device.h>
+#include <linux/of.h>
 #include <media/v4l2-mem2mem.h>
 #include <media/v4l2-device.h>
 #include <media/v4l2-ioctl.h>
@@ -795,12 +796,21 @@ static int g2d_remove(struct platform_device *pdev)
 	return 0;
 }
 
+#ifdef CONFIG_OF
+static struct of_device_id g2d_dt_match[] = {
+	{ .compatible = "samsung,s5pv210-g2d" },
+	{},
+};
+MODULE_DEVICE_TABLE(of, g2d_dt_match);
+#endif
+
 static struct platform_driver g2d_pdrv = {
 	.probe		= g2d_probe,
 	.remove		= g2d_remove,
 	.driver		= {
 		.name = G2D_NAME,
 		.owner = THIS_MODULE,
+		.of_match_table = of_match_ptr(g2d_dt_match),
 	},
 };
 
-- 
1.7.9


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-03-14 11:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-29 13:54 [PATCH] [media] s5p-g2d: Make it possible to instantiate driver from DT Karol Lewandowski
2012-03-01  3:20 ` Thomas Abraham
2012-03-14 11:16   ` Karol Lewandowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).