* [PATCH 1/2] page_alloc.c: kill add_from_early_node_map
@ 2012-03-13 15:32 Kautuk Consul
2012-03-13 20:48 ` David Rientjes
2012-03-21 0:32 ` Minchan Kim
0 siblings, 2 replies; 3+ messages in thread
From: Kautuk Consul @ 2012-03-13 15:32 UTC (permalink / raw)
To: Andrew Morton, Al Viro, Mel Gorman, David Rientjes, Tejun Heo,
KAMEZAWA Hiroyuki, Minchan Kim
Cc: linux-mm, linux-kernel, Kautuk Consul
No one seems to be calling add_from_early_node_map anywhere from the
kernel.
Also, deleting this function decreases page_alloc.o file size.
Signed-off-by: Kautuk Consul <consul.kautuk@gmail.com>
---
include/linux/mm.h | 2 --
mm/page_alloc.c | 12 ------------
2 files changed, 0 insertions(+), 14 deletions(-)
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 17b27cd..d8c4339 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -1291,8 +1291,6 @@ extern void get_pfn_range_for_nid(unsigned int nid,
extern unsigned long find_min_pfn_with_active_regions(void);
extern void free_bootmem_with_active_regions(int nid,
unsigned long max_low_pfn);
-int add_from_early_node_map(struct range *range, int az,
- int nr_range, int nid);
extern void sparse_memory_present_with_active_regions(int nid);
#endif /* CONFIG_HAVE_MEMBLOCK_NODE_MAP */
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index a13ded1..3171f4c 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -3925,18 +3925,6 @@ void __init free_bootmem_with_active_regions(int nid, unsigned long max_low_pfn)
}
}
-int __init add_from_early_node_map(struct range *range, int az,
- int nr_range, int nid)
-{
- unsigned long start_pfn, end_pfn;
- int i;
-
- /* need to go over early_node_map to find out good range for node */
- for_each_mem_pfn_range(i, nid, &start_pfn, &end_pfn, NULL)
- nr_range = add_range(range, az, nr_range, start_pfn, end_pfn);
- return nr_range;
-}
-
/**
* sparse_memory_present_with_active_regions - Call memory_present for each active range
* @nid: The node to call memory_present for. If MAX_NUMNODES, all nodes will be used.
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] page_alloc.c: kill add_from_early_node_map
2012-03-13 15:32 [PATCH 1/2] page_alloc.c: kill add_from_early_node_map Kautuk Consul
@ 2012-03-13 20:48 ` David Rientjes
2012-03-21 0:32 ` Minchan Kim
1 sibling, 0 replies; 3+ messages in thread
From: David Rientjes @ 2012-03-13 20:48 UTC (permalink / raw)
To: Kautuk Consul
Cc: Andrew Morton, Al Viro, Mel Gorman, Tejun Heo, KAMEZAWA Hiroyuki,
Minchan Kim, linux-mm, linux-kernel
On Tue, 13 Mar 2012, Kautuk Consul wrote:
> No one seems to be calling add_from_early_node_map anywhere from the
> kernel.
>
> Also, deleting this function decreases page_alloc.o file size.
>
> Signed-off-by: Kautuk Consul <consul.kautuk@gmail.com>
Acked-by: David Rientjes <rientjes@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] page_alloc.c: kill add_from_early_node_map
2012-03-13 15:32 [PATCH 1/2] page_alloc.c: kill add_from_early_node_map Kautuk Consul
2012-03-13 20:48 ` David Rientjes
@ 2012-03-21 0:32 ` Minchan Kim
1 sibling, 0 replies; 3+ messages in thread
From: Minchan Kim @ 2012-03-21 0:32 UTC (permalink / raw)
To: Kautuk Consul
Cc: Andrew Morton, Al Viro, Mel Gorman, David Rientjes, Tejun Heo,
KAMEZAWA Hiroyuki, Minchan Kim, linux-mm, linux-kernel
On Tue, Mar 13, 2012 at 11:32:00AM -0400, Kautuk Consul wrote:
> No one seems to be calling add_from_early_node_map anywhere from the
> kernel.
>
> Also, deleting this function decreases page_alloc.o file size.
>
> Signed-off-by: Kautuk Consul <consul.kautuk@gmail.com>
Reviewed-by: Minchan Kim <minchan@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-21 0:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-13 15:32 [PATCH 1/2] page_alloc.c: kill add_from_early_node_map Kautuk Consul
2012-03-13 20:48 ` David Rientjes
2012-03-21 0:32 ` Minchan Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).