* [PATCH] bug fix for 42142
@ 2012-03-13 18:59 Sathisha Nanjappa
2012-03-13 18:59 ` [PATCH] mpt2sas: Corrected the constant in comparison to a hexadecimal Sathisha Nanjappa
0 siblings, 1 reply; 7+ messages in thread
From: Sathisha Nanjappa @ 2012-03-13 18:59 UTC (permalink / raw)
To: linux-scsi, linux-kernel; +Cc: Sathisha Nanjappa
Minor change to weed out the intended loginfo messages.
Sathisha Nanjappa (1):
mpt2sas: Corrected the constant in comparison to a hexadecimal.
drivers/scsi/mpt2sas/mpt2sas_base.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--
1.7.7.6
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] mpt2sas: Corrected the constant in comparison to a hexadecimal.
2012-03-13 18:59 [PATCH] bug fix for 42142 Sathisha Nanjappa
@ 2012-03-13 18:59 ` Sathisha Nanjappa
2012-03-14 4:21 ` Nandigama, Nagalakshmi
2012-03-14 8:33 ` James Bottomley
0 siblings, 2 replies; 7+ messages in thread
From: Sathisha Nanjappa @ 2012-03-13 18:59 UTC (permalink / raw)
To: linux-scsi, linux-kernel; +Cc: Sathisha Nanjappa
Bugzilla 42142 - mpt2sas: Number specified in wrong base
https://bugzilla.kernel.org/show_bug.cgi?id=42142
Signed-off-by: Sathisha Nanjappa <sathisha.nanjappa@hp.com>
---
drivers/scsi/mpt2sas/mpt2sas_base.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c
index 0b2c955..f9a1244 100644
--- a/drivers/scsi/mpt2sas/mpt2sas_base.c
+++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
@@ -657,7 +657,7 @@ _base_sas_log_info(struct MPT2SAS_ADAPTER *ioc , u32 log_info)
return;
/* eat the loginfos associated with task aborts */
- if (ioc->ignore_loginfos && (log_info == 30050000 || log_info ==
+ if (ioc->ignore_loginfos && (log_info == 0x30050000 || log_info ==
0x31140000 || log_info == 0x31130000))
return;
--
1.7.7.6
^ permalink raw reply related [flat|nested] 7+ messages in thread
* RE: [PATCH] mpt2sas: Corrected the constant in comparison to a hexadecimal.
2012-03-13 18:59 ` [PATCH] mpt2sas: Corrected the constant in comparison to a hexadecimal Sathisha Nanjappa
@ 2012-03-14 4:21 ` Nandigama, Nagalakshmi
2012-03-14 8:33 ` James Bottomley
1 sibling, 0 replies; 7+ messages in thread
From: Nandigama, Nagalakshmi @ 2012-03-14 4:21 UTC (permalink / raw)
To: Sathisha Nanjappa, linux-scsi, linux-kernel, James Bottomley
This patch seem to be fine. Please consider this patch as Acked-by: "Nandigama, Nagalakshmi" <Nagalakshmi.Nandigama@lsi.com>
Regards,
Nagalakshmi
-----Original Message-----
From: linux-scsi-owner@vger.kernel.org [mailto:linux-scsi-owner@vger.kernel.org] On Behalf Of Sathisha Nanjappa
Sent: Wednesday, March 14, 2012 12:29 AM
To: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org
Cc: Sathisha Nanjappa
Subject: [PATCH] mpt2sas: Corrected the constant in comparison to a hexadecimal.
Bugzilla 42142 - mpt2sas: Number specified in wrong base
https://bugzilla.kernel.org/show_bug.cgi?id=42142
Signed-off-by: Sathisha Nanjappa <sathisha.nanjappa@hp.com>
---
drivers/scsi/mpt2sas/mpt2sas_base.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c
index 0b2c955..f9a1244 100644
--- a/drivers/scsi/mpt2sas/mpt2sas_base.c
+++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
@@ -657,7 +657,7 @@ _base_sas_log_info(struct MPT2SAS_ADAPTER *ioc , u32 log_info)
return;
/* eat the loginfos associated with task aborts */
- if (ioc->ignore_loginfos && (log_info == 30050000 || log_info ==
+ if (ioc->ignore_loginfos && (log_info == 0x30050000 || log_info ==
0x31140000 || log_info == 0x31130000))
return;
--
1.7.7.6
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] mpt2sas: Corrected the constant in comparison to a hexadecimal.
2012-03-13 18:59 ` [PATCH] mpt2sas: Corrected the constant in comparison to a hexadecimal Sathisha Nanjappa
2012-03-14 4:21 ` Nandigama, Nagalakshmi
@ 2012-03-14 8:33 ` James Bottomley
2012-03-14 23:36 ` Nanjappa, Sathisha (MCXS, Cupertino)
1 sibling, 1 reply; 7+ messages in thread
From: James Bottomley @ 2012-03-14 8:33 UTC (permalink / raw)
To: Sathisha Nanjappa; +Cc: linux-scsi, linux-kernel
On Tue, 2012-03-13 at 11:59 -0700, Sathisha Nanjappa wrote:
> Bugzilla 42142 - mpt2sas: Number specified in wrong base
> https://bugzilla.kernel.org/show_bug.cgi?id=42142
Do you have a better description ... like what is the user visible
effect of correcting the constant?
James
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] mpt2sas: Corrected the constant in comparison to a hexadecimal.
2012-03-14 8:33 ` James Bottomley
@ 2012-03-14 23:36 ` Nanjappa, Sathisha (MCXS, Cupertino)
2012-03-15 8:56 ` James Bottomley
0 siblings, 1 reply; 7+ messages in thread
From: Nanjappa, Sathisha (MCXS, Cupertino) @ 2012-03-14 23:36 UTC (permalink / raw)
To: James Bottomley; +Cc: linux-scsi, linux-kernel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 678 bytes --]
>
> On Tue, 2012-03-13 at 11:59 -0700, Sathisha Nanjappa wrote:
> > Bugzilla 42142 - mpt2sas: Number specified in wrong base
> > https://bugzilla.kernel.org/show_bug.cgi?id=42142
>
> From: James Bottomley
> Sent: Wednesday, March 14, 2012 1:34 AM
> Do you have a better description ... like what is the user
> visible effect of correcting the constant?
>
Does this look better:
"This fix ensures that the IOP_LOGINFO_CODE_TASK_TERMINATED
messages do not clutter the sas_log_info messages."
Thanks,
-Satish.
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] mpt2sas: Corrected the constant in comparison to a hexadecimal.
2012-03-14 23:36 ` Nanjappa, Sathisha (MCXS, Cupertino)
@ 2012-03-15 8:56 ` James Bottomley
2012-03-15 17:54 ` Nanjappa, Sathisha (MCXS, Cupertino)
0 siblings, 1 reply; 7+ messages in thread
From: James Bottomley @ 2012-03-15 8:56 UTC (permalink / raw)
To: Nanjappa, Sathisha (MCXS, Cupertino); +Cc: linux-scsi, linux-kernel
On Wed, 2012-03-14 at 23:36 +0000, Nanjappa, Sathisha (MCXS, Cupertino)
wrote:
> >
> > On Tue, 2012-03-13 at 11:59 -0700, Sathisha Nanjappa wrote:
> > > Bugzilla 42142 - mpt2sas: Number specified in wrong base
> > > https://bugzilla.kernel.org/show_bug.cgi?id=42142
> >
> > From: James Bottomley
> > Sent: Wednesday, March 14, 2012 1:34 AM
> > Do you have a better description ... like what is the user
> > visible effect of correcting the constant?
> >
>
> Does this look better:
>
> "This fix ensures that the IOP_LOGINFO_CODE_TASK_TERMINATED
> messages do not clutter the sas_log_info messages."
Much better, thanks. The whole point of a commit message is to explain
what you're doing and why you're doing it. Just translating C to
english isn't useful because everyone who looks a kernel patches can
read C.
James
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] mpt2sas: Corrected the constant in comparison to a hexadecimal.
2012-03-15 8:56 ` James Bottomley
@ 2012-03-15 17:54 ` Nanjappa, Sathisha (MCXS, Cupertino)
0 siblings, 0 replies; 7+ messages in thread
From: Nanjappa, Sathisha (MCXS, Cupertino) @ 2012-03-15 17:54 UTC (permalink / raw)
To: James Bottomley
Cc: linux-scsi, linux-kernel, Chris Dunlop, Nandigama, Nagalakshmi
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1431 bytes --]
> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-
> owner@vger.kernel.org] On Behalf Of James Bottomley
> Sent: Thursday, March 15, 2012 1:57 AM
>
> On Wed, 2012-03-14 at 23:36 +0000, Nanjappa, Sathisha (MCXS, Cupertino)
> wrote:
> > >
> > > On Tue, 2012-03-13 at 11:59 -0700, Sathisha Nanjappa wrote:
> > > > Bugzilla 42142 - mpt2sas: Number specified in wrong base
> > > > https://bugzilla.kernel.org/show_bug.cgi?id=42142
> > >
> > > From: James Bottomley
> > > Sent: Wednesday, March 14, 2012 1:34 AM
> > > Do you have a better description ... like what is the user
> > > visible effect of correcting the constant?
> > >
> >
> > Does this look better:
> >
> > "This fix ensures that the IOP_LOGINFO_CODE_TASK_TERMINATED
> > messages do not clutter the sas_log_info messages."
>
> Much better, thanks. The whole point of a commit message is to explain
> what you're doing and why you're doing it. Just translating C to
> english isn't useful because everyone who looks a kernel patches can
> read C.
>
Thanks for clarifying. I'll keep that in mind during my future submittal requests.
FYI, I've received ack's from:
Acked-by: "Nandigama, Nagalakshmi" <Nagalakshmi.Nandigama@lsi.com>
Acked-by: "Chris Dunlop" <chris@onthe.net.au>
-Satish.
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-03-15 17:55 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-13 18:59 [PATCH] bug fix for 42142 Sathisha Nanjappa
2012-03-13 18:59 ` [PATCH] mpt2sas: Corrected the constant in comparison to a hexadecimal Sathisha Nanjappa
2012-03-14 4:21 ` Nandigama, Nagalakshmi
2012-03-14 8:33 ` James Bottomley
2012-03-14 23:36 ` Nanjappa, Sathisha (MCXS, Cupertino)
2012-03-15 8:56 ` James Bottomley
2012-03-15 17:54 ` Nanjappa, Sathisha (MCXS, Cupertino)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).