From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@infradead.org>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Mike Galbraith <efault@gmx.de>, Namhyung Kim <namhyung@gmail.com>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>,
arnaldo.melo@gmail.com,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [GIT PULL 0/5] perf/annotate fixes and improvements
Date: Wed, 2 May 2012 16:42:33 -0300 [thread overview]
Message-ID: <1335987758-11039-1-git-send-email-acme@infradead.org> (raw)
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 38b31bd0cefbb0e69a182d9a94b09a7e648549dc:
perf annotate browser: Don't draw jump connectors for out of function jumps (2012-04-25 14:18:42 -0300)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux perf/annotate
for you to fetch changes up to 0822cc80d9aee026b1ebe43c02dc01e0a0227864:
perf annotate browser: Don't display 0.00 percentages (2012-04-27 17:13:53 -0300)
----------------------------------------------------------------
Perf annotate improvements and fixes:
. Current output:
avtab_search_node
push %rbp
mov %rsp,%rbp
→ callq mcount
movzwl 0x6(%rsi),%edx
and $0x7fff,%dx
test %rdi,%rdi
┌─────↓ jne 20
│ 17: xor %eax,%eax
│ 19: leaveq
│ ← retq
│ nopl 0x0(%rax,%rax,1)
└─→20: mov (%rdi),%rax
test %rax,%rax
↑ je 17
movzwl (%rsi),%ecx
movzwl 0x2(%rsi),%r9d
movzwl 0x4(%rsi),%r8d
movzwl %cx,%esi
movzwl %r9w,%r10d
shl $0x9,%esi
lea (%rsi,%r10,4),%esi
lea (%r8,%rsi,1),%esi
and 0x10(%rdi),%si
movzwl %si,%esi
mov (%rax,%rsi,8),%rax
1.63 test %rax,%rax
↑ je 19
nopw 0x0(%rax,%rax,1)
4.88 60: cmp %cx,(%rax)
↓ jne 7e
cmp %r9w,0x2(%rax)
↓ jne 7e
cmp %r8w,0x4(%rax)
↓ jne 79
test %dx,0x6(%rax)
↑ jne 19
79: cmp %r8w,0x4(%rax)
86.99 7e:↑ ja 17
3.25 mov 0x10(%rax),%rax
3.25 test %rax,%rax
↑ jne 60
leaveq
← retq
. Changes:
- Don't show the big vertical line.
- Add an arrow to the right before call instructions
- Scrap bogus loop detection and instead start showing
arrows from jump (fwd or back) instructions to its targets
when cursor is on jump instruction. Press 'j' to toggle this.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (5):
perf annotate browser: Add a right arrow before call instructions
perf ui browser: Add method to draw up/down arrow line
perf annotate browser: Show current jump, back or forward
perf annotate browser: Remove the vertical line after the percentages
perf annotate browser: Don't display 0.00 percentages
tools/perf/ui/browser.c | 54 ++++++++++++++++++++++++++++--
tools/perf/ui/browser.h | 4 +--
tools/perf/ui/browsers/annotate.c | 66 ++++++++++++++++++-------------------
3 files changed, 86 insertions(+), 38 deletions(-)
next reply other threads:[~2012-05-02 19:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 19:42 Arnaldo Carvalho de Melo [this message]
2012-05-02 19:42 ` [PATCH 1/5] perf annotate browser: Add a right arrow before call instructions Arnaldo Carvalho de Melo
2012-05-02 19:42 ` [PATCH 2/5] perf ui browser: Add method to draw up/down arrow line Arnaldo Carvalho de Melo
2012-05-02 19:42 ` [PATCH 3/5] perf annotate browser: Show current jump, back or forward Arnaldo Carvalho de Melo
2012-05-02 19:42 ` [PATCH 4/5] perf annotate browser: Remove the vertical line after the percentages Arnaldo Carvalho de Melo
2012-05-02 19:42 ` [PATCH 5/5] perf annotate browser: Don't display 0.00 percentages Arnaldo Carvalho de Melo
2012-05-02 19:46 ` [GIT PULL 0/5] perf/annotate fixes and improvements Peter Zijlstra
2012-05-02 19:49 ` Arnaldo Carvalho de Melo
2012-05-02 21:18 ` Arnaldo Carvalho de Melo
2012-05-02 22:19 ` Linus Torvalds
2012-05-03 8:01 ` Peter Zijlstra
2012-05-03 13:05 ` Arnaldo Carvalho de Melo
2012-05-03 13:12 ` Peter Zijlstra
2012-05-03 14:11 ` Namhyung Kim
2012-05-03 15:58 ` Arnaldo Carvalho de Melo
2012-05-03 14:23 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335987758-11039-1-git-send-email-acme@infradead.org \
--to=acme@infradead.org \
--cc=acme@redhat.com \
--cc=arnaldo.melo@gmail.com \
--cc=dsahern@gmail.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@gmail.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).