From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Mike Galbraith <efault@gmx.de>, Namhyung Kim <namhyung@gmail.com>,
Paul Mackerras <paulus@samba.org>,
Stephane Eranian <eranian@google.com>
Subject: Re: [GIT PULL 0/5] perf/annotate fixes and improvements
Date: Wed, 2 May 2012 16:49:44 -0300 [thread overview]
Message-ID: <20120502194944.GD28275@infradead.org> (raw)
In-Reply-To: <1335988003.13683.182.camel@twins>
Em Wed, May 02, 2012 at 09:46:43PM +0200, Peter Zijlstra escreveu:
> On Wed, 2012-05-02 at 16:42 -0300, Arnaldo Carvalho de Melo wrote:
> >
> > avtab_search_node
> > push %rbp
> > mov %rsp,%rbp
> > → callq mcount
> > movzwl 0x6(%rsi),%edx
> > and $0x7fff,%dx
> > test %rdi,%rdi
> > ┌─────↓ jne 20
> > │ 17: xor %eax,%eax
> > │ 19: leaveq
> > │ ← retq
> > │ nopl 0x0(%rax,%rax,1)
> > └─→20: mov (%rdi),%rax
> > test %rax,%rax
> > ↑ je 17
> > movzwl (%rsi),%ecx
> > movzwl 0x2(%rsi),%r9d
> > movzwl 0x4(%rsi),%r8d
> > movzwl %cx,%esi
> > movzwl %r9w,%r10d
> > shl $0x9,%esi
> > lea (%rsi,%r10,4),%esi
> > lea (%r8,%rsi,1),%esi
> > and 0x10(%rdi),%si
> > movzwl %si,%esi
> > mov (%rax,%rsi,8),%rax
> > 1.63 test %rax,%rax
> > ↑ je 19
> > nopw 0x0(%rax,%rax,1)
> > 4.88 60: cmp %cx,(%rax)
> > ↓ jne 7e
> > cmp %r9w,0x2(%rax)
> > ↓ jne 7e
> > cmp %r8w,0x4(%rax)
> > ↓ jne 79
> > test %dx,0x6(%rax)
> > ↑ jne 19
> > 79: cmp %r8w,0x4(%rax)
> > 86.99 7e:↑ ja 17
> > 3.25 mov 0x10(%rax),%rax
> > 3.25 test %rax,%rax
> > ↑ jne 60
> > leaveq
> > ← retq
> >
> > . Changes:
> >
> > - Don't show the big vertical line.
>
> Not sure about that, loosing that separator makes it looks messy.
It was a request from Linus:
commit 3e8b5ddf17d4639d41bc57ecfb51633815b70e49
Author: Arnaldo Carvalho de Melo <acme@redhat.com>
Date: Fri Apr 27 16:44:56 2012 -0300
perf annotate browser: Remove the vertical line after the percentages
It is confusing when used with jump -> target lines.
Requested-by: Linus Torvalds <torvalds@linux-foundation.org>
Make it configurable? Press 'S' and you get a separator? Linus?
- Arnaldo
next prev parent reply other threads:[~2012-05-02 19:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 19:42 [GIT PULL 0/5] perf/annotate fixes and improvements Arnaldo Carvalho de Melo
2012-05-02 19:42 ` [PATCH 1/5] perf annotate browser: Add a right arrow before call instructions Arnaldo Carvalho de Melo
2012-05-02 19:42 ` [PATCH 2/5] perf ui browser: Add method to draw up/down arrow line Arnaldo Carvalho de Melo
2012-05-02 19:42 ` [PATCH 3/5] perf annotate browser: Show current jump, back or forward Arnaldo Carvalho de Melo
2012-05-02 19:42 ` [PATCH 4/5] perf annotate browser: Remove the vertical line after the percentages Arnaldo Carvalho de Melo
2012-05-02 19:42 ` [PATCH 5/5] perf annotate browser: Don't display 0.00 percentages Arnaldo Carvalho de Melo
2012-05-02 19:46 ` [GIT PULL 0/5] perf/annotate fixes and improvements Peter Zijlstra
2012-05-02 19:49 ` Arnaldo Carvalho de Melo [this message]
2012-05-02 21:18 ` Arnaldo Carvalho de Melo
2012-05-02 22:19 ` Linus Torvalds
2012-05-03 8:01 ` Peter Zijlstra
2012-05-03 13:05 ` Arnaldo Carvalho de Melo
2012-05-03 13:12 ` Peter Zijlstra
2012-05-03 14:11 ` Namhyung Kim
2012-05-03 15:58 ` Arnaldo Carvalho de Melo
2012-05-03 14:23 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120502194944.GD28275@infradead.org \
--to=acme@infradead.org \
--cc=dsahern@gmail.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@gmail.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).