* [PATCH 0/2] ideapad: some minor fix
@ 2012-05-03 9:37 Ike Panhc
2012-05-03 9:38 ` [PATCH 1/2] ideapad: remove unused define and fix a typo Ike Panhc
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Ike Panhc @ 2012-05-03 9:37 UTC (permalink / raw)
To: linux-kernel, platform-driver-x86; +Cc: Matthew Garrett
These patches are also available in the git repository at:
git://kernel.ubuntu.com/ikepanhc/public.git ideapad-next
Ike Panhc (2):
ideapad: remove unused define and fix a typo
ideapad: generate valid key event only
drivers/platform/x86/ideapad-laptop.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
--
1.7.9.5
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] ideapad: remove unused define and fix a typo
2012-05-03 9:37 [PATCH 0/2] ideapad: some minor fix Ike Panhc
@ 2012-05-03 9:38 ` Ike Panhc
2012-05-03 9:38 ` [PATCH 2/2] ideapad: generate valid key event only Ike Panhc
2012-05-03 20:31 ` [PATCH 0/2] ideapad: some minor fix Matthew Garrett
2 siblings, 0 replies; 4+ messages in thread
From: Ike Panhc @ 2012-05-03 9:38 UTC (permalink / raw)
To: linux-kernel, platform-driver-x86; +Cc: Matthew Garrett
After review the current ideapad-laptop, found an unused define and
a typo.
Signed-off-by: Ike Panhc <ike.pan@canonical.com>
---
drivers/platform/x86/ideapad-laptop.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
index ac902f7..00d82f1 100644
--- a/drivers/platform/x86/ideapad-laptop.c
+++ b/drivers/platform/x86/ideapad-laptop.c
@@ -194,7 +194,6 @@ static int write_ec_cmd(acpi_handle handle, int cmd, unsigned long data)
/*
* debugfs
*/
-#define DEBUGFS_EVENT_LEN (4096)
static int debugfs_status_show(struct seq_file *s, void *data)
{
unsigned long value;
@@ -315,7 +314,7 @@ static int __devinit ideapad_debugfs_init(struct ideapad_private *priv)
node = debugfs_create_file("status", S_IRUGO, priv->debug, NULL,
&debugfs_status_fops);
if (!node) {
- pr_err("failed to create event in debugfs");
+ pr_err("failed to create status in debugfs");
goto errout;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] ideapad: generate valid key event only
2012-05-03 9:37 [PATCH 0/2] ideapad: some minor fix Ike Panhc
2012-05-03 9:38 ` [PATCH 1/2] ideapad: remove unused define and fix a typo Ike Panhc
@ 2012-05-03 9:38 ` Ike Panhc
2012-05-03 20:31 ` [PATCH 0/2] ideapad: some minor fix Matthew Garrett
2 siblings, 0 replies; 4+ messages in thread
From: Ike Panhc @ 2012-05-03 9:38 UTC (permalink / raw)
To: linux-kernel, platform-driver-x86; +Cc: Matthew Garrett
Otherwise will generate KEY_UNKNOWN on un-listed vpc event,
which means nothing and is hard for user to report the detail
of the event.
Signed-off-by: Ike Panhc <ike.pan@canonical.com>
---
drivers/platform/x86/ideapad-laptop.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
index 00d82f1..4f20f8d 100644
--- a/drivers/platform/x86/ideapad-laptop.c
+++ b/drivers/platform/x86/ideapad-laptop.c
@@ -784,6 +784,10 @@ static void ideapad_acpi_notify(struct acpi_device *adevice, u32 event)
case 9:
ideapad_sync_rfk_state(priv);
break;
+ case 13:
+ case 6:
+ ideapad_input_report(priv, vpc_bit);
+ break;
case 4:
ideapad_backlight_notify_brightness(priv);
break;
@@ -794,7 +798,7 @@ static void ideapad_acpi_notify(struct acpi_device *adevice, u32 event)
ideapad_backlight_notify_power(priv);
break;
default:
- ideapad_input_report(priv, vpc_bit);
+ pr_info("Unknown event: %lu\n", vpc_bit);
}
}
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] ideapad: some minor fix
2012-05-03 9:37 [PATCH 0/2] ideapad: some minor fix Ike Panhc
2012-05-03 9:38 ` [PATCH 1/2] ideapad: remove unused define and fix a typo Ike Panhc
2012-05-03 9:38 ` [PATCH 2/2] ideapad: generate valid key event only Ike Panhc
@ 2012-05-03 20:31 ` Matthew Garrett
2 siblings, 0 replies; 4+ messages in thread
From: Matthew Garrett @ 2012-05-03 20:31 UTC (permalink / raw)
To: Ike Panhc; +Cc: linux-kernel, platform-driver-x86
Merged for next, thanks.
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-05-03 20:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-03 9:37 [PATCH 0/2] ideapad: some minor fix Ike Panhc
2012-05-03 9:38 ` [PATCH 1/2] ideapad: remove unused define and fix a typo Ike Panhc
2012-05-03 9:38 ` [PATCH 2/2] ideapad: generate valid key event only Ike Panhc
2012-05-03 20:31 ` [PATCH 0/2] ideapad: some minor fix Matthew Garrett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).