* [PATCH] [media] az6007: Fix dubious use of !x & y
@ 2012-05-03 14:42 Emil Goode
0 siblings, 0 replies; only message in thread
From: Emil Goode @ 2012-05-03 14:42 UTC (permalink / raw)
To: mchehab, jareguero; +Cc: linux-media, linux-kernel, kernel-janitors, Emil Goode
The intent here must be to check if the right most bit
of msgs[i].flags is set and then do the logical negation.
Used macro:
#define I2C_M_RD 0x0001
Sparse warns about this:
drivers/media/dvb/dvb-usb/az6007.c:714:40:
warning: dubious: !x & y
Signed-off-by: Emil Goode <emilgoode@gmail.com>
---
drivers/media/dvb/dvb-usb/az6007.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/dvb/dvb-usb/az6007.c b/drivers/media/dvb/dvb-usb/az6007.c
index 4008b9c..0019335a 100644
--- a/drivers/media/dvb/dvb-usb/az6007.c
+++ b/drivers/media/dvb/dvb-usb/az6007.c
@@ -711,7 +711,7 @@ static int az6007_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[],
addr = msgs[i].addr << 1;
if (((i + 1) < num)
&& (msgs[i].len == 1)
- && (!msgs[i].flags & I2C_M_RD)
+ && !(msgs[i].flags & I2C_M_RD)
&& (msgs[i + 1].flags & I2C_M_RD)
&& (msgs[i].addr == msgs[i + 1].addr)) {
/*
--
1.7.9.5
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-05-03 14:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-03 14:42 [PATCH] [media] az6007: Fix dubious use of !x & y Emil Goode
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).