linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH RESEND] x86: kernel/check.c simple_strtoul cleanup
@ 2012-05-06 17:55 Shuah Khan
  2012-05-14 15:01 ` Shuah Khan
  2012-05-16 21:43 ` [tip:x86/cleanups] " tip-bot for Shuah Khan
  0 siblings, 2 replies; 3+ messages in thread
From: Shuah Khan @ 2012-05-06 17:55 UTC (permalink / raw)
  To: mingo, hpa, tglx; +Cc: shuahkhan, linux-kernel

Change set_corruption_check() and set_corruption_check_period()
in kernel/check.c to call kstrtoul() instead of calling
obsoleted simple_strtoul().


Signed-off-by: Shuah Khan <shuahkhan@gmail.com>
---
 arch/x86/kernel/check.c |   20 ++++++++++++++------
 1 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/arch/x86/kernel/check.c b/arch/x86/kernel/check.c
index 5da1269..e2dbcb7 100644
--- a/arch/x86/kernel/check.c
+++ b/arch/x86/kernel/check.c
@@ -27,21 +27,29 @@ static int num_scan_areas;
 
 static __init int set_corruption_check(char *arg)
 {
-	char *end;
+	ssize_t ret;
+	unsigned long val;
 
-	memory_corruption_check = simple_strtol(arg, &end, 10);
+	ret = kstrtoul(arg, 10, &val);
+	if (ret)
+		return ret;
 
-	return (*end == 0) ? 0 : -EINVAL;
+	memory_corruption_check = val;
+	return 0;
 }
 early_param("memory_corruption_check", set_corruption_check);
 
 static __init int set_corruption_check_period(char *arg)
 {
-	char *end;
+	ssize_t ret;
+	unsigned long val;
 
-	corruption_check_period = simple_strtoul(arg, &end, 10);
+	ret = kstrtoul(arg, 10, &val);
+	if (ret)
+		return ret;
 
-	return (*end == 0) ? 0 : -EINVAL;
+	corruption_check_period = val;
+	return 0;
 }
 early_param("memory_corruption_check_period", set_corruption_check_period);
 
-- 
1.7.5.4




^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] x86: kernel/check.c simple_strtoul cleanup
  2012-05-06 17:55 [PATCH RESEND] x86: kernel/check.c simple_strtoul cleanup Shuah Khan
@ 2012-05-14 15:01 ` Shuah Khan
  2012-05-16 21:43 ` [tip:x86/cleanups] " tip-bot for Shuah Khan
  1 sibling, 0 replies; 3+ messages in thread
From: Shuah Khan @ 2012-05-14 15:01 UTC (permalink / raw)
  To: mingo; +Cc: shuahkhan, hpa, tglx, linux-kernel

On Sun, 2012-05-06 at 11:55 -0600, Shuah Khan wrote:
> Change set_corruption_check() and set_corruption_check_period()
> in kernel/check.c to call kstrtoul() instead of calling
> obsoleted simple_strtoul().

How about this patch? Are you not interested in this type of cleanup
patches? Looking for some feedback so I can spend my energies on
something that would be worth while in the future :)

-- Shuah
> 
> 
> Signed-off-by: Shuah Khan <shuahkhan@gmail.com>
> ---
>  arch/x86/kernel/check.c |   20 ++++++++++++++------
>  1 files changed, 14 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/x86/kernel/check.c b/arch/x86/kernel/check.c
> index 5da1269..e2dbcb7 100644
> --- a/arch/x86/kernel/check.c
> +++ b/arch/x86/kernel/check.c
> @@ -27,21 +27,29 @@ static int num_scan_areas;
>  
>  static __init int set_corruption_check(char *arg)
>  {
> -	char *end;
> +	ssize_t ret;
> +	unsigned long val;
>  
> -	memory_corruption_check = simple_strtol(arg, &end, 10);
> +	ret = kstrtoul(arg, 10, &val);
> +	if (ret)
> +		return ret;
>  
> -	return (*end == 0) ? 0 : -EINVAL;
> +	memory_corruption_check = val;
> +	return 0;
>  }
>  early_param("memory_corruption_check", set_corruption_check);
>  
>  static __init int set_corruption_check_period(char *arg)
>  {
> -	char *end;
> +	ssize_t ret;
> +	unsigned long val;
>  
> -	corruption_check_period = simple_strtoul(arg, &end, 10);
> +	ret = kstrtoul(arg, 10, &val);
> +	if (ret)
> +		return ret;
>  
> -	return (*end == 0) ? 0 : -EINVAL;
> +	corruption_check_period = val;
> +	return 0;
>  }
>  early_param("memory_corruption_check_period", set_corruption_check_period);
>  



^ permalink raw reply	[flat|nested] 3+ messages in thread
* [tip:x86/cleanups] x86: kernel/check.c simple_strtoul cleanup
  2012-05-06 17:55 [PATCH RESEND] x86: kernel/check.c simple_strtoul cleanup Shuah Khan
  2012-05-14 15:01 ` Shuah Khan
@ 2012-05-16 21:43 ` tip-bot for Shuah Khan
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Shuah Khan @ 2012-05-16 21:43 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, shuahkhan, tglx, hpa

Commit-ID:  5abe68e493e5aea1ccfc384092f8e98a542b336a
Gitweb:     http://git.kernel.org/tip/5abe68e493e5aea1ccfc384092f8e98a542b336a
Author:     Shuah Khan <shuahkhan@gmail.com>
AuthorDate: Sun, 6 May 2012 11:55:08 -0600
Committer:  H. Peter Anvin <hpa@linux.intel.com>
CommitDate: Tue, 15 May 2012 15:36:41 -0700

x86: kernel/check.c simple_strtoul cleanup

Change set_corruption_check() and set_corruption_check_period()
in kernel/check.c to call kstrtoul() instead of calling
obsoleted simple_strtoul().

Signed-off-by: Shuah Khan <shuahkhan@gmail.com>
Link: http://lkml.kernel.org/r/1336326908.2897.12.camel@lorien2
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
---
 arch/x86/kernel/check.c |   20 ++++++++++++++------
 1 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/arch/x86/kernel/check.c b/arch/x86/kernel/check.c
index 5da1269..e2dbcb7 100644
--- a/arch/x86/kernel/check.c
+++ b/arch/x86/kernel/check.c
@@ -27,21 +27,29 @@ static int num_scan_areas;
 
 static __init int set_corruption_check(char *arg)
 {
-	char *end;
+	ssize_t ret;
+	unsigned long val;
 
-	memory_corruption_check = simple_strtol(arg, &end, 10);
+	ret = kstrtoul(arg, 10, &val);
+	if (ret)
+		return ret;
 
-	return (*end == 0) ? 0 : -EINVAL;
+	memory_corruption_check = val;
+	return 0;
 }
 early_param("memory_corruption_check", set_corruption_check);
 
 static __init int set_corruption_check_period(char *arg)
 {
-	char *end;
+	ssize_t ret;
+	unsigned long val;
 
-	corruption_check_period = simple_strtoul(arg, &end, 10);
+	ret = kstrtoul(arg, 10, &val);
+	if (ret)
+		return ret;
 
-	return (*end == 0) ? 0 : -EINVAL;
+	corruption_check_period = val;
+	return 0;
 }
 early_param("memory_corruption_check_period", set_corruption_check_period);
 

^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-16 21:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-06 17:55 [PATCH RESEND] x86: kernel/check.c simple_strtoul cleanup Shuah Khan
2012-05-14 15:01 ` Shuah Khan
2012-05-16 21:43 ` [tip:x86/cleanups] " tip-bot for Shuah Khan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).