linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/3] scsi: downgrade "write through" error to notice
@ 2012-05-08 10:20 Paul Bolle
  0 siblings, 0 replies; only message in thread
From: Paul Bolle @ 2012-05-08 10:20 UTC (permalink / raw)
  To: James E.J. Bottomley; +Cc: linux-scsi, linux-kernel

For some reason all USB memory sticks I happen to have trigger an
    Assuming drive cache: write through

error when inserted into a USB port. But if one looks at the code
paths that trigger this error one notices that in most cases either:
- write through is explicitly requested (via the usb-storage
  NO_WP_DETECT flag);
- preceded by a previous error; or
- preceded by an ordinary notice.

So it seems this error can be safely downgraded to a notice.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
 drivers/scsi/sd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 5ba5c2a..a887491 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -2258,7 +2258,7 @@ bad_sense:
 		sd_printk(KERN_ERR, sdkp, "Asking for cache data failed\n");
 
 defaults:
-	sd_printk(KERN_ERR, sdkp, "Assuming drive cache: write through\n");
+	sd_printk(KERN_NOTICE, sdkp, "Assuming drive cache: write through\n");
 	sdkp->WCE = 0;
 	sdkp->RCD = 0;
 	sdkp->DPOFUA = 0;
-- 
1.7.7.6





^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2012-05-08 10:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-08 10:20 [PATCH 1/3] scsi: downgrade "write through" error to notice Paul Bolle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).