* [patch] UBI: add in hex the value for UBI_INTERNAL_VOL_START to comment
@ 2012-05-20 11:42 Joel Reardon
2012-05-20 18:32 ` Artem Bityutskiy
0 siblings, 1 reply; 2+ messages in thread
From: Joel Reardon @ 2012-05-20 11:42 UTC (permalink / raw)
To: Artem Bityutskiy; +Cc: linux-mtd, linux-kernel
Explicitly provide the first internal volume ID value in the comment for
UBI_INTERNAL_VOL_START. This allows developers who, when adding features
related to volume ids and observe unexpected very large volume ids, to grep
for the observed value in the source code and find out immediately that it is
expected behaviour.
Signed-off-by: Joel Reardon <reardonj@inf.ethz.ch>
---
drivers/mtd/ubi/ubi-media.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/ubi/ubi-media.h b/drivers/mtd/ubi/ubi-media.h
index 6fb8ec2..9dab25d 100644
--- a/drivers/mtd/ubi/ubi-media.h
+++ b/drivers/mtd/ubi/ubi-media.h
@@ -298,8 +298,8 @@ struct ubi_vid_hdr {
#define UBI_INT_VOL_COUNT 1
/*
- * Starting ID of internal volumes. There is reserved room for 4096 internal
- * volumes.
+ * Starting ID of internal volumes: 0x7fffefff.
+ * There is reserved room for 4096 internal volumes.
*/
#define UBI_INTERNAL_VOL_START (0x7FFFFFFF - 4096)
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] UBI: add in hex the value for UBI_INTERNAL_VOL_START to comment
2012-05-20 11:42 [patch] UBI: add in hex the value for UBI_INTERNAL_VOL_START to comment Joel Reardon
@ 2012-05-20 18:32 ` Artem Bityutskiy
0 siblings, 0 replies; 2+ messages in thread
From: Artem Bityutskiy @ 2012-05-20 18:32 UTC (permalink / raw)
To: Joel Reardon; +Cc: linux-mtd, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 552 bytes --]
On Sun, 2012-05-20 at 13:42 +0200, Joel Reardon wrote:
> Explicitly provide the first internal volume ID value in the comment for
> UBI_INTERNAL_VOL_START. This allows developers who, when adding features
> related to volume ids and observe unexpected very large volume ids, to grep
> for the observed value in the source code and find out immediately that it is
> expected behaviour.
>
> Signed-off-by: Joel Reardon <reardonj@inf.ethz.ch>
Pushed to linux-ubi.git, it is also in your branch, thanks!
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-20 18:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-20 11:42 [patch] UBI: add in hex the value for UBI_INTERNAL_VOL_START to comment Joel Reardon
2012-05-20 18:32 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).