* [PATCH RESEND] gpio: fix bits conflict for gpio flags
@ 2012-06-20 8:44 Laxman Dewangan
2012-06-20 9:10 ` Linus Walleij
2012-07-05 13:04 ` Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Laxman Dewangan @ 2012-06-20 8:44 UTC (permalink / raw)
To: grant.likely, linus.walleij; +Cc: linux-kernel, Laxman Dewangan
The bit 2 and 3 in GPIO flag are allocated for the
flag OPEN_DRAIN/OPEN_SOURCE. These bits are reused
for the flag EXPORT/EXPORT_CHANGEABLE and so creating
conflict.
Fix this conflict by assigning bit 4 and 5 for the
flag EXPORT/EXPORT_CHANGEABLE.
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
Resending this patch in case of if previous patch lost.
include/linux/gpio.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/gpio.h b/include/linux/gpio.h
index f07fc2d..2e31e8b 100644
--- a/include/linux/gpio.h
+++ b/include/linux/gpio.h
@@ -22,8 +22,8 @@
/* Gpio pin is open source */
#define GPIOF_OPEN_SOURCE (1 << 3)
-#define GPIOF_EXPORT (1 << 2)
-#define GPIOF_EXPORT_CHANGEABLE (1 << 3)
+#define GPIOF_EXPORT (1 << 4)
+#define GPIOF_EXPORT_CHANGEABLE (1 << 5)
#define GPIOF_EXPORT_DIR_FIXED (GPIOF_EXPORT)
#define GPIOF_EXPORT_DIR_CHANGEABLE (GPIOF_EXPORT | GPIOF_EXPORT_CHANGEABLE)
--
1.7.1.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] gpio: fix bits conflict for gpio flags
2012-06-20 8:44 [PATCH RESEND] gpio: fix bits conflict for gpio flags Laxman Dewangan
@ 2012-06-20 9:10 ` Linus Walleij
2012-07-05 13:04 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2012-06-20 9:10 UTC (permalink / raw)
To: Laxman Dewangan; +Cc: grant.likely, linus.walleij, linux-kernel, stable
On Wed, Jun 20, 2012 at 10:44 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
> The bit 2 and 3 in GPIO flag are allocated for the
> flag OPEN_DRAIN/OPEN_SOURCE. These bits are reused
> for the flag EXPORT/EXPORT_CHANGEABLE and so creating
> conflict.
> Fix this conflict by assigning bit 4 and 5 for the
> flag EXPORT/EXPORT_CHANGEABLE.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
This should be Cc: to stable as well I think.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] gpio: fix bits conflict for gpio flags
2012-06-20 8:44 [PATCH RESEND] gpio: fix bits conflict for gpio flags Laxman Dewangan
2012-06-20 9:10 ` Linus Walleij
@ 2012-07-05 13:04 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2012-07-05 13:04 UTC (permalink / raw)
To: Laxman Dewangan; +Cc: grant.likely, linus.walleij, linux-kernel
On Wed, Jun 20, 2012 at 10:44 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
> The bit 2 and 3 in GPIO flag are allocated for the
> flag OPEN_DRAIN/OPEN_SOURCE. These bits are reused
> for the flag EXPORT/EXPORT_CHANGEABLE and so creating
> conflict.
> Fix this conflict by assigning bit 4 and 5 for the
> flag EXPORT/EXPORT_CHANGEABLE.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> ---
> Resending this patch in case of if previous patch lost.
Applied.
Thanks,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH RESEND] gpio: fix bits conflict for gpio flags
@ 2012-05-21 18:05 Laxman Dewangan
0 siblings, 0 replies; 4+ messages in thread
From: Laxman Dewangan @ 2012-05-21 18:05 UTC (permalink / raw)
To: grant.likely, linus.walleij; +Cc: linux-kernel, Laxman Dewangan
The bit 2 and 3 in GPIO flag are allocated for the
flag OPEN_DRAIN/OPEN_SOURCE. These bits are reused
for the flag EXPORT/EXPORT_CHANGEABLE and so creating
conflict.
Fix this conflict by assigning bit 4 and 5 for the
flag EXPORT/EXPORT_CHANGEABLE.
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
Resending this patch in case of if previous patch lost.
include/linux/gpio.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/gpio.h b/include/linux/gpio.h
index f07fc2d..2e31e8b 100644
--- a/include/linux/gpio.h
+++ b/include/linux/gpio.h
@@ -22,8 +22,8 @@
/* Gpio pin is open source */
#define GPIOF_OPEN_SOURCE (1 << 3)
-#define GPIOF_EXPORT (1 << 2)
-#define GPIOF_EXPORT_CHANGEABLE (1 << 3)
+#define GPIOF_EXPORT (1 << 4)
+#define GPIOF_EXPORT_CHANGEABLE (1 << 5)
#define GPIOF_EXPORT_DIR_FIXED (GPIOF_EXPORT)
#define GPIOF_EXPORT_DIR_CHANGEABLE (GPIOF_EXPORT | GPIOF_EXPORT_CHANGEABLE)
--
1.7.1.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-07-05 13:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-20 8:44 [PATCH RESEND] gpio: fix bits conflict for gpio flags Laxman Dewangan
2012-06-20 9:10 ` Linus Walleij
2012-07-05 13:04 ` Linus Walleij
-- strict thread matches above, loose matches on Subject: below --
2012-05-21 18:05 Laxman Dewangan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).