linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@redhat.com>, David Ahern <dsahern@gmail.com>,
	Jiri Olsa <jolsa@redhat.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Stephane Eranian <eranian@google.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 0/5] perf report: Cleanup and refactor hist printing code
Date: Fri, 20 Jul 2012 00:42:33 +0900	[thread overview]
Message-ID: <1342712558-8185-1-git-send-email-namhyung@kernel.org> (raw)

Hi,

I'm working on improving perf report. Main goal is adding support for
event-grouping (viewer part) and callchain accumulation (aka sort inclusive).
I'm hoping that I can post an initial series by the end of next week.

But before that, I just want to cleanup the code somewhat since it's a pain
to look at it in the current form. So I added struct hist_period_print (or
a better name?), and let callers configure it dynamically for their needs.
I think this can make it easy to work with the code.

I know that it'll be conflict with Frederic recent changes. But it should be
trivial to resolve them upon this series (or the other way around).

Any comments are welcome.

Thanks,
Namhyung


Namhyung Kim (5):
  perf tools: Separate out hist print functions
  perf tools: Refactor some functions
  perf tools: Introduce hist_period_print functions
  perf ui/browser: Use hist_period_print functions
  perf gtk/browser: Use hist_period_print functions

 tools/perf/Makefile            |    4 +-
 tools/perf/ui/browsers/hists.c |  102 +++--
 tools/perf/ui/gtk/browser.c    |  103 ++++-
 tools/perf/ui/hist.c           |  820 ++++++++++++++++++++++++++++++++++++++++
 tools/perf/util/hist.c         |  685 +--------------------------------
 tools/perf/util/hist.h         |   41 +-
 6 files changed, 1045 insertions(+), 710 deletions(-)
 create mode 100644 tools/perf/ui/hist.c

-- 
1.7.9.2


             reply	other threads:[~2012-07-19 15:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-19 15:42 Namhyung Kim [this message]
2012-07-19 15:42 ` [PATCH 1/5] perf tools: Separate out hist print functions Namhyung Kim
2012-07-19 15:42 ` [PATCH 2/5] perf tools: Refactor some functions Namhyung Kim
2012-07-19 15:42 ` [PATCH 3/5] perf tools: Introduce hist_period_print functions Namhyung Kim
2012-07-19 15:42 ` [PATCH 4/5] perf ui/browser: Use " Namhyung Kim
2012-07-19 15:42 ` [PATCH 5/5] perf gtk/browser: " Namhyung Kim
2012-07-20 13:43   ` Pekka Enberg
2012-07-21  0:20     ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1342712558-8185-1-git-send-email-namhyung@kernel.org \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=dsahern@gmail.com \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).