linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Pekka Enberg <penberg@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@redhat.com>, David Ahern <dsahern@gmail.com>,
	Jiri Olsa <jolsa@redhat.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Stephane Eranian <eranian@google.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] perf gtk/browser: Use hist_period_print functions
Date: Sat, 21 Jul 2012 09:20:36 +0900	[thread overview]
Message-ID: <CAM9d7ci2W+kDCSpQkTdNHu2GUs6rp=VLjs9M9vCO4uAHsVCxzw@mail.gmail.com> (raw)
In-Reply-To: <CAOJsxLGFE8QSS06Wj+nhOS8XCpGoMH4bOqwvPi736uBrgJa3uQ@mail.gmail.com>

On Fri, Jul 20, 2012 at 10:43 PM, Pekka Enberg <penberg@kernel.org> wrote:
> On Thu, Jul 19, 2012 at 6:42 PM, Namhyung Kim <namhyung@kernel.org> wrote:
>> Now we can support color using pango markup with this change.
>>
>> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
>
> Can you please CC me on perf GTK patches?
>

Sorry, I'll do that in the future. :)


> [snip]
>
>> +#define HPP_COLOR_FN(_name, _field)                                            \
>
> Where does this "hpp" naming convention come from? What does it stand for?

It's the hist_period_print as the subject said, though I'm not happy
with the name.
I'm open to a better name suggestion.

Thanks,
Namhyung

      reply	other threads:[~2012-07-21  0:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-19 15:42 [PATCH 0/5] perf report: Cleanup and refactor hist printing code Namhyung Kim
2012-07-19 15:42 ` [PATCH 1/5] perf tools: Separate out hist print functions Namhyung Kim
2012-07-19 15:42 ` [PATCH 2/5] perf tools: Refactor some functions Namhyung Kim
2012-07-19 15:42 ` [PATCH 3/5] perf tools: Introduce hist_period_print functions Namhyung Kim
2012-07-19 15:42 ` [PATCH 4/5] perf ui/browser: Use " Namhyung Kim
2012-07-19 15:42 ` [PATCH 5/5] perf gtk/browser: " Namhyung Kim
2012-07-20 13:43   ` Pekka Enberg
2012-07-21  0:20     ` Namhyung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAM9d7ci2W+kDCSpQkTdNHu2GUs6rp=VLjs9M9vCO4uAHsVCxzw@mail.gmail.com' \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=dsahern@gmail.com \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).