From: Andy Walls <awalls@md.metrocast.net>
To: Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Avi Kivity <avi@redhat.com>,
kvm@vger.kernel.org, ivtv-devel@ivtvdriver.org,
linux-media@vger.kernel.org,
Grant Likely <grant.likely@secretlab.ca>,
spi-devel-general@lists.sourceforge.net,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 1/2] kthread_worker: reorganize to prepare for flush_kthread_work() reimplementation
Date: Sun, 22 Jul 2012 16:42:12 -0400 [thread overview]
Message-ID: <1342989735.2487.15.camel@palomino.walls.org> (raw)
In-Reply-To: <20120722164607.GB5144@dhcp-172-17-108-109.mtv.corp.google.com>
On Sun, 2012-07-22 at 09:46 -0700, Tejun Heo wrote:
> Hello,
>
> On Sat, Jul 21, 2012 at 01:13:27PM -0400, Andy Walls wrote:
> > > +/* insert @work before @pos in @worker */
> >
> > Hi Tejun,
> >
> > Would a comment that the caller should be holding worker->lock be useful
> > here? Anyway, comment or not:
> >
> > Acked-by: Andy Walls <awall@md.metrocast.net>
>
> Will add lockdep_assert_held(). Thanks!
>
Great! Thank you.
Regards,
Andy
next prev parent reply other threads:[~2012-07-22 20:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 21:15 [PATCHSET] kthread_worker: reimplement flush_kthread_work() to allow freeing during execution Tejun Heo
2012-07-19 21:15 ` [PATCH 1/2] kthread_worker: reorganize to prepare for flush_kthread_work() reimplementation Tejun Heo
2012-07-21 17:13 ` Andy Walls
2012-07-22 16:46 ` Tejun Heo
2012-07-22 20:42 ` Andy Walls [this message]
2012-07-22 17:22 ` [PATCH UPDATED " Tejun Heo
2012-07-19 21:16 ` [PATCH 2/2] kthread_worker: reimplement flush_kthread_work() to allow freeing the work item being executed Tejun Heo
2012-07-21 18:20 ` Andy Walls
2012-07-22 16:49 ` Tejun Heo
2012-07-22 20:46 ` Andy Walls
2012-07-23 17:12 ` Tejun Heo
2012-07-24 11:17 ` Andy Walls
2012-07-22 20:39 ` Andy Walls
2012-09-14 22:50 ` [PATCHSET] kthread_worker: reimplement flush_kthread_work() to allow freeing during execution Colin Cross
2012-09-17 19:40 ` Tejun Heo
2012-09-17 20:28 ` Greg KH
2012-09-28 0:19 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342989735.2487.15.camel@palomino.walls.org \
--to=awalls@md.metrocast.net \
--cc=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=grant.likely@secretlab.ca \
--cc=ivtv-devel@ivtvdriver.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).