From: Tejun Heo <tj@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Avi Kivity <avi@redhat.com>,
kvm@vger.kernel.org, Andy Walls <awalls@md.metrocast.net>,
ivtv-devel@ivtvdriver.org, linux-media@vger.kernel.org,
Grant Likely <grant.likely@secretlab.ca>,
spi-devel-general@lists.sourceforge.net,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: [PATCHSET] kthread_worker: reimplement flush_kthread_work() to allow freeing during execution
Date: Thu, 19 Jul 2012 14:15:10 -0700 [thread overview]
Message-ID: <20120719211510.GA32763@google.com> (raw)
Hello,
kthread_worker was introduced together with concurrency managed
workqueue to serve workqueue users which need a special dedicated
worker - e.g. RT scheduling. This is minimal queue / flush / flush
all iterface on top of kthread and each provided interface matches the
workqueue counterpart so that switching isn't difficult.
However, one noticeable difference was that kthread_worker doesn't
allow a work item to be freed while being executed. The intention was
to keep the code simpler but it didn't really and the restriction is
subtle and does prevent some valid use cases.
This two-patch series reimplements flush_kthread_work() so that it
uses an extra work item for flushing. While this takes a bit more
lines, this is easier to understand and removes the annoying
difference.
This patchset contains the following two patches.
0001-kthread_worker-reorganize-to-prepare-for-flush_kthre.patch
0002-kthread_worker-reimplement-flush_kthread_work-to-all.patch
The first one is a prep patch which makes no functional changes. The
second reimplements flush_kthread_work().
All current kthread_worker users are cc'd. If no one objects, I'll
push it through the workqueue branch. This patchset is also available
in the following git branch.
git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git review-kthread_worker-flush
diffstat follows. Thanks.
include/linux/kthread.h | 8 +---
kernel/kthread.c | 86 +++++++++++++++++++++++++++---------------------
2 files changed, 52 insertions(+), 42 deletions(-)
--
tejun
next reply other threads:[~2012-07-19 21:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 21:15 Tejun Heo [this message]
2012-07-19 21:15 ` [PATCH 1/2] kthread_worker: reorganize to prepare for flush_kthread_work() reimplementation Tejun Heo
2012-07-21 17:13 ` Andy Walls
2012-07-22 16:46 ` Tejun Heo
2012-07-22 20:42 ` Andy Walls
2012-07-22 17:22 ` [PATCH UPDATED " Tejun Heo
2012-07-19 21:16 ` [PATCH 2/2] kthread_worker: reimplement flush_kthread_work() to allow freeing the work item being executed Tejun Heo
2012-07-21 18:20 ` Andy Walls
2012-07-22 16:49 ` Tejun Heo
2012-07-22 20:46 ` Andy Walls
2012-07-23 17:12 ` Tejun Heo
2012-07-24 11:17 ` Andy Walls
2012-07-22 20:39 ` Andy Walls
2012-09-14 22:50 ` [PATCHSET] kthread_worker: reimplement flush_kthread_work() to allow freeing during execution Colin Cross
2012-09-17 19:40 ` Tejun Heo
2012-09-17 20:28 ` Greg KH
2012-09-28 0:19 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120719211510.GA32763@google.com \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=awalls@md.metrocast.net \
--cc=grant.likely@secretlab.ca \
--cc=ivtv-devel@ivtvdriver.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).