* [PATCH v2] ACPI processor: Fix a typo error in commit 99b725084
@ 2012-07-31 4:44 Feng Tang
2012-07-31 9:26 ` Rafael J. Wysocki
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Feng Tang @ 2012-07-31 4:44 UTC (permalink / raw)
To: len.brown, linux-acpi
Cc: linux-kernel, paulmck, Feng Tang, Thomas Renninger, Deepthi Dharwar
In commit 99b725084 "ACPI processor hotplug: Delay acpi_processor_start()
call for hotplugged cores", acpi_processor_hotplug(pr) was wrongly replaced
by acpi_processor_cst_has_changed() inside the acpi_cpu_soft_notify(). This
patch will restore it back, which also fixes a tick_broadcast_mask regression:
https://lkml.org/lkml/2012/7/30/169
[Resend to ACPI mail list and Cc stable kernel]
Signed-off-by: Feng Tang <feng.tang@intel.com>
Cc: Thomas Renninger <trenn@suse.de>
Cc: Deepthi Dharwar <deepthi@linux.vnet.ibm.com>
Cc: <stable@vger.kernel.org> # 3.3+
---
drivers/acpi/processor_driver.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/acpi/processor_driver.c b/drivers/acpi/processor_driver.c
index ff8e04f..bfc31cb 100644
--- a/drivers/acpi/processor_driver.c
+++ b/drivers/acpi/processor_driver.c
@@ -437,7 +437,7 @@ static int acpi_cpu_soft_notify(struct notifier_block *nfb,
/* Normal CPU soft online event */
} else {
acpi_processor_ppc_has_changed(pr, 0);
- acpi_processor_cst_has_changed(pr);
+ acpi_processor_hotplug(pr);
acpi_processor_reevaluate_tstate(pr, action);
acpi_processor_tstate_has_changed(pr);
}
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] ACPI processor: Fix a typo error in commit 99b725084
2012-07-31 4:44 [PATCH v2] ACPI processor: Fix a typo error in commit 99b725084 Feng Tang
@ 2012-07-31 9:26 ` Rafael J. Wysocki
2012-07-31 17:18 ` Deepthi Dharwar
2012-08-03 4:22 ` Len Brown
2 siblings, 0 replies; 7+ messages in thread
From: Rafael J. Wysocki @ 2012-07-31 9:26 UTC (permalink / raw)
To: Feng Tang
Cc: len.brown, linux-acpi, linux-kernel, paulmck, Thomas Renninger,
Deepthi Dharwar
On Tuesday, July 31, 2012, Feng Tang wrote:
> In commit 99b725084 "ACPI processor hotplug: Delay acpi_processor_start()
> call for hotplugged cores", acpi_processor_hotplug(pr) was wrongly replaced
> by acpi_processor_cst_has_changed() inside the acpi_cpu_soft_notify(). This
> patch will restore it back, which also fixes a tick_broadcast_mask regression:
> https://lkml.org/lkml/2012/7/30/169
>
> [Resend to ACPI mail list and Cc stable kernel]
>
> Signed-off-by: Feng Tang <feng.tang@intel.com>
> Cc: Thomas Renninger <trenn@suse.de>
> Cc: Deepthi Dharwar <deepthi@linux.vnet.ibm.com>
> Cc: <stable@vger.kernel.org> # 3.3+
Reviewed-by: Rafael J. Wysocki <rjw@sisk.pl>
> ---
> drivers/acpi/processor_driver.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/acpi/processor_driver.c b/drivers/acpi/processor_driver.c
> index ff8e04f..bfc31cb 100644
> --- a/drivers/acpi/processor_driver.c
> +++ b/drivers/acpi/processor_driver.c
> @@ -437,7 +437,7 @@ static int acpi_cpu_soft_notify(struct notifier_block *nfb,
> /* Normal CPU soft online event */
> } else {
> acpi_processor_ppc_has_changed(pr, 0);
> - acpi_processor_cst_has_changed(pr);
> + acpi_processor_hotplug(pr);
> acpi_processor_reevaluate_tstate(pr, action);
> acpi_processor_tstate_has_changed(pr);
> }
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] ACPI processor: Fix a typo error in commit 99b725084
2012-07-31 4:44 [PATCH v2] ACPI processor: Fix a typo error in commit 99b725084 Feng Tang
2012-07-31 9:26 ` Rafael J. Wysocki
@ 2012-07-31 17:18 ` Deepthi Dharwar
2012-08-03 4:22 ` Len Brown
2 siblings, 0 replies; 7+ messages in thread
From: Deepthi Dharwar @ 2012-07-31 17:18 UTC (permalink / raw)
To: Feng Tang; +Cc: len.brown, linux-acpi, linux-kernel, paulmck, Thomas Renninger
On 07/31/2012 10:14 AM, Feng Tang wrote:
> In commit 99b725084 "ACPI processor hotplug: Delay acpi_processor_start()
> call for hotplugged cores", acpi_processor_hotplug(pr) was wrongly replaced
> by acpi_processor_cst_has_changed() inside the acpi_cpu_soft_notify(). This
> patch will restore it back, which also fixes a tick_broadcast_mask regression:
> https://lkml.org/lkml/2012/7/30/169
Reviewed-by: Deepthi Dharwar <deepthi@linux.vnet.ibm.com>
> [Resend to ACPI mail list and Cc stable kernel]
>
> Signed-off-by: Feng Tang <feng.tang@intel.com>
> Cc: Thomas Renninger <trenn@suse.de>
> Cc: Deepthi Dharwar <deepthi@linux.vnet.ibm.com>
> Cc: <stable@vger.kernel.org> # 3.3+
> ---
> drivers/acpi/processor_driver.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/acpi/processor_driver.c b/drivers/acpi/processor_driver.c
> index ff8e04f..bfc31cb 100644
> --- a/drivers/acpi/processor_driver.c
> +++ b/drivers/acpi/processor_driver.c
> @@ -437,7 +437,7 @@ static int acpi_cpu_soft_notify(struct notifier_block *nfb,
> /* Normal CPU soft online event */
> } else {
> acpi_processor_ppc_has_changed(pr, 0);
> - acpi_processor_cst_has_changed(pr);
> + acpi_processor_hotplug(pr);
> acpi_processor_reevaluate_tstate(pr, action);
> acpi_processor_tstate_has_changed(pr);
> }
Cheers,
Deepthi
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] ACPI processor: Fix a typo error in commit 99b725084
2012-07-31 4:44 [PATCH v2] ACPI processor: Fix a typo error in commit 99b725084 Feng Tang
2012-07-31 9:26 ` Rafael J. Wysocki
2012-07-31 17:18 ` Deepthi Dharwar
@ 2012-08-03 4:22 ` Len Brown
2012-08-03 5:56 ` Srivatsa S. Bhat
2 siblings, 1 reply; 7+ messages in thread
From: Len Brown @ 2012-08-03 4:22 UTC (permalink / raw)
To: Feng Tang
Cc: linux-acpi, linux-kernel, paulmck, Thomas Renninger, Deepthi Dharwar
Applied.
thanks for the refresh.
Len Brown, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] ACPI processor: Fix a typo error in commit 99b725084
2012-08-03 4:22 ` Len Brown
@ 2012-08-03 5:56 ` Srivatsa S. Bhat
2012-08-03 6:03 ` Feng Tang
0 siblings, 1 reply; 7+ messages in thread
From: Srivatsa S. Bhat @ 2012-08-03 5:56 UTC (permalink / raw)
To: Len Brown
Cc: Feng Tang, linux-acpi, linux-kernel, paulmck, Thomas Renninger,
Deepthi Dharwar
On 08/03/2012 09:52 AM, Len Brown wrote:
> Applied.
>
> thanks for the refresh.
>
This patch needs to be CC'ed to stable also right?
Regards,
Srivatsa S. Bhat
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] ACPI processor: Fix a typo error in commit 99b725084
2012-08-03 5:56 ` Srivatsa S. Bhat
@ 2012-08-03 6:03 ` Feng Tang
2012-08-03 6:13 ` Srivatsa S. Bhat
0 siblings, 1 reply; 7+ messages in thread
From: Feng Tang @ 2012-08-03 6:03 UTC (permalink / raw)
To: Srivatsa S. Bhat
Cc: Len Brown, linux-acpi, linux-kernel, paulmck, Thomas Renninger,
Deepthi Dharwar, stable
On Fri, 3 Aug 2012 11:26:04 +0530
"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com> wrote:
> On 08/03/2012 09:52 AM, Len Brown wrote:
> > Applied.
> >
> > thanks for the refresh.
> >
>
> This patch needs to be CC'ed to stable also right?
Yes, I've sent the patch directly to stable 3 days ago. thanks
for the note.
- Feng
>
> Regards,
> Srivatsa S. Bhat
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] ACPI processor: Fix a typo error in commit 99b725084
2012-08-03 6:03 ` Feng Tang
@ 2012-08-03 6:13 ` Srivatsa S. Bhat
0 siblings, 0 replies; 7+ messages in thread
From: Srivatsa S. Bhat @ 2012-08-03 6:13 UTC (permalink / raw)
To: Feng Tang
Cc: Len Brown, linux-acpi, linux-kernel, paulmck, Thomas Renninger,
Deepthi Dharwar, stable
On 08/03/2012 11:33 AM, Feng Tang wrote:
> On Fri, 3 Aug 2012 11:26:04 +0530
> "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com> wrote:
>
>> On 08/03/2012 09:52 AM, Len Brown wrote:
>>> Applied.
>>>
>>> thanks for the refresh.
>>>
>>
>> This patch needs to be CC'ed to stable also right?
>
> Yes, I've sent the patch directly to stable 3 days ago. thanks
> for the note.
>
Hmm? Patches are not accepted into the stable tree until the patch
goes upstream, IIUC. And to make a patch automatically go to -stable
once it hits mainline, you need to add Cc: stable@vger.kernel.org
among the Signed-off-by sequence in the patch.
Otherwise, we can explicitly mail the patch to stable, -after- the
corresponding patch hits mainline.. In fact, we will also have to quote
the mainline commit id in that.
See Documentation/stable_kernel_rules.txt for details.
Regards,
Srivatsa S. Bhat
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-08-03 6:14 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-31 4:44 [PATCH v2] ACPI processor: Fix a typo error in commit 99b725084 Feng Tang
2012-07-31 9:26 ` Rafael J. Wysocki
2012-07-31 17:18 ` Deepthi Dharwar
2012-08-03 4:22 ` Len Brown
2012-08-03 5:56 ` Srivatsa S. Bhat
2012-08-03 6:03 ` Feng Tang
2012-08-03 6:13 ` Srivatsa S. Bhat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).