* [PATCH] nouveau: Do not use nva3 engine for 0xaf chipset
@ 2012-08-04 6:00 Henrik Rydberg
2012-08-05 2:50 ` [Nouveau] " Ben Skeggs
0 siblings, 1 reply; 2+ messages in thread
From: Henrik Rydberg @ 2012-08-04 6:00 UTC (permalink / raw)
To: Ben Skeggs; +Cc: Dave Airlie, nouveau, dri-devel, linux-kernel, Henrik Rydberg
The nva3 copy engine exhibits random memory corruption in at least one
case, the GeForce 320M (nv50, 0xaf) in the MacBookAir3,1. This patch
omits creating the engine for the specific chipset, falling back to
M2MF, which kills the symptoms.
Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
---
Hi Ben,
this patch is still needed in 3.6-rc1, so perhaps we should apply it
after all. I have been running it without problems for a long time
now.
Thanks,
Henrik
drivers/gpu/drm/nouveau/nouveau_state.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_state.c b/drivers/gpu/drm/nouveau/nouveau_state.c
index 1cdfd6e..1866dbb 100644
--- a/drivers/gpu/drm/nouveau/nouveau_state.c
+++ b/drivers/gpu/drm/nouveau/nouveau_state.c
@@ -731,7 +731,6 @@ nouveau_card_init(struct drm_device *dev)
case 0xa3:
case 0xa5:
case 0xa8:
- case 0xaf:
nva3_copy_create(dev);
break;
}
--
1.7.11.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Nouveau] [PATCH] nouveau: Do not use nva3 engine for 0xaf chipset
2012-08-04 6:00 [PATCH] nouveau: Do not use nva3 engine for 0xaf chipset Henrik Rydberg
@ 2012-08-05 2:50 ` Ben Skeggs
0 siblings, 0 replies; 2+ messages in thread
From: Ben Skeggs @ 2012-08-05 2:50 UTC (permalink / raw)
To: Henrik Rydberg; +Cc: Ben Skeggs, nouveau, linux-kernel, dri-devel
On Sat, Aug 04, 2012 at 08:00:45AM +0200, Henrik Rydberg wrote:
> The nva3 copy engine exhibits random memory corruption in at least one
> case, the GeForce 320M (nv50, 0xaf) in the MacBookAir3,1. This patch
> omits creating the engine for the specific chipset, falling back to
> M2MF, which kills the symptoms.
I've pushed this (with slightly modified commit message) to nouveau git.
I'll get it to Linus' tree in a future -fixes merge.
Thanks,
Ben.
>
> Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
> ---
> Hi Ben,
>
> this patch is still needed in 3.6-rc1, so perhaps we should apply it
> after all. I have been running it without problems for a long time
> now.
>
> Thanks,
> Henrik
>
> drivers/gpu/drm/nouveau/nouveau_state.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_state.c b/drivers/gpu/drm/nouveau/nouveau_state.c
> index 1cdfd6e..1866dbb 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_state.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_state.c
> @@ -731,7 +731,6 @@ nouveau_card_init(struct drm_device *dev)
> case 0xa3:
> case 0xa5:
> case 0xa8:
> - case 0xaf:
> nva3_copy_create(dev);
> break;
> }
> --
> 1.7.11.4
>
> _______________________________________________
> Nouveau mailing list
> Nouveau@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-05 2:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-04 6:00 [PATCH] nouveau: Do not use nva3 engine for 0xaf chipset Henrik Rydberg
2012-08-05 2:50 ` [Nouveau] " Ben Skeggs
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).