[PATCH 0/5] staging/csr: cleanup patches

[PATCH 0/5] staging/csr: cleanup patches

[Devendra Naga]

Hi Greg,

These patches does

* coding style fixes
* little cleanups like unneeded initialisations and 
  comparing a bool against 1 in if

each and every patch is compile tested on top of the previous one

Thanks,

----------------------------

Actually i have a question about the dbg macros, unifi_warning,
unifi_error, and unifi_trace,

I think these can be implemented using dev_warn, dev_dbg, functions,
i mean we can remove these unifi_warning and unifi_error and unifi_trace
and use the dev_warn and dev_dbg.

Please correct me if i am wrong

Devendra Naga (5):
  staging/csr: clean coding style in uf_start_thread
  staging/csr: fix coding style problems in uf_stop_thread
  staging/csr: fix coding style problems in uf_wait_for_thread_to_stop
  staging/csr: remove the initialisation of interfaceTag and its
    comment in handle_bh_error
  staging/csr: fix coding style problems in handle_bh_error

 drivers/staging/csr/bh.c |  173 ++++++++++++++++++++++++----------------------
 1 file changed, 90 insertions(+), 83 deletions(-)

Signed-off-by: Devendra Naga <develkernel412222@gmail.com>
-- 
1.7.9.5

Re: [PATCH 0/5] staging/csr: cleanup patches

[Greg Kroah-Hartman]

On Sat, Aug 04, 2012 at 01:00:08PM +0545, Devendra Naga wrote:
> Actually i have a question about the dbg macros, unifi_warning,
> unifi_error, and unifi_trace,
> 
> I think these can be implemented using dev_warn, dev_dbg, functions,
> i mean we can remove these unifi_warning and unifi_error and unifi_trace
> and use the dev_warn and dev_dbg.

Yes, we should use those instead.

thanks,

greg k-h