* [PATCH] TTY: synclink_cs, fix build
[not found] <20120814002304.GA5604@localhost>
@ 2012-08-14 8:23 ` Jiri Slaby
0 siblings, 0 replies; only message in thread
From: Jiri Slaby @ 2012-08-14 8:23 UTC (permalink / raw)
To: gregkh; +Cc: jirislaby, linux-kernel, Jiri Slaby
Commit "TTY: synclink_cs, use dynamic tty devices" added a call to
tty_port_register_device with a proper device as the last argument.
But it was not correct and it causes build failures:
synclink_cs.c: In function ‘mgslpc_add_device’:
synclink_cs.c:2735:16: error: request for member ‘dev’ in something not a structure or union
info->p_dev is a pointer, so act as that.
I wonder why my build scripts did not notice. I have to re-check them.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
---
drivers/char/pcmcia/synclink_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/pcmcia/synclink_cs.c b/drivers/char/pcmcia/synclink_cs.c
index 923c3a4..d9335ae 100644
--- a/drivers/char/pcmcia/synclink_cs.c
+++ b/drivers/char/pcmcia/synclink_cs.c
@@ -2732,7 +2732,7 @@ static void mgslpc_add_device(MGSLPC_INFO *info)
hdlcdev_init(info);
#endif
tty_port_register_device(&info->port, serial_driver, info->line,
- &info->p_dev.dev);
+ &info->p_dev->dev);
}
static void mgslpc_remove_device(MGSLPC_INFO *remove_info)
--
1.7.10.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-08-14 8:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20120814002304.GA5604@localhost>
2012-08-14 8:23 ` [PATCH] TTY: synclink_cs, fix build Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).