* [PATCH 1/1] Drivers: hv: Explicitly size elements of protocol structures
@ 2012-08-16 15:23 K. Y. Srinivasan
2012-08-16 19:35 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: K. Y. Srinivasan @ 2012-08-16 15:23 UTC (permalink / raw)
To: gregkh, linux-kernel, devel, virtualization, olaf, apw, jagrelo
Cc: K. Y. Srinivasan
Use explicitly sized types in data structures defining the host/guest
protocol. I would like to thank Juan Sanchez-Agrelo <jagrelo@cisco.com>
for reporting this.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
---
include/linux/hyperv.h | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index 588d8f2..e73b852 100644
--- a/include/linux/hyperv.h
+++ b/include/linux/hyperv.h
@@ -489,7 +489,7 @@ struct vmtransfer_page_range {
struct vmtransfer_page_packet_header {
struct vmpacket_descriptor d;
u16 xfer_pageset_id;
- bool sender_owns_set;
+ u8 sender_owns_set;
u8 reserved;
u32 range_cnt;
struct vmtransfer_page_range ranges[1];
@@ -643,7 +643,7 @@ struct vmbus_channel_query_vmbus_version {
/* VMBus Version Supported parameters */
struct vmbus_channel_version_supported {
struct vmbus_channel_message_header header;
- bool version_supported;
+ u8 version_supported;
} __packed;
/* Offer Channel parameters */
@@ -652,7 +652,7 @@ struct vmbus_channel_offer_channel {
struct vmbus_channel_offer offer;
u32 child_relid;
u8 monitorid;
- bool monitor_allocated;
+ u8 monitor_allocated;
} __packed;
/* Rescind Offer parameters */
@@ -788,7 +788,7 @@ struct vmbus_channel_initiate_contact {
struct vmbus_channel_version_response {
struct vmbus_channel_message_header header;
- bool version_supported;
+ u8 version_supported;
} __packed;
enum vmbus_channel_state {
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] Drivers: hv: Explicitly size elements of protocol structures
2012-08-16 15:23 [PATCH 1/1] Drivers: hv: Explicitly size elements of protocol structures K. Y. Srinivasan
@ 2012-08-16 19:35 ` Greg KH
2012-08-16 19:52 ` KY Srinivasan
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2012-08-16 19:35 UTC (permalink / raw)
To: K. Y. Srinivasan; +Cc: linux-kernel, devel, virtualization, olaf, apw, jagrelo
On Thu, Aug 16, 2012 at 08:23:20AM -0700, K. Y. Srinivasan wrote:
> Use explicitly sized types in data structures defining the host/guest
> protocol. I would like to thank Juan Sanchez-Agrelo <jagrelo@cisco.com>
> for reporting this.
>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
If someone reports a problem, mark it as:
Reported-by: Juan Sanchez-Agrelo <jagrelo@cisco.com>
in the signed-off-by: area of the patch.
Does this need to go into 3.6, and possibly older kernels? Or can it
wait for 3.7?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH 1/1] Drivers: hv: Explicitly size elements of protocol structures
2012-08-16 19:35 ` Greg KH
@ 2012-08-16 19:52 ` KY Srinivasan
0 siblings, 0 replies; 3+ messages in thread
From: KY Srinivasan @ 2012-08-16 19:52 UTC (permalink / raw)
To: Greg KH; +Cc: linux-kernel, devel, virtualization, olaf, apw, jagrelo
> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Thursday, August 16, 2012 3:36 PM
> To: KY Srinivasan
> Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org;
> virtualization@lists.osdl.org; olaf@aepfle.de; apw@canonical.com;
> jagrelo@cisco.com
> Subject: Re: [PATCH 1/1] Drivers: hv: Explicitly size elements of protocol
> structures
>
> On Thu, Aug 16, 2012 at 08:23:20AM -0700, K. Y. Srinivasan wrote:
> > Use explicitly sized types in data structures defining the host/guest
> > protocol. I would like to thank Juan Sanchez-Agrelo <jagrelo@cisco.com>
> > for reporting this.
> >
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
>
> If someone reports a problem, mark it as:
> Reported-by: Juan Sanchez-Agrelo <jagrelo@cisco.com>
> in the signed-off-by: area of the patch.
Will do.
>
> Does this need to go into 3.6, and possibly older kernels? Or can it
> wait for 3.7?
Given the "stable kernel rules", I don't think this needs to go into older kernels.
This can wait for 3.7.
Thanks,
K. Y
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-08-16 19:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-16 15:23 [PATCH 1/1] Drivers: hv: Explicitly size elements of protocol structures K. Y. Srinivasan
2012-08-16 19:35 ` Greg KH
2012-08-16 19:52 ` KY Srinivasan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).