From: Artem Bityutskiy <dedekind1@gmail.com>
To: Richard Genoud <richard.genoud@gmail.com>
Cc: linux-mtd@lists.infradead.org,
Shmulik Ladkani <shmulik.ladkani@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] UBI: add ioctl for max_beb_per1024
Date: Fri, 17 Aug 2012 11:28:39 +0300 [thread overview]
Message-ID: <1345192119.27859.28.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1345128723-13582-3-git-send-email-richard.genoud@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 404 bytes --]
On Thu, 2012-08-16 at 16:52 +0200, Richard Genoud wrote:
> mutex_lock(&ubi_devices_mutex);
> err = ubi_attach_mtd_dev(mtd, req.ubi_num, req.vid_hdr_offset,
> - MTD_UBI_DEFAULT_BEB_LIMIT);
> + req.max_beb_per1024);
Do not forget to explicitely validate 'req.max_beb_per1024' valuse in
'ubi_attach_mtd_dev()', as we do for other parameters.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-08-17 8:23 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 16:23 [PATCH 0/4] UBI: Use the whole NAND device to calculate max bad block number Richard Genoud
2012-07-10 16:23 ` [PATCH 1/4] mtd_is_partition: struct mtd_info should be const Richard Genoud
2012-08-15 14:02 ` Artem Bityutskiy
2012-07-10 16:23 ` [PATCH 2/4] MTD parts: introduce mtd_get_device_size() Richard Genoud
2012-07-10 16:23 ` [PATCH 3/4] UBI: use the whole MTD device size to get bad_peb_limit Richard Genoud
2012-07-18 6:50 ` Artem Bityutskiy
2012-07-18 8:30 ` Richard Genoud
2012-08-15 12:53 ` Artem Bityutskiy
2012-08-15 15:08 ` Artem Bityutskiy
2012-08-16 8:13 ` Richard Genoud
2012-08-16 12:00 ` Artem Bityutskiy
2012-08-16 8:25 ` Shmulik Ladkani
2012-08-16 10:35 ` Richard Genoud
2012-08-16 11:58 ` Artem Bityutskiy
2012-08-16 11:56 ` Artem Bityutskiy
2012-08-16 8:32 ` Shmulik Ladkani
2012-08-16 11:58 ` Artem Bityutskiy
2012-08-16 11:58 ` Richard Genoud
2012-07-10 16:23 ` [PATCH 4/4] UBI: replace MTD_UBI_BEB_LIMIT with user-space parameter Richard Genoud
2012-08-15 14:57 ` Artem Bityutskiy
2012-08-16 14:52 ` [PATCH 0/2] splitting "UBI: replace MTD_UBI_BEB_LIMIT with user-space parameter" Richard Genoud
2012-08-16 14:52 ` [PATCH 1/2] UBI: replace MTD_UBI_BEB_LIMIT with module parameter Richard Genoud
2012-08-17 8:22 ` Artem Bityutskiy
2012-08-17 10:27 ` Richard Genoud
2012-08-16 14:52 ` [PATCH 2/2] UBI: add ioctl for max_beb_per1024 Richard Genoud
2012-08-17 8:28 ` Artem Bityutskiy [this message]
2012-08-16 8:57 ` [PATCH 4/4] UBI: replace MTD_UBI_BEB_LIMIT with user-space parameter Shmulik Ladkani
2012-08-16 10:07 ` Richard Genoud
2012-08-16 10:42 ` Shmulik Ladkani
2012-08-16 13:33 ` Artem Bityutskiy
2012-08-19 7:09 ` Shmulik Ladkani
2012-08-19 19:04 ` Artem Bityutskiy
2012-08-20 6:55 ` Richard Genoud
2012-08-20 8:17 ` Artem Bityutskiy
2012-08-20 8:27 ` Richard Genoud
2012-08-16 13:28 ` Artem Bityutskiy
2012-08-16 13:50 ` Shmulik Ladkani
2012-08-16 14:30 ` Richard Genoud
2012-08-16 14:54 ` [PATCH] UBI: use a config value for default BEB limit Richard Genoud
2012-08-17 7:34 ` [PATCH 4/4] UBI: replace MTD_UBI_BEB_LIMIT with user-space parameter Artem Bityutskiy
2012-08-17 7:06 ` Artem Bityutskiy
2012-07-10 16:23 ` [PATCH] ubiattach: introduce max_beb_per1024 in UBI_IOCATT Richard Genoud
2012-08-17 9:37 ` Artem Bityutskiy
2012-08-16 13:10 ` [PATCH 1/2] UBI: use the whole MTD device size to get bad_peb_limit Artem Bityutskiy
2012-08-16 13:10 ` [PATCH 2/2] arm: sam9_l9260_defconfig: adjust UBI bad eraseblocks limit Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345192119.27859.28.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard.genoud@gmail.com \
--cc=shmulik.ladkani@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).