From: Richard Genoud <richard.genoud@gmail.com>
To: dedekind1@gmail.com
Cc: Shmulik Ladkani <shmulik.ladkani@gmail.com>,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] UBI: replace MTD_UBI_BEB_LIMIT with user-space parameter
Date: Mon, 20 Aug 2012 10:27:45 +0200 [thread overview]
Message-ID: <CACQ1gAgaZegaT5FZpSMJbBWxDSLnXjzHqypdXSq8hwU+aOLZcA@mail.gmail.com> (raw)
In-Reply-To: <1345450620.2848.12.camel@sauron.fi.intel.com>
2012/8/20 Artem Bityutskiy <dedekind1@gmail.com>:
> On Mon, 2012-08-20 at 08:55 +0200, Richard Genoud wrote:
>> Hi Artem,
>> 2012/8/19 Artem Bityutskiy <dedekind1@gmail.com>:
>> > Yeah, I wanted to make it 1..256 but forgot, will do now. 0..256 would
>> > need some more work to avoid division by 0.
>> Division by 0 is handled in the get_bad_peb_limit() function, I don't
>> see another dangerous place.
>
> if (mult_frac(limit, 1024, max_beb_per1024) < device_pebs)
>
> will divide by 0 if max_beb_per1024 is 0.
>
just a few lines before, you've got:
/*
* We don't want a division by 0, and having max_beb_per1024 == 0 is ok
*/
if (!max_beb_per1024)
return 0;
from commit abae1f1
(or I'm not looking at the right line ?)
>> (and if we want to be coherent with user-space, it should be 0..255,
>> as the range is coded with an u8)
>
> I think it should be uint16_t instead, because we are defining ABI here
> and we should not assume no one will ever nee values higher than 255.
I agree with you, even if 25% of reserved space for bad block seems
insane, we never know...
I'll update that.
--
for me, ck means con kolivas and not calvin klein... does it mean I'm a geek ?
next prev parent reply other threads:[~2012-08-20 8:28 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 16:23 [PATCH 0/4] UBI: Use the whole NAND device to calculate max bad block number Richard Genoud
2012-07-10 16:23 ` [PATCH 1/4] mtd_is_partition: struct mtd_info should be const Richard Genoud
2012-08-15 14:02 ` Artem Bityutskiy
2012-07-10 16:23 ` [PATCH 2/4] MTD parts: introduce mtd_get_device_size() Richard Genoud
2012-07-10 16:23 ` [PATCH 3/4] UBI: use the whole MTD device size to get bad_peb_limit Richard Genoud
2012-07-18 6:50 ` Artem Bityutskiy
2012-07-18 8:30 ` Richard Genoud
2012-08-15 12:53 ` Artem Bityutskiy
2012-08-15 15:08 ` Artem Bityutskiy
2012-08-16 8:13 ` Richard Genoud
2012-08-16 12:00 ` Artem Bityutskiy
2012-08-16 8:25 ` Shmulik Ladkani
2012-08-16 10:35 ` Richard Genoud
2012-08-16 11:58 ` Artem Bityutskiy
2012-08-16 11:56 ` Artem Bityutskiy
2012-08-16 8:32 ` Shmulik Ladkani
2012-08-16 11:58 ` Artem Bityutskiy
2012-08-16 11:58 ` Richard Genoud
2012-07-10 16:23 ` [PATCH 4/4] UBI: replace MTD_UBI_BEB_LIMIT with user-space parameter Richard Genoud
2012-08-15 14:57 ` Artem Bityutskiy
2012-08-16 14:52 ` [PATCH 0/2] splitting "UBI: replace MTD_UBI_BEB_LIMIT with user-space parameter" Richard Genoud
2012-08-16 14:52 ` [PATCH 1/2] UBI: replace MTD_UBI_BEB_LIMIT with module parameter Richard Genoud
2012-08-17 8:22 ` Artem Bityutskiy
2012-08-17 10:27 ` Richard Genoud
2012-08-16 14:52 ` [PATCH 2/2] UBI: add ioctl for max_beb_per1024 Richard Genoud
2012-08-17 8:28 ` Artem Bityutskiy
2012-08-16 8:57 ` [PATCH 4/4] UBI: replace MTD_UBI_BEB_LIMIT with user-space parameter Shmulik Ladkani
2012-08-16 10:07 ` Richard Genoud
2012-08-16 10:42 ` Shmulik Ladkani
2012-08-16 13:33 ` Artem Bityutskiy
2012-08-19 7:09 ` Shmulik Ladkani
2012-08-19 19:04 ` Artem Bityutskiy
2012-08-20 6:55 ` Richard Genoud
2012-08-20 8:17 ` Artem Bityutskiy
2012-08-20 8:27 ` Richard Genoud [this message]
2012-08-16 13:28 ` Artem Bityutskiy
2012-08-16 13:50 ` Shmulik Ladkani
2012-08-16 14:30 ` Richard Genoud
2012-08-16 14:54 ` [PATCH] UBI: use a config value for default BEB limit Richard Genoud
2012-08-17 7:34 ` [PATCH 4/4] UBI: replace MTD_UBI_BEB_LIMIT with user-space parameter Artem Bityutskiy
2012-08-17 7:06 ` Artem Bityutskiy
2012-07-10 16:23 ` [PATCH] ubiattach: introduce max_beb_per1024 in UBI_IOCATT Richard Genoud
2012-08-17 9:37 ` Artem Bityutskiy
2012-08-16 13:10 ` [PATCH 1/2] UBI: use the whole MTD device size to get bad_peb_limit Artem Bityutskiy
2012-08-16 13:10 ` [PATCH 2/2] arm: sam9_l9260_defconfig: adjust UBI bad eraseblocks limit Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACQ1gAgaZegaT5FZpSMJbBWxDSLnXjzHqypdXSq8hwU+aOLZcA@mail.gmail.com \
--to=richard.genoud@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=shmulik.ladkani@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).