From: Arnd Bergmann <arnd@arndb.de>
To: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Magnus Damm <damm@opensource.se>,
Linus Walleij <linus.walleij@linaro.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH 3/4] ARM: export set_irq_flags/irq_set_chip_and_handler
Date: Wed, 22 Aug 2012 16:29:39 +0200 [thread overview]
Message-ID: <1345645780-2749-4-git-send-email-arnd@arndb.de> (raw)
In-Reply-To: <1345645780-2749-1-git-send-email-arnd@arndb.de>
The recently added Emma Mobile GPIO driver calls set_irq_flags
and irq_set_chip_and_handler for the interrupts it exports and
it can be built as a module, which currently fails with
ERROR: "set_irq_flags" [drivers/gpio/gpio-em.ko] undefined!
ERROR: "irq_set_chip_and_handler_name" [drivers/gpio/gpio-em.ko] undefined!
We either need to replace the call to set_irq_flags with something
else or export that function. This patch does the latter.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Magnus Damm <damm@opensource.se>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Rafael J. Wysocki <rjw@sisk.pl>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>
---
arch/arm/kernel/irq.c | 2 ++
kernel/irq/chip.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/arch/arm/kernel/irq.c b/arch/arm/kernel/irq.c
index 16cedb4..8961650 100644
--- a/arch/arm/kernel/irq.c
+++ b/arch/arm/kernel/irq.c
@@ -34,6 +34,7 @@
#include <linux/list.h>
#include <linux/kallsyms.h>
#include <linux/proc_fs.h>
+#include <linux/export.h>
#include <asm/exception.h>
#include <asm/mach/arch.h>
@@ -109,6 +110,7 @@ void set_irq_flags(unsigned int irq, unsigned int iflags)
/* Order is clear bits in "clr" then set bits in "set" */
irq_modify_status(irq, clr, set & ~clr);
}
+EXPORT_SYMBOL_GPL(set_irq_flags);
void __init init_IRQ(void)
{
diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index eebd6d5..3c3cea3 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -13,6 +13,7 @@
#include <linux/irq.h>
#include <linux/msi.h>
#include <linux/module.h>
+#include <linux/export.h>
#include <linux/interrupt.h>
#include <linux/kernel_stat.h>
@@ -671,6 +672,7 @@ irq_set_chip_and_handler_name(unsigned int irq, struct irq_chip *chip,
irq_set_chip(irq, chip);
__irq_set_handler(irq, handle, 0, name);
}
+EXPORT_SYMBOL_GPL(irq_set_chip_and_handler_name);
void irq_modify_status(unsigned int irq, unsigned long clr, unsigned long set)
{
--
1.7.10
next prev parent reply other threads:[~2012-08-22 14:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 14:29 [PATCH 0/4] ARM: patches for randconfig build errors Arnd Bergmann
2012-08-22 14:29 ` [PATCH 1/4] ARM: export read_current_timer Arnd Bergmann
2012-08-22 17:15 ` Stephen Boyd
2012-08-22 17:49 ` Will Deacon
2012-08-22 17:57 ` Stephen Boyd
2012-08-22 17:58 ` Will Deacon
2012-08-23 4:23 ` Shinya Kuribayashi
2012-08-23 3:56 ` Shinya Kuribayashi
2012-08-22 14:29 ` [PATCH 2/4] ARM: allow PID_IN_CONTEXTIDR only for ARMv7 Arnd Bergmann
2012-08-22 14:39 ` Will Deacon
2012-08-22 14:44 ` Arnd Bergmann
2012-08-22 14:29 ` Arnd Bergmann [this message]
2012-08-22 14:29 ` [PATCH 4/4] ARM: kprobes: make more tests conditional Arnd Bergmann
2012-08-22 14:42 ` Nicolas Pitre
2012-08-22 15:19 ` Arnd Bergmann
2012-08-22 15:38 ` Nicolas Pitre
2012-08-22 18:41 ` [PATCHv3 " Arnd Bergmann
2012-08-22 19:43 ` Nicolas Pitre
2012-08-22 23:51 ` Tixy
2012-08-23 12:09 ` [PATCHv4 " Arnd Bergmann
2012-08-23 17:28 ` Tixy
2012-08-23 18:04 ` Nicolas Pitre
2012-08-23 12:25 ` [PATCHv3 " Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345645780-2749-4-git-send-email-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=damm@opensource.se \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).