From: Will Deacon <will.deacon@arm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] ARM: allow PID_IN_CONTEXTIDR only for ARMv7
Date: Wed, 22 Aug 2012 15:39:46 +0100 [thread overview]
Message-ID: <20120822143946.GM9093@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <1345645780-2749-3-git-send-email-arnd@arndb.de>
Hi Arnd,
On Wed, Aug 22, 2012 at 03:29:38PM +0100, Arnd Bergmann wrote:
> When ARMv6 is enabled, we build the kernel with -march=armv6 or
> -march=armv6k, which means the bfi instruction is not available.
> Instead, it only works with -march=armv6t2 or -march=armv7-a.
>
> Without this patch, building rand-enIHAOL results in:
>
> /tmp/ccwCsCXC.s: Assembler messages:
> /tmp/ccwCsCXC.s:49: Error: selected processor does not support ARM mode `bfi r3,r2,#0,#8'
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
> arch/arm/Kconfig.debug | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index f15f82b..11b9ff4 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -398,6 +398,7 @@ config ARM_KPROBES_TEST
> config PID_IN_CONTEXTIDR
> bool "Write the current PID to the CONTEXTIDR register"
> depends on CPU_COPY_V6
> + depends on CPU_V7 && !CPU_V6
> help
> Enabling this option causes the kernel to write the current PID to
> the PROCID field of the CONTEXTIDR register, at the expense of some
Nah, I'll fix the contextidr_notifier instead. I forgot that this stuff gets
used on non-SMP v6 platforms.
Cheers,
Will
next prev parent reply other threads:[~2012-08-22 14:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 14:29 [PATCH 0/4] ARM: patches for randconfig build errors Arnd Bergmann
2012-08-22 14:29 ` [PATCH 1/4] ARM: export read_current_timer Arnd Bergmann
2012-08-22 17:15 ` Stephen Boyd
2012-08-22 17:49 ` Will Deacon
2012-08-22 17:57 ` Stephen Boyd
2012-08-22 17:58 ` Will Deacon
2012-08-23 4:23 ` Shinya Kuribayashi
2012-08-23 3:56 ` Shinya Kuribayashi
2012-08-22 14:29 ` [PATCH 2/4] ARM: allow PID_IN_CONTEXTIDR only for ARMv7 Arnd Bergmann
2012-08-22 14:39 ` Will Deacon [this message]
2012-08-22 14:44 ` Arnd Bergmann
2012-08-22 14:29 ` [PATCH 3/4] ARM: export set_irq_flags/irq_set_chip_and_handler Arnd Bergmann
2012-08-22 14:29 ` [PATCH 4/4] ARM: kprobes: make more tests conditional Arnd Bergmann
2012-08-22 14:42 ` Nicolas Pitre
2012-08-22 15:19 ` Arnd Bergmann
2012-08-22 15:38 ` Nicolas Pitre
2012-08-22 18:41 ` [PATCHv3 " Arnd Bergmann
2012-08-22 19:43 ` Nicolas Pitre
2012-08-22 23:51 ` Tixy
2012-08-23 12:09 ` [PATCHv4 " Arnd Bergmann
2012-08-23 17:28 ` Tixy
2012-08-23 18:04 ` Nicolas Pitre
2012-08-23 12:25 ` [PATCHv3 " Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120822143946.GM9093@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).