linux-next: build failure after merge of the ubi tree

linux-next: build failure after merge of the ubi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

Hi Artem,

After merging the ubi tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/mtd/ubi/build.c: In function 'io_init':
drivers/mtd/ubi/build.c:658:3: error: 'mtd' undeclared (first use in this function)

Caused by commit 8eb71060a0a5 ("UBI: disallow max_beb_per1024 on NOR flash").

I have used the ubi tree from next-20120823 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the ubi tree

[Artem Bityutskiy]

[-- Attachment #1: Type: text/plain, Size: 408 bytes --]

On Fri, 2012-08-24 at 11:34 +1000, Stephen Rothwell wrote:
> Hi Artem,
> 
> After merging the ubi tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/mtd/ubi/build.c: In function 'io_init':
> drivers/mtd/ubi/build.c:658:3: error: 'mtd' undeclared (first use in this function)

Thanks Stephen, fixed, sorry for the breakage.

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the ubi tree

[Richard Weinberger]

Artem, Stephen,

Am Wed, 03 Oct 2012 10:20:43 +0300
schrieb Artem Bityutskiy <dedekind1@gmail.com>:

> On Wed, 2012-10-03 at 12:27 +1000, Stephen Rothwell wrote:
> > Hi Artem,
> > 
> > After merging the ubi tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > ERROR: "ubi_update_fastmap" [drivers/mtd/ubi/ubi.ko] undefined!
> > ERROR: "ubi_scan_fastmap" [drivers/mtd/ubi/ubi.ko] undefined!
> > ERROR: "ubi_calc_fm_size" [drivers/mtd/ubi/ubi.ko] undefined!
> 
> I've added Richard's fastmap work there. I'll look at these failures.

Thanks for reporting this.
I'm not sure why this happens with allmodconfig.
If I set CONFIG_MTD=m and CONFIG_MTD_UBI=m it builds fine,
that's how I did most build tests.

The following patch fixes the issue for me.
Artem, are you fine with it?

Thanks,
//richard

---
diff --git a/drivers/mtd/ubi/Makefile b/drivers/mtd/ubi/Makefile
index 7ab19ac..b46b0c97 100644
--- a/drivers/mtd/ubi/Makefile
+++ b/drivers/mtd/ubi/Makefile
@@ -2,6 +2,6 @@ obj-$(CONFIG_MTD_UBI) += ubi.o
 
 ubi-y += vtbl.o vmt.o upd.o build.o cdev.o kapi.o eba.o io.o wl.o
attach.o ubi-y += misc.o debug.o
+ubi-$(CONFIG_MTD_UBI_FASTMAP) += fastmap.o
 
 obj-$(CONFIG_MTD_UBI_GLUEBI) += gluebi.o
-obj-$(CONFIG_MTD_UBI_FASTMAP) += fastmap.o

Re: linux-next: build failure after merge of the ubi tree

[Artem Bityutskiy]

[-- Attachment #1: Type: text/plain, Size: 558 bytes --]

On Wed, 2012-10-03 at 12:27 +1000, Stephen Rothwell wrote:
> Hi Artem,
> 
> After merging the ubi tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> ERROR: "ubi_update_fastmap" [drivers/mtd/ubi/ubi.ko] undefined!
> ERROR: "ubi_scan_fastmap" [drivers/mtd/ubi/ubi.ko] undefined!
> ERROR: "ubi_calc_fm_size" [drivers/mtd/ubi/ubi.ko] undefined!

I've added Richard's fastmap work there. I'll look at these failures.

And yes, using the previous ubi tree is a good decision, thanks!

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the ubi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 431 bytes --]

Hi Artem,

After merging the ubi tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: "ubi_update_fastmap" [drivers/mtd/ubi/ubi.ko] undefined!
ERROR: "ubi_scan_fastmap" [drivers/mtd/ubi/ubi.ko] undefined!
ERROR: "ubi_calc_fm_size" [drivers/mtd/ubi/ubi.ko] undefined!

I have used the ubi tree form next-20121002 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]