[PATCH 2/2] fat : no need to reset EOF in ent_put for FAT32

[PATCH 2/2] fat : no need to reset EOF in ent_put for FAT32

[Namjae Jeon]

#define FAT_ENT_EOF(EOF_FAT32)

there is no need to reset value of 'new' for FAT32 as the values is
already correct

Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
Signed-off-by: Amit Sahrawat <amit.sahrawat83@gmail.com>
---
 fs/fat/fatent.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/fat/fatent.c b/fs/fat/fatent.c
index 31f08ab..af53815 100644
--- a/fs/fat/fatent.c
+++ b/fs/fat/fatent.c
@@ -186,8 +186,6 @@ static void fat16_ent_put(struct fat_entry *fatent, int new)
 
 static void fat32_ent_put(struct fat_entry *fatent, int new)
 {
-	if (new == FAT_ENT_EOF)
-		new = EOF_FAT32;
 
 	WARN_ON(new & 0xf0000000);
 	new |= le32_to_cpu(*fatent->u.ent32_p) & ~0x0fffffff;
-- 
1.7.9.5

Re: [PATCH 2/2] fat : no need to reset EOF in ent_put for FAT32

[OGAWA Hirofumi]

Namjae Jeon <linkinjeon@gmail.com> writes:

> #define FAT_ENT_EOF(EOF_FAT32)
>
> there is no need to reset value of 'new' for FAT32 as the values is
> already correct
>
> Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
> Signed-off-by: Amit Sahrawat <amit.sahrawat83@gmail.com>
> ---
>  fs/fat/fatent.c |    2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/fs/fat/fatent.c b/fs/fat/fatent.c
> index 31f08ab..af53815 100644
> --- a/fs/fat/fatent.c
> +++ b/fs/fat/fatent.c
> @@ -186,8 +186,6 @@ static void fat16_ent_put(struct fat_entry *fatent, int new)
>  
>  static void fat32_ent_put(struct fat_entry *fatent, int new)
>  {
> -	if (new == FAT_ENT_EOF)
> -		new = EOF_FAT32;
>  

Please remove this new line too. If it was removed,

Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

>  	WARN_ON(new & 0xf0000000);
>  	new |= le32_to_cpu(*fatent->u.ent32_p) & ~0x0fffffff;

-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

Re: [PATCH 2/2] fat : no need to reset EOF in ent_put for FAT32

[Namjae Jeon]

2012/8/26, OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>:
> Namjae Jeon <linkinjeon@gmail.com> writes:
>
>> #define FAT_ENT_EOF(EOF_FAT32)
>>
>> there is no need to reset value of 'new' for FAT32 as the values is
>> already correct
>>
>> Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
>> Signed-off-by: Amit Sahrawat <amit.sahrawat83@gmail.com>
>> ---
>>  fs/fat/fatent.c |    2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/fs/fat/fatent.c b/fs/fat/fatent.c
>> index 31f08ab..af53815 100644
>> --- a/fs/fat/fatent.c
>> +++ b/fs/fat/fatent.c
>> @@ -186,8 +186,6 @@ static void fat16_ent_put(struct fat_entry *fatent,
>> int new)
>>
>>  static void fat32_ent_put(struct fat_entry *fatent, int new)
>>  {
>> -	if (new == FAT_ENT_EOF)
>> -		new = EOF_FAT32;
Hi OGAWA..
Okay, I will resend v2 patch after removing line.
Thanks.
>>
>
> Please remove this new line too. If it was removed,
>
> Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
>
>>  	WARN_ON(new & 0xf0000000);
>>  	new |= le32_to_cpu(*fatent->u.ent32_p) & ~0x0fffffff;
>
> --
> OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
>