From: Huang Shijie <shijie8@gmail.com>
To: dwmw2@infradead.org
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
dedekind1@gmail.com, shmulik.ladkani@gmail.com,
Huang Shijie <shijie8@gmail.com>
Subject: [PATCH 1/3] mtd: cmdlinepart: make the partitions rule more strict
Date: Sun, 26 Aug 2012 13:21:38 -0400 [thread overview]
Message-ID: <1346001700-26895-1-git-send-email-shijie8@gmail.com> (raw)
There are typically two types to set the mtd partitions:
<1> set with the `size`, such as
gpmi-nand:100m(boot),100m(kernel),1g(rootfs)
<2> set with the `offset`, such as
gpmi-nand:100m@0(boot),100m@100m(kernel),1g@200m(rootfs)
gpmi-nand:1g@200m(rootfs),100m@0(boot),100m@100m(kernel)
If we mix these two types, such as:
gpmi-nand:100m@0(boot),100m(kernel),1g@200m(rootfs)
gpmi-nand:1g@200m(rootfs),100m@0(boot),100m(kernel)
It's hard to understand the cmdline. And also it is hard to sort the
partitions in this mixed type. So we explicitly forbid the mixed type.
Signed-off-by: Huang Shijie <shijie8@gmail.com>
---
drivers/mtd/cmdlinepart.c | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/mtd/cmdlinepart.c b/drivers/mtd/cmdlinepart.c
index fe7e3a5..0b7b2ad 100644
--- a/drivers/mtd/cmdlinepart.c
+++ b/drivers/mtd/cmdlinepart.c
@@ -35,6 +35,15 @@
*
* 1 NOR Flash with 2 partitions, 1 NAND with one
* edb7312-nor:256k(ARMboot)ro,-(root);edb7312-nand:-(home)
+ *
+ * Note:
+ * If you choose to set the @offset for the <partdef>, please set all
+ * the partitions with the same syntax, such as:
+ * gpmi-nand:100m@0(boot),100m@100m(kernel),1g@200m(rootfs)
+ *
+ * Please do _NOT_ set the partitions like this:
+ * gpmi-nand:100m@0(boot),100m(kernel),1g@200m(rootfs)
+ * The `kernel` partition does not set with the @offset, this is not permitted.
*/
#include <linux/kernel.h>
--
1.7.4.4
next reply other threads:[~2012-08-26 5:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-26 17:21 Huang Shijie [this message]
2012-08-26 17:21 ` [PATCH 2/3] mtd: cmdlinepart: sort the unsorted partitions Huang Shijie
2012-08-31 13:59 ` Artem Bityutskiy
2012-08-31 14:29 ` Huang Shijie
2012-09-03 7:21 ` Artem Bityutskiy
2012-08-26 17:21 ` [PATCH 3/3] mtd: cmdlinepart: fix the wrong partitions number when truncating occurs Huang Shijie
2012-08-30 6:43 ` Artem Bityutskiy
2012-08-30 6:39 ` Huang Shijie
2012-08-31 11:45 ` [PATCH 1/3] mtd: cmdlinepart: make the partitions rule more strict Artem Bityutskiy
2012-08-31 13:36 ` Huang Shijie
2012-08-31 14:30 ` Huang Shijie
2012-09-03 7:18 ` Artem Bityutskiy
2012-09-03 15:09 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346001700-26895-1-git-send-email-shijie8@gmail.com \
--to=shijie8@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=shmulik.ladkani@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).