* [PATCH] media: v4l2-ctrls: add control for dpcm predictor
@ 2012-08-29 12:31 Prabhakar Lad
2012-08-29 12:43 ` Sylwester Nawrocki
2012-08-29 14:21 ` Sakari Ailus
0 siblings, 2 replies; 5+ messages in thread
From: Prabhakar Lad @ 2012-08-29 12:31 UTC (permalink / raw)
To: LMML
Cc: dlos, linux-kernel, Manjunath Hadli, Lad, Prabhakar,
Sakari Ailus, Hans Verkuil, Laurent Pinchart,
Mauro Carvalho Chehab, Sylwester Nawrocki, Hans de Goede,
Kyungmin Park
From: Lad, Prabhakar <prabhakar.lad@ti.com>
add V4L2_CID_DPCM_PREDICTOR control of type menu, which
determines the dpcm predictor. The predictor can be either
simple or advanced.
Signed-off-by: Lad, Prabhakar <prabhakar.lad@ti.com>
Signed-off-by: Manjunath Hadli <manjunath.hadli@ti.com>
Cc: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Hans Verkuil <hans.verkuil@cisco.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
---
This patches has one checkpatch warning for line over
80 characters altough it can be avoided I have kept it
for consistency.
drivers/media/v4l2-core/v4l2-ctrls.c | 9 +++++++++
include/linux/videodev2.h | 5 +++++
2 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c
index b6a2ee7..2d7bc15 100644
--- a/drivers/media/v4l2-core/v4l2-ctrls.c
+++ b/drivers/media/v4l2-core/v4l2-ctrls.c
@@ -425,6 +425,11 @@ const char * const *v4l2_ctrl_get_menu(u32 id)
"Gray",
NULL,
};
+ static const char * const dpcm_predictor[] = {
+ "Simple Predictor",
+ "Advanced Predictor",
+ NULL,
+ };
switch (id) {
case V4L2_CID_MPEG_AUDIO_SAMPLING_FREQ:
@@ -502,6 +507,8 @@ const char * const *v4l2_ctrl_get_menu(u32 id)
return mpeg4_profile;
case V4L2_CID_JPEG_CHROMA_SUBSAMPLING:
return jpeg_chroma_subsampling;
+ case V4L2_CID_DPCM_PREDICTOR:
+ return dpcm_predictor;
default:
return NULL;
@@ -732,6 +739,7 @@ const char *v4l2_ctrl_get_name(u32 id)
case V4L2_CID_IMAGE_PROC_CLASS: return "Image Processing Controls";
case V4L2_CID_LINK_FREQ: return "Link Frequency";
case V4L2_CID_PIXEL_RATE: return "Pixel Rate";
+ case V4L2_CID_DPCM_PREDICTOR: return "DPCM Predictor";
default:
return NULL;
@@ -832,6 +840,7 @@ void v4l2_ctrl_fill(u32 id, const char **name, enum v4l2_ctrl_type *type,
case V4L2_CID_ISO_SENSITIVITY_AUTO:
case V4L2_CID_EXPOSURE_METERING:
case V4L2_CID_SCENE_MODE:
+ case V4L2_CID_DPCM_PREDICTOR:
*type = V4L2_CTRL_TYPE_MENU;
break;
case V4L2_CID_LINK_FREQ:
diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
index 6d6dfa7..4edb941 100644
--- a/include/linux/videodev2.h
+++ b/include/linux/videodev2.h
@@ -2000,6 +2000,11 @@ enum v4l2_jpeg_chroma_subsampling {
#define V4L2_CID_LINK_FREQ (V4L2_CID_IMAGE_PROC_CLASS_BASE + 1)
#define V4L2_CID_PIXEL_RATE (V4L2_CID_IMAGE_PROC_CLASS_BASE + 2)
+#define V4L2_CID_DPCM_PREDICTOR (V4L2_CID_IMAGE_PROC_CLASS_BASE + 3)
+enum v4l2_dpcm_predictor {
+ V4L2_DPCM_PREDICTOR_SIMPLE = 0,
+ V4L2_DPCM_PREDICTOR_ADVANCE = 1,
+};
/*
* T U N I N G
--
1.7.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] media: v4l2-ctrls: add control for dpcm predictor
2012-08-29 12:31 [PATCH] media: v4l2-ctrls: add control for dpcm predictor Prabhakar Lad
@ 2012-08-29 12:43 ` Sylwester Nawrocki
2012-08-29 12:57 ` Prabhakar Lad
2012-08-29 14:21 ` Sakari Ailus
1 sibling, 1 reply; 5+ messages in thread
From: Sylwester Nawrocki @ 2012-08-29 12:43 UTC (permalink / raw)
To: Prabhakar Lad
Cc: LMML, dlos, linux-kernel, Manjunath Hadli, Sakari Ailus,
Hans Verkuil, Laurent Pinchart, Mauro Carvalho Chehab,
Hans de Goede, Kyungmin Park
Hi Prabhakar,
On 08/29/2012 02:31 PM, Prabhakar Lad wrote:
> From: Lad, Prabhakar <prabhakar.lad@ti.com>
>
> add V4L2_CID_DPCM_PREDICTOR control of type menu, which
> determines the dpcm predictor. The predictor can be either
> simple or advanced.
Thanks for the patch. I was expecting to find some information about
this new control in its DocBook documentation, but this part seems
to be missing here. :) Could you please add relevant entries in
Documentation/DocBook/media/v4l/controls.xml as well ?
--
Regards,
Sylwester
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] media: v4l2-ctrls: add control for dpcm predictor
2012-08-29 12:43 ` Sylwester Nawrocki
@ 2012-08-29 12:57 ` Prabhakar Lad
0 siblings, 0 replies; 5+ messages in thread
From: Prabhakar Lad @ 2012-08-29 12:57 UTC (permalink / raw)
To: Sylwester Nawrocki
Cc: LMML, dlos, linux-kernel, Manjunath Hadli, Sakari Ailus,
Hans Verkuil, Laurent Pinchart, Mauro Carvalho Chehab,
Hans de Goede, Kyungmin Park
Hi Sylwester,
On Wednesday 29 August 2012 06:13 PM, Sylwester Nawrocki wrote:
> Hi Prabhakar,
>
> On 08/29/2012 02:31 PM, Prabhakar Lad wrote:
>> From: Lad, Prabhakar <prabhakar.lad@ti.com>
>>
>> add V4L2_CID_DPCM_PREDICTOR control of type menu, which
>> determines the dpcm predictor. The predictor can be either
>> simple or advanced.
>
> Thanks for the patch. I was expecting to find some information about
> this new control in its DocBook documentation, but this part seems
> to be missing here. :) Could you please add relevant entries in
> Documentation/DocBook/media/v4l/controls.xml as well ?
>
Thanks for the catch :) I'll add it for v2.
Thanks and Regards,
--Prabhakar
> --
>
> Regards,
> Sylwester
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] media: v4l2-ctrls: add control for dpcm predictor
2012-08-29 12:31 [PATCH] media: v4l2-ctrls: add control for dpcm predictor Prabhakar Lad
2012-08-29 12:43 ` Sylwester Nawrocki
@ 2012-08-29 14:21 ` Sakari Ailus
2012-08-29 14:51 ` Prabhakar Lad
1 sibling, 1 reply; 5+ messages in thread
From: Sakari Ailus @ 2012-08-29 14:21 UTC (permalink / raw)
To: Prabhakar Lad
Cc: LMML, dlos, linux-kernel, Manjunath Hadli, Hans Verkuil,
Laurent Pinchart, Mauro Carvalho Chehab, Sylwester Nawrocki,
Hans de Goede, Kyungmin Park
Hi Prabhakar,
Thanks for the patch.
On Wed, Aug 29, 2012 at 06:01:07PM +0530, Prabhakar Lad wrote:
> From: Lad, Prabhakar <prabhakar.lad@ti.com>
>
> add V4L2_CID_DPCM_PREDICTOR control of type menu, which
> determines the dpcm predictor. The predictor can be either
> simple or advanced.
>
> Signed-off-by: Lad, Prabhakar <prabhakar.lad@ti.com>
> Signed-off-by: Manjunath Hadli <manjunath.hadli@ti.com>
> Cc: Sakari Ailus <sakari.ailus@iki.fi>
> Cc: Hans Verkuil <hans.verkuil@cisco.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> This patches has one checkpatch warning for line over
> 80 characters altough it can be avoided I have kept it
> for consistency.
>
> drivers/media/v4l2-core/v4l2-ctrls.c | 9 +++++++++
> include/linux/videodev2.h | 5 +++++
> 2 files changed, 14 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c
> index b6a2ee7..2d7bc15 100644
> --- a/drivers/media/v4l2-core/v4l2-ctrls.c
> +++ b/drivers/media/v4l2-core/v4l2-ctrls.c
> @@ -425,6 +425,11 @@ const char * const *v4l2_ctrl_get_menu(u32 id)
> "Gray",
> NULL,
> };
> + static const char * const dpcm_predictor[] = {
> + "Simple Predictor",
> + "Advanced Predictor",
> + NULL,
> + };
>
> switch (id) {
> case V4L2_CID_MPEG_AUDIO_SAMPLING_FREQ:
> @@ -502,6 +507,8 @@ const char * const *v4l2_ctrl_get_menu(u32 id)
> return mpeg4_profile;
> case V4L2_CID_JPEG_CHROMA_SUBSAMPLING:
> return jpeg_chroma_subsampling;
> + case V4L2_CID_DPCM_PREDICTOR:
> + return dpcm_predictor;
>
> default:
> return NULL;
> @@ -732,6 +739,7 @@ const char *v4l2_ctrl_get_name(u32 id)
> case V4L2_CID_IMAGE_PROC_CLASS: return "Image Processing Controls";
> case V4L2_CID_LINK_FREQ: return "Link Frequency";
> case V4L2_CID_PIXEL_RATE: return "Pixel Rate";
> + case V4L2_CID_DPCM_PREDICTOR: return "DPCM Predictor";
>
> default:
> return NULL;
> @@ -832,6 +840,7 @@ void v4l2_ctrl_fill(u32 id, const char **name, enum v4l2_ctrl_type *type,
> case V4L2_CID_ISO_SENSITIVITY_AUTO:
> case V4L2_CID_EXPOSURE_METERING:
> case V4L2_CID_SCENE_MODE:
> + case V4L2_CID_DPCM_PREDICTOR:
> *type = V4L2_CTRL_TYPE_MENU;
> break;
> case V4L2_CID_LINK_FREQ:
> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
> index 6d6dfa7..4edb941 100644
> --- a/include/linux/videodev2.h
> +++ b/include/linux/videodev2.h
> @@ -2000,6 +2000,11 @@ enum v4l2_jpeg_chroma_subsampling {
>
> #define V4L2_CID_LINK_FREQ (V4L2_CID_IMAGE_PROC_CLASS_BASE + 1)
> #define V4L2_CID_PIXEL_RATE (V4L2_CID_IMAGE_PROC_CLASS_BASE + 2)
> +#define V4L2_CID_DPCM_PREDICTOR (V4L2_CID_IMAGE_PROC_CLASS_BASE + 3)
> +enum v4l2_dpcm_predictor {
> + V4L2_DPCM_PREDICTOR_SIMPLE = 0,
> + V4L2_DPCM_PREDICTOR_ADVANCE = 1,
> +};
s/ADVANCE/ADVANCED/ perhaps?
To add to Sylwester's comment on the documentation, I think this control
belongs to the image processing controls class.
Kind regards,
--
Sakari Ailus
e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] media: v4l2-ctrls: add control for dpcm predictor
2012-08-29 14:21 ` Sakari Ailus
@ 2012-08-29 14:51 ` Prabhakar Lad
0 siblings, 0 replies; 5+ messages in thread
From: Prabhakar Lad @ 2012-08-29 14:51 UTC (permalink / raw)
To: Sakari Ailus
Cc: Prabhakar Lad, dlos, linux-kernel, Mauro Carvalho Chehab,
Hans de Goede, Kyungmin Park, Hans Verkuil, Sylwester Nawrocki,
LMML
Hi Sakari,
Thanks for the review.
On Wed, Aug 29, 2012 at 7:51 PM, Sakari Ailus <sakari.ailus@iki.fi> wrote:
> Hi Prabhakar,
>
> Thanks for the patch.
>
> On Wed, Aug 29, 2012 at 06:01:07PM +0530, Prabhakar Lad wrote:
>> From: Lad, Prabhakar <prabhakar.lad@ti.com>
>>
>> add V4L2_CID_DPCM_PREDICTOR control of type menu, which
>> determines the dpcm predictor. The predictor can be either
>> simple or advanced.
>>
>> Signed-off-by: Lad, Prabhakar <prabhakar.lad@ti.com>
>> Signed-off-by: Manjunath Hadli <manjunath.hadli@ti.com>
>> Cc: Sakari Ailus <sakari.ailus@iki.fi>
>> Cc: Hans Verkuil <hans.verkuil@cisco.com>
>> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
>> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
>> Cc: Hans de Goede <hdegoede@redhat.com>
>> Cc: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> This patches has one checkpatch warning for line over
>> 80 characters altough it can be avoided I have kept it
>> for consistency.
>>
>> drivers/media/v4l2-core/v4l2-ctrls.c | 9 +++++++++
>> include/linux/videodev2.h | 5 +++++
>> 2 files changed, 14 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c
>> index b6a2ee7..2d7bc15 100644
>> --- a/drivers/media/v4l2-core/v4l2-ctrls.c
>> +++ b/drivers/media/v4l2-core/v4l2-ctrls.c
>> @@ -425,6 +425,11 @@ const char * const *v4l2_ctrl_get_menu(u32 id)
>> "Gray",
>> NULL,
>> };
>> + static const char * const dpcm_predictor[] = {
>> + "Simple Predictor",
>> + "Advanced Predictor",
>> + NULL,
>> + };
>>
>> switch (id) {
>> case V4L2_CID_MPEG_AUDIO_SAMPLING_FREQ:
>> @@ -502,6 +507,8 @@ const char * const *v4l2_ctrl_get_menu(u32 id)
>> return mpeg4_profile;
>> case V4L2_CID_JPEG_CHROMA_SUBSAMPLING:
>> return jpeg_chroma_subsampling;
>> + case V4L2_CID_DPCM_PREDICTOR:
>> + return dpcm_predictor;
>>
>> default:
>> return NULL;
>> @@ -732,6 +739,7 @@ const char *v4l2_ctrl_get_name(u32 id)
>> case V4L2_CID_IMAGE_PROC_CLASS: return "Image Processing Controls";
>> case V4L2_CID_LINK_FREQ: return "Link Frequency";
>> case V4L2_CID_PIXEL_RATE: return "Pixel Rate";
>> + case V4L2_CID_DPCM_PREDICTOR: return "DPCM Predictor";
>>
>> default:
>> return NULL;
>> @@ -832,6 +840,7 @@ void v4l2_ctrl_fill(u32 id, const char **name, enum v4l2_ctrl_type *type,
>> case V4L2_CID_ISO_SENSITIVITY_AUTO:
>> case V4L2_CID_EXPOSURE_METERING:
>> case V4L2_CID_SCENE_MODE:
>> + case V4L2_CID_DPCM_PREDICTOR:
>> *type = V4L2_CTRL_TYPE_MENU;
>> break;
>> case V4L2_CID_LINK_FREQ:
>> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
>> index 6d6dfa7..4edb941 100644
>> --- a/include/linux/videodev2.h
>> +++ b/include/linux/videodev2.h
>> @@ -2000,6 +2000,11 @@ enum v4l2_jpeg_chroma_subsampling {
>>
>> #define V4L2_CID_LINK_FREQ (V4L2_CID_IMAGE_PROC_CLASS_BASE + 1)
>> #define V4L2_CID_PIXEL_RATE (V4L2_CID_IMAGE_PROC_CLASS_BASE + 2)
>> +#define V4L2_CID_DPCM_PREDICTOR (V4L2_CID_IMAGE_PROC_CLASS_BASE + 3)
>> +enum v4l2_dpcm_predictor {
>> + V4L2_DPCM_PREDICTOR_SIMPLE = 0,
>> + V4L2_DPCM_PREDICTOR_ADVANCE = 1,
>> +};
>
> s/ADVANCE/ADVANCED/ perhaps?
>
Ok I'll make it ADVANCED.
> To add to Sylwester's comment on the documentation, I think this control
> belongs to the image processing controls class.
>
I have added it as part of image processing control class itself
(#define V4L2_CID_DPCM_PREDICTOR (V4L2_CID_IMAGE_PROC_CLASS_BASE + 3)),
I'll include the same in documentation as well.
Thanks and Regards,
--Prabhakar Lad
> Kind regards,
>
> --
> Sakari Ailus
> e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
> _______________________________________________
> Davinci-linux-open-source mailing list
> Davinci-linux-open-source@linux.davincidsp.com
> http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-08-29 14:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-29 12:31 [PATCH] media: v4l2-ctrls: add control for dpcm predictor Prabhakar Lad
2012-08-29 12:43 ` Sylwester Nawrocki
2012-08-29 12:57 ` Prabhakar Lad
2012-08-29 14:21 ` Sakari Ailus
2012-08-29 14:51 ` Prabhakar Lad
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).