* [PATCH 4/5] drivers/media/platform/vino.c: fix error return code
@ 2012-09-04 16:14 Peter Senna Tschudin
2012-09-05 19:46 ` Ezequiel Garcia
0 siblings, 1 reply; 2+ messages in thread
From: Peter Senna Tschudin @ 2012-09-04 16:14 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: kernel-janitors, Julia.Lawall, linux-media, linux-kernel
From: Peter Senna Tschudin <peter.senna@gmail.com>
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/media/platform/vino.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/vino.c b/drivers/media/platform/vino.c
index cc9110c..6654a28 100644
--- a/drivers/media/platform/vino.c
+++ b/drivers/media/platform/vino.c
@@ -2061,6 +2061,7 @@ static int vino_capture_next(struct vino_channel_settings *vcs, int start)
}
if (incoming == 0) {
dprintk("vino_capture_next(): no buffers available\n");
+ err = -ENOMEM;
goto out;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 4/5] drivers/media/platform/vino.c: fix error return code
2012-09-04 16:14 [PATCH 4/5] drivers/media/platform/vino.c: fix error return code Peter Senna Tschudin
@ 2012-09-05 19:46 ` Ezequiel Garcia
0 siblings, 0 replies; 2+ messages in thread
From: Ezequiel Garcia @ 2012-09-05 19:46 UTC (permalink / raw)
To: Peter Senna Tschudin
Cc: Mauro Carvalho Chehab, kernel-janitors, Julia.Lawall,
linux-media, linux-kernel
Hi Peter,
On Tue, Sep 4, 2012 at 1:14 PM, Peter Senna Tschudin
<peter.senna@gmail.com> wrote:
> From: Peter Senna Tschudin <peter.senna@gmail.com>
>
> Convert a nonnegative error return code to a negative one, as returned
> elsewhere in the function.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> (
> if@p1 (\(ret < 0\|ret != 0\))
> { ... return ret; }
> |
> ret@p1 = 0
> )
> ... when != ret = e1
> when != &ret
> *if(...)
> {
> ... when != ret = e2
> when forall
> return ret;
> }
>
> // </smpl>
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
>
> ---
> drivers/media/platform/vino.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/vino.c b/drivers/media/platform/vino.c
> index cc9110c..6654a28 100644
> --- a/drivers/media/platform/vino.c
> +++ b/drivers/media/platform/vino.c
> @@ -2061,6 +2061,7 @@ static int vino_capture_next(struct vino_channel_settings *vcs, int start)
> }
> if (incoming == 0) {
> dprintk("vino_capture_next(): no buffers available\n");
> + err = -ENOMEM;
> goto out;
> }
>
Mmm, this one doesn't look good.
I think the intention was to return zero, without error.
They driver tt's just double-checking for incoming data, if there's no incoming
data, then he simply exits.
Thanks,
Ezequiel.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-05 19:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-04 16:14 [PATCH 4/5] drivers/media/platform/vino.c: fix error return code Peter Senna Tschudin
2012-09-05 19:46 ` Ezequiel Garcia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).