From: Tim Chen <tim.c.chen@linux.intel.com>
To: Matthew Wilcox <willy@linux.intel.com>
Cc: Mel Gorman <mel@csn.ul.ie>,
Andrew Morton <akpm@linux-foundation.org>,
Minchan Kim <minchan@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>,
linux-mm@kvack.org, linux-kernel <linux-kernel@vger.kernel.org>,
Alex Shi <alex.shi@intel.com>
Subject: Re: [RFC PATCH 2/2] mm: Batch page_check_references in shrink_page_list sharing the same i_mmap_mutex
Date: Tue, 04 Sep 2012 15:54:19 -0700 [thread overview]
Message-ID: <1346799259.13492.272.camel@schen9-DESK> (raw)
In-Reply-To: <1346772077.13492.267.camel@schen9-DESK>
On Tue, 2012-09-04 at 08:21 -0700, Tim Chen wrote:
> On Tue, 2012-08-21 at 17:48 -0700, Tim Chen wrote:
>
> >
> > Thanks to Matthew's suggestions on improving the patch. Here's the
> > updated version. It seems to be sane when I booted my machine up. I
> > will put it through more testing when I get a chance.
> >
> > Tim
> >
>
> Matthew,
>
> The new patch seems to be causing some of the workloads with mmaped file
> read to seg fault. Will need to dig further to find out why.
>
> Tim
>
Okay, the problem seems to be the code below. It is too restrictive and
causes some cases where the mutex needs to be taken in try_to_unmap_file
to be missed.
> > +int needs_page_mmap_mutex(struct page *page)
> > +{
> > + return page->mapping && page_mapped(page) && page_rmapping(page) &&
> > + !PageKsm(page) && !PageAnon(page);
> > +}
> > +
Changing the check to the following fixes the problem:
@@ -873,8 +873,7 @@ static int page_referenced_file(struct page *page,
int needs_page_mmap_mutex(struct page *page)
{
- return page->mapping && page_mapped(page) && page_rmapping(page) &&
- !PageKsm(page) && !PageAnon(page);
+ return page->mapping && !PageKsm(page) && !PageAnon(page);
}
I'll do more testing and generate a second version of the patch set with the fixes.
Tim
prev parent reply other threads:[~2012-09-04 22:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-18 1:06 [RFC PATCH 2/2] mm: Batch page_check_references in shrink_page_list sharing the same i_mmap_mutex Tim Chen
2012-08-20 16:43 ` Tim Chen
2012-08-21 13:21 ` Matthew Wilcox
2012-08-21 17:51 ` Tim Chen
2012-08-21 22:53 ` Tim Chen
2012-08-22 0:48 ` Tim Chen
2012-08-23 18:33 ` Matthew Wilcox
2012-09-04 15:21 ` Tim Chen
2012-09-04 22:54 ` Tim Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346799259.13492.272.camel@schen9-DESK \
--to=tim.c.chen@linux.intel.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@intel.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan@kernel.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).