From: Paolo Bonzini <pbonzini@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: target-devel@vger.kernel.org
Subject: [RFC PATCH 0/3] target: try satisfying memory requests with higher-order allocations
Date: Wed, 5 Sep 2012 17:13:42 +0200 [thread overview]
Message-ID: <1346858025-10459-1-git-send-email-pbonzini@redhat.com> (raw)
Hi all,
while testing PSCSI I noticed that even requests for a smallish amount
of data (approximately 700 KB) failed due to an excessive number of
segments in the request. In fact, using alloc_page resulted in a
completely fragmented request, with no merging of consecutive pages
at all.
This patch series fixes this problem by using higher-order allocations
to build the data scatterlist. The problem is that iscsi assumes that the
scatterlist consists of single pages, which is not true anymore. So
patch 2 has to introduce some relatively complicated changes to
iscsi_map_iovec and iscsi_unmap_iovec.
While doing this, I noticed something strange in iscsit_do_crypto_hash_sg.
Patch 1 adds a warning about it.
The approach may be completely wrong and it needs more testing anyway.
Please review!
Paolo
Paolo Bonzini (3):
tcm_iscsi: warn on incorrect precondition for iscsit_do_crypto_hash_sg
tcm_iscsi: support multiple sizes in the scatterlist
target: try satisfying memory requests with contiguous blocks
drivers/target/iscsi/iscsi_target.c | 106 +++++++++++++++++++++++++-----
drivers/target/iscsi/iscsi_target_core.h | 2 +-
drivers/target/target_core_transport.c | 58 ++++++++++++++---
3 files changed, 138 insertions(+), 28 deletions(-)
next reply other threads:[~2012-09-05 15:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 15:13 Paolo Bonzini [this message]
2012-09-05 15:13 ` [RFC PATCH 1/3] tcm_iscsi: warn on incorrect precondition for iscsit_do_crypto_hash_sg Paolo Bonzini
2012-09-05 15:13 ` [RFC PATCH 2/3] tcm_iscsi: support multiple sizes in the scatterlist Paolo Bonzini
2012-09-06 2:33 ` Nicholas A. Bellinger
2012-09-05 15:13 ` [RFC PATCH 3/3] target: try satisfying memory requests with contiguous blocks Paolo Bonzini
2012-09-06 2:19 ` Nicholas A. Bellinger
2012-09-06 1:58 ` [RFC PATCH 0/3] target: try satisfying memory requests with higher-order allocations Nicholas A. Bellinger
2012-09-06 9:04 ` Paolo Bonzini
2012-09-06 18:52 ` Nicholas A. Bellinger
2012-09-06 20:49 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346858025-10459-1-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).