From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, target-devel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [RFC PATCH 0/3] target: try satisfying memory requests with higher-order allocations
Date: Wed, 05 Sep 2012 18:58:18 -0700 [thread overview]
Message-ID: <1346896698.4162.403.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <1346858025-10459-1-git-send-email-pbonzini@redhat.com>
On Wed, 2012-09-05 at 17:13 +0200, Paolo Bonzini wrote:
> Hi all,
>
> while testing PSCSI I noticed that even requests for a smallish amount
> of data (approximately 700 KB) failed due to an excessive number of
> segments in the request. In fact, using alloc_page resulted in a
> completely fragmented request, with no merging of consecutive pages
> at all.
>
> This patch series fixes this problem by using higher-order allocations
> to build the data scatterlist. The problem is that iscsi assumes that the
> scatterlist consists of single pages, which is not true anymore. So
> patch 2 has to introduce some relatively complicated changes to
> iscsi_map_iovec and iscsi_unmap_iovec.
>
So enabling multi-page per SGL support is a feature that has been
dormant within target core for a long time. It's about time that we
start taking advantage of it again. ;)
> While doing this, I noticed something strange in iscsit_do_crypto_hash_sg.
> Patch 1 adds a warning about it.
>
Mmmmm, looks like a separate bug with DataDigest enabled.
> The approach may be completely wrong and it needs more testing anyway.
> Please review!
>
Adding my comments inline.
Thanks Paolo!
--nab
> Paolo
>
> Paolo Bonzini (3):
> tcm_iscsi: warn on incorrect precondition for iscsit_do_crypto_hash_sg
> tcm_iscsi: support multiple sizes in the scatterlist
> target: try satisfying memory requests with contiguous blocks
>
> drivers/target/iscsi/iscsi_target.c | 106 +++++++++++++++++++++++++-----
> drivers/target/iscsi/iscsi_target_core.h | 2 +-
> drivers/target/target_core_transport.c | 58 ++++++++++++++---
> 3 files changed, 138 insertions(+), 28 deletions(-)
>
> --
> To unsubscribe from this list: send the line "unsubscribe target-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-09-06 1:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 15:13 [RFC PATCH 0/3] target: try satisfying memory requests with higher-order allocations Paolo Bonzini
2012-09-05 15:13 ` [RFC PATCH 1/3] tcm_iscsi: warn on incorrect precondition for iscsit_do_crypto_hash_sg Paolo Bonzini
2012-09-05 15:13 ` [RFC PATCH 2/3] tcm_iscsi: support multiple sizes in the scatterlist Paolo Bonzini
2012-09-06 2:33 ` Nicholas A. Bellinger
2012-09-05 15:13 ` [RFC PATCH 3/3] target: try satisfying memory requests with contiguous blocks Paolo Bonzini
2012-09-06 2:19 ` Nicholas A. Bellinger
2012-09-06 1:58 ` Nicholas A. Bellinger [this message]
2012-09-06 9:04 ` [RFC PATCH 0/3] target: try satisfying memory requests with higher-order allocations Paolo Bonzini
2012-09-06 18:52 ` Nicholas A. Bellinger
2012-09-06 20:49 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346896698.4162.403.camel@haakon2.linux-iscsi.org \
--to=nab@linux-iscsi.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).