* [PATCH] Kbuild: use normal compression settings for tar*-pkg
@ 2012-09-08 19:47 Andi Kleen
2012-09-11 0:46 ` Fengguang Wu
2012-09-12 16:01 ` Zdenek Kaspar
0 siblings, 2 replies; 7+ messages in thread
From: Andi Kleen @ 2012-09-08 19:47 UTC (permalink / raw)
To: mmarek; +Cc: linux-kbuild, linux-kernel, Andi Kleen
From: Andi Kleen <ak@linux.intel.com>
For large kernel configurations (like a distribution kernel)
targz-pkg takes a quite long time to just do the compression.
I clocked it at 15+mins for a SUSE kernel like config on a fast
system. And tarxz and bzip2 are even slower.
The main reason is that the script that is doing the taring sets
the highest compression level (-9). When I change it to just
use the defaults the gzip time for the same kernel goes down
to ~3 mins. I haven't tested xz and bzip, but I expect those
to be much faster too.
I'm not willing to wait that long for a small compression
gain. So just change the script to use the defaults.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
scripts/package/buildtar | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/package/buildtar b/scripts/package/buildtar
index 8a7b155..632377f 100644
--- a/scripts/package/buildtar
+++ b/scripts/package/buildtar
@@ -28,15 +28,15 @@ case "${1}" in
file_ext=""
;;
targz-pkg)
- compress="gzip -c9"
+ compress="gzip"
file_ext=".gz"
;;
tarbz2-pkg)
- compress="bzip2 -c9"
+ compress="bzip2"
file_ext=".bz2"
;;
tarxz-pkg)
- compress="xz -c9"
+ compress="xz"
file_ext=".xz"
;;
*)
--
1.7.7.6
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] Kbuild: use normal compression settings for tar*-pkg
2012-09-08 19:47 [PATCH] Kbuild: use normal compression settings for tar*-pkg Andi Kleen
@ 2012-09-11 0:46 ` Fengguang Wu
2012-09-11 3:01 ` Andi Kleen
2012-09-27 15:06 ` Michal Marek
2012-09-12 16:01 ` Zdenek Kaspar
1 sibling, 2 replies; 7+ messages in thread
From: Fengguang Wu @ 2012-09-11 0:46 UTC (permalink / raw)
To: Andi Kleen; +Cc: mmarek, linux-kbuild, linux-kernel, Andi Kleen
On Sat, Sep 08, 2012 at 12:47:59PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> For large kernel configurations (like a distribution kernel)
> targz-pkg takes a quite long time to just do the compression.
> I clocked it at 15+mins for a SUSE kernel like config on a fast
> system. And tarxz and bzip2 are even slower.
>
> The main reason is that the script that is doing the taring sets
> the highest compression level (-9). When I change it to just
> use the defaults the gzip time for the same kernel goes down
> to ~3 mins. I haven't tested xz and bzip, but I expect those
> to be much faster too.
>
> I'm not willing to wait that long for a small compression
> gain. So just change the script to use the defaults.
Makes sense to me.
Reviewed-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
> scripts/package/buildtar | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/package/buildtar b/scripts/package/buildtar
> index 8a7b155..632377f 100644
> --- a/scripts/package/buildtar
> +++ b/scripts/package/buildtar
> @@ -28,15 +28,15 @@ case "${1}" in
> file_ext=""
> ;;
> targz-pkg)
> - compress="gzip -c9"
> + compress="gzip"
-c should be kept because it means --stdout and --keep
> file_ext=".gz"
> ;;
> tarbz2-pkg)
> - compress="bzip2 -c9"
> + compress="bzip2"
ditto
> file_ext=".bz2"
> ;;
> tarxz-pkg)
> - compress="xz -c9"
> + compress="xz"
ditto
> file_ext=".xz"
> ;;
> *)
> --
> 1.7.7.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Kbuild: use normal compression settings for tar*-pkg
2012-09-11 0:46 ` Fengguang Wu
@ 2012-09-11 3:01 ` Andi Kleen
2012-09-11 4:21 ` Fengguang Wu
2012-09-27 15:06 ` Michal Marek
1 sibling, 1 reply; 7+ messages in thread
From: Andi Kleen @ 2012-09-11 3:01 UTC (permalink / raw)
To: Fengguang Wu; +Cc: Andi Kleen, mmarek, linux-kbuild, linux-kernel, Andi Kleen
>
> -c should be kept because it means --stdout and --keep
It seems to work without it.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Kbuild: use normal compression settings for tar*-pkg
2012-09-11 3:01 ` Andi Kleen
@ 2012-09-11 4:21 ` Fengguang Wu
0 siblings, 0 replies; 7+ messages in thread
From: Fengguang Wu @ 2012-09-11 4:21 UTC (permalink / raw)
To: Andi Kleen; +Cc: mmarek, linux-kbuild, linux-kernel, Andi Kleen
On Tue, Sep 11, 2012 at 05:01:09AM +0200, Andi Kleen wrote:
> >
> > -c should be kept because it means --stdout and --keep
>
> It seems to work without it.
Yeah I see: it's used in the pipe anyway:
tar cf - . $opts | ${compress} > "${tarball}${file_ext}"
Thanks,
Fengguang
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Kbuild: use normal compression settings for tar*-pkg
2012-09-08 19:47 [PATCH] Kbuild: use normal compression settings for tar*-pkg Andi Kleen
2012-09-11 0:46 ` Fengguang Wu
@ 2012-09-12 16:01 ` Zdenek Kaspar
2012-09-12 16:16 ` Andi Kleen
1 sibling, 1 reply; 7+ messages in thread
From: Zdenek Kaspar @ 2012-09-12 16:01 UTC (permalink / raw)
To: Andi Kleen; +Cc: mmarek, linux-kbuild, linux-kernel, Andi Kleen
On 09/08/2012 09:47 PM, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> For large kernel configurations (like a distribution kernel)
> targz-pkg takes a quite long time to just do the compression.
> I clocked it at 15+mins for a SUSE kernel like config on a fast
> system. And tarxz and bzip2 are even slower.
>
> The main reason is that the script that is doing the taring sets
> the highest compression level (-9). When I change it to just
> use the defaults the gzip time for the same kernel goes down
> to ~3 mins. I haven't tested xz and bzip, but I expect those
> to be much faster too.
>
> I'm not willing to wait that long for a small compression
> gain. So just change the script to use the defaults.
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
> scripts/package/buildtar | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/package/buildtar b/scripts/package/buildtar
> index 8a7b155..632377f 100644
> --- a/scripts/package/buildtar
> +++ b/scripts/package/buildtar
> @@ -28,15 +28,15 @@ case "${1}" in
> file_ext=""
> ;;
> targz-pkg)
> - compress="gzip -c9"
> + compress="gzip"
> file_ext=".gz"
> ;;
> tarbz2-pkg)
> - compress="bzip2 -c9"
> + compress="bzip2"
> file_ext=".bz2"
> ;;
> tarxz-pkg)
> - compress="xz -c9"
> + compress="xz"
> file_ext=".xz"
> ;;
> *)
Maybe add new default compression options or rename actual ones to -hc-
(high compression) if users dont like it much?
Z.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Kbuild: use normal compression settings for tar*-pkg
2012-09-12 16:01 ` Zdenek Kaspar
@ 2012-09-12 16:16 ` Andi Kleen
0 siblings, 0 replies; 7+ messages in thread
From: Andi Kleen @ 2012-09-12 16:16 UTC (permalink / raw)
To: Zdenek Kaspar; +Cc: Andi Kleen, mmarek, linux-kbuild, linux-kernel, Andi Kleen
> Maybe add new default compression options or rename actual ones to -hc-
> (high compression) if users dont like it much?
Doesn't sound useful to me. The normal ones are good enough.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Kbuild: use normal compression settings for tar*-pkg
2012-09-11 0:46 ` Fengguang Wu
2012-09-11 3:01 ` Andi Kleen
@ 2012-09-27 15:06 ` Michal Marek
1 sibling, 0 replies; 7+ messages in thread
From: Michal Marek @ 2012-09-27 15:06 UTC (permalink / raw)
To: Fengguang Wu; +Cc: Andi Kleen, linux-kbuild, linux-kernel, Andi Kleen
On 11.9.2012 02:46, Fengguang Wu wrote:
> On Sat, Sep 08, 2012 at 12:47:59PM -0700, Andi Kleen wrote:
>> From: Andi Kleen <ak@linux.intel.com>
>>
>> For large kernel configurations (like a distribution kernel)
>> targz-pkg takes a quite long time to just do the compression.
>> I clocked it at 15+mins for a SUSE kernel like config on a fast
>> system. And tarxz and bzip2 are even slower.
>>
>> The main reason is that the script that is doing the taring sets
>> the highest compression level (-9). When I change it to just
>> use the defaults the gzip time for the same kernel goes down
>> to ~3 mins. I haven't tested xz and bzip, but I expect those
>> to be much faster too.
>>
>> I'm not willing to wait that long for a small compression
>> gain. So just change the script to use the defaults.
>
> Makes sense to me.
>
> Reviewed-by: Fengguang Wu <fengguang.wu@intel.com>
Applied to kbuild.git#kbuild.
Michal
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-09-27 15:06 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-08 19:47 [PATCH] Kbuild: use normal compression settings for tar*-pkg Andi Kleen
2012-09-11 0:46 ` Fengguang Wu
2012-09-11 3:01 ` Andi Kleen
2012-09-11 4:21 ` Fengguang Wu
2012-09-27 15:06 ` Michal Marek
2012-09-12 16:01 ` Zdenek Kaspar
2012-09-12 16:16 ` Andi Kleen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).