From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"mingo@elte.hu" <mingo@elte.hu>,
"ak@linux.intel.com" <ak@linux.intel.com>,
"Yan, Zheng" <zheng.z.yan@intel.com>,
Robert Richter <robert.richter@amd.com>
Subject: Re: [PATCH v2 2/3] perf: use hrtimer for event multiplexing
Date: Thu, 13 Sep 2012 14:26:20 +0200 [thread overview]
Message-ID: <1347539180.7172.0.camel@twins> (raw)
In-Reply-To: <CABPqkBQO2fHoidvubDiL9AhCY-FZkk5_WGyPxerT1noH41R53w@mail.gmail.com>
On Thu, 2012-09-13 at 14:20 +0200, Stephane Eranian wrote:
> On Thu, Sep 13, 2012 at 2:16 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> > On Wed, 2012-09-12 at 17:37 +0200, Stephane Eranian wrote:
> >
> >> Note however that the rotation_list is still used in perf_event_task_tick()
> >> to iterate over the ctx which needs unthrottling. We would have to switch
> >> that loop over to a for-each-pmu() which would necessary incur more
> >> iterations as it would include all the SW PMUs.
> >
> > Oh urgh, right. I think that was one of the reasons I bailed on the
> > hrtimer thing, the frequency and throttle stuff.
> >
> > ctx->nr_freq and needs_unthr could help, but yeah.
>
> I think for now, we could keep rotation list for the unthrottling.
> Multiplexing won't use rotation_list anymore.
wouldn't that still have the problem where we take the sw-pmus off of
the rotation-list?
next prev parent reply other threads:[~2012-09-13 12:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 14:13 [PATCH v2 0/3] perf: use hrtimer for event multiplexing Stephane Eranian
2012-09-12 14:13 ` [PATCH v2 1/3] hrtimer: add hrtimer_init_cpu() Stephane Eranian
2012-09-12 14:22 ` Eric Dumazet
2012-09-12 14:26 ` Peter Zijlstra
2012-09-12 14:33 ` Stephane Eranian
2012-09-12 14:38 ` Peter Zijlstra
2012-09-12 14:46 ` Stephane Eranian
2012-09-12 14:49 ` Peter Zijlstra
2012-09-12 14:51 ` Stephane Eranian
2012-09-12 14:13 ` [PATCH v2 2/3] perf: use hrtimer for event multiplexing Stephane Eranian
2012-09-12 14:22 ` Peter Zijlstra
2012-09-12 14:43 ` Stephane Eranian
2012-09-12 14:44 ` Peter Zijlstra
2012-09-12 14:48 ` Stephane Eranian
2012-09-12 14:50 ` Peter Zijlstra
2012-09-12 15:37 ` Stephane Eranian
2012-09-12 15:49 ` Stephane Eranian
2012-09-13 12:16 ` Peter Zijlstra
2012-09-13 12:20 ` Stephane Eranian
2012-09-13 12:26 ` Peter Zijlstra [this message]
2012-09-13 12:27 ` Stephane Eranian
2012-09-13 12:29 ` Peter Zijlstra
2012-09-12 14:13 ` [PATCH v2 3/3] perf: add sysfs entry to adjust multiplexing interval per PMU Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347539180.7172.0.camel@twins \
--to=peterz@infradead.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=robert.richter@amd.com \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).