From: Stephane Eranian <eranian@google.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
"mingo@elte.hu" <mingo@elte.hu>,
"ak@linux.intel.com" <ak@linux.intel.com>,
"Yan, Zheng" <zheng.z.yan@intel.com>,
Robert Richter <robert.richter@amd.com>,
Thomas Gleixner <tglx@linutronix.de>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH v2 1/3] hrtimer: add hrtimer_init_cpu()
Date: Wed, 12 Sep 2012 16:46:57 +0200 [thread overview]
Message-ID: <CABPqkBSCY1N8Zc9ZxRYmQykqg+hiukxW4ZRMWkp9wfaOSzgGrA@mail.gmail.com> (raw)
In-Reply-To: <1347460719.15764.42.camel@twins>
On Wed, Sep 12, 2012 at 4:38 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Wed, 2012-09-12 at 16:33 +0200, Stephane Eranian wrote:
>
>>
>> If I do:
>> for_each_possible_cpu(cpu) {
>> cpuctx = per_cpu_ptr(pmu->pmu_cpu_context, cpu);
>> hr = &cpuctx->hrtimer;
>> hrtimer_init(hr)
>> }
>> I don't understand why I would have to refer to per-cpu data
>> (hrtimer_bases) from
>> a CPU that is not equal to "cpu" here. Unless you're telling me it's
>> read-only data.
>
> No its not read only, but it is unused until you do *hrtimer_start*(),
> which will test and fix.
>
>> But still if it's per-cpu why not initialize with the correct CPU from
>> the start?
>
> To keep the interface simpler I guess. There's no great harm in your
> proposal, but it is strictly speaking superfluous. I'm not sure the max
> one time avoidance of a base swizzle is worth the extra interface, I'll
> leave that up to Thomas.
>
> Also, what Eric said ;-)
I am fine with dropping this patch. I just found it odd there was a per-cpu
data reference embedded deep into the call. I wanted things to be more
explicit. I know it works without the proposed change.
next prev parent reply other threads:[~2012-09-12 14:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 14:13 [PATCH v2 0/3] perf: use hrtimer for event multiplexing Stephane Eranian
2012-09-12 14:13 ` [PATCH v2 1/3] hrtimer: add hrtimer_init_cpu() Stephane Eranian
2012-09-12 14:22 ` Eric Dumazet
2012-09-12 14:26 ` Peter Zijlstra
2012-09-12 14:33 ` Stephane Eranian
2012-09-12 14:38 ` Peter Zijlstra
2012-09-12 14:46 ` Stephane Eranian [this message]
2012-09-12 14:49 ` Peter Zijlstra
2012-09-12 14:51 ` Stephane Eranian
2012-09-12 14:13 ` [PATCH v2 2/3] perf: use hrtimer for event multiplexing Stephane Eranian
2012-09-12 14:22 ` Peter Zijlstra
2012-09-12 14:43 ` Stephane Eranian
2012-09-12 14:44 ` Peter Zijlstra
2012-09-12 14:48 ` Stephane Eranian
2012-09-12 14:50 ` Peter Zijlstra
2012-09-12 15:37 ` Stephane Eranian
2012-09-12 15:49 ` Stephane Eranian
2012-09-13 12:16 ` Peter Zijlstra
2012-09-13 12:20 ` Stephane Eranian
2012-09-13 12:26 ` Peter Zijlstra
2012-09-13 12:27 ` Stephane Eranian
2012-09-13 12:29 ` Peter Zijlstra
2012-09-12 14:13 ` [PATCH v2 3/3] perf: add sysfs entry to adjust multiplexing interval per PMU Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABPqkBSCY1N8Zc9ZxRYmQykqg+hiukxW4ZRMWkp9wfaOSzgGrA@mail.gmail.com \
--to=eranian@google.com \
--cc=ak@linux.intel.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=robert.richter@amd.com \
--cc=tglx@linutronix.de \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).