linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm: tegra: dt: Add pinmux entries for Vbus regulator controls
@ 2012-09-14  9:25 Venu Byravarasu
  2012-09-14 14:15 ` Laxman Dewangan
  2012-09-14 15:31 ` Stephen Warren
  0 siblings, 2 replies; 3+ messages in thread
From: Venu Byravarasu @ 2012-09-14  9:25 UTC (permalink / raw)
  To: swarren, linux
  Cc: linux-kernel, linux-tegra, linux-arm-kernel, Venu Byravarasu

Adding pinmux entries for PI4 and PH7 to enable Vbus for USB1
and USB3 controllers on Cardhu A02 board.

Signed-off-by: Venu Byravarasu <vbyravarasu@nvidia.com>
---

 arch/arm/boot/dts/tegra30-cardhu-a02.dts |   20 ++++++++++++++++++++
 1 files changed, 20 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/tegra30-cardhu-a02.dts b/arch/arm/boot/dts/tegra30-cardhu-a02.dts
index dd4222f..b76ad31 100644
--- a/arch/arm/boot/dts/tegra30-cardhu-a02.dts
+++ b/arch/arm/boot/dts/tegra30-cardhu-a02.dts
@@ -8,6 +8,26 @@
 	model = "NVIDIA Tegra30 Cardhu A02 evaluation board";
 	compatible = "nvidia,cardhu-a02", "nvidia,cardhu", "nvidia,tegra30";
 
+	pinmux {
+		gmi_rst_n_pi4 {
+			nvidia,pins = "gmi_rst_n_pi4";
+			nvidia,function = "gmi";
+			nvidia,tristate = <0>;
+			nvidia,enable-input = <1>;
+			nvidia,open-drain = <1>;
+			nvidia,pull = <0>;
+		};
+
+		gmi_ad15_ph7 {
+			nvidia,pins = "gmi_ad15_ph7";
+			nvidia,function = "gmi";
+			nvidia,tristate = <0>;
+			nvidia,enable-input = <1>;
+			nvidia,open-drain = <1>;
+			nvidia,pull = <0>;
+		};
+	};
+
 	regulators {
 		compatible = "simple-bus";
 		#address-cells = <1>;
-- 
1.7.1.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm: tegra: dt: Add pinmux entries for Vbus regulator controls
  2012-09-14  9:25 [PATCH] arm: tegra: dt: Add pinmux entries for Vbus regulator controls Venu Byravarasu
@ 2012-09-14 14:15 ` Laxman Dewangan
  2012-09-14 15:31 ` Stephen Warren
  1 sibling, 0 replies; 3+ messages in thread
From: Laxman Dewangan @ 2012-09-14 14:15 UTC (permalink / raw)
  To: Venu Byravarasu
  Cc: swarren, linux, linux-kernel, linux-tegra, linux-arm-kernel

On Friday 14 September 2012 02:55 PM, Venu Byravarasu wrote:
> Adding pinmux entries for PI4 and PH7 to enable Vbus for USB1
> and USB3 controllers on Cardhu A02 board.
>
> Signed-off-by: Venu Byravarasu<vbyravarasu@nvidia.com>
> ---
Looks good.
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm: tegra: dt: Add pinmux entries for Vbus regulator controls
  2012-09-14  9:25 [PATCH] arm: tegra: dt: Add pinmux entries for Vbus regulator controls Venu Byravarasu
  2012-09-14 14:15 ` Laxman Dewangan
@ 2012-09-14 15:31 ` Stephen Warren
  1 sibling, 0 replies; 3+ messages in thread
From: Stephen Warren @ 2012-09-14 15:31 UTC (permalink / raw)
  To: Venu Byravarasu; +Cc: linux, linux-kernel, linux-tegra, linux-arm-kernel

On 09/14/2012 03:25 AM, Venu Byravarasu wrote:
> Adding pinmux entries for PI4 and PH7 to enable Vbus for USB1
> and USB3 controllers on Cardhu A02 board.
> 
> Signed-off-by: Venu Byravarasu <vbyravarasu@nvidia.com>

Given our internal discussions about whether to and how to configure
open-drain and enable-input on these pins, I'd like to hold off on this
patch. Lets resolve this internally first.

Also, I assume we'll need an equivalent patch for Cardhu A04 too.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-09-14 15:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-14  9:25 [PATCH] arm: tegra: dt: Add pinmux entries for Vbus regulator controls Venu Byravarasu
2012-09-14 14:15 ` Laxman Dewangan
2012-09-14 15:31 ` Stephen Warren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).